Skip to content
Snippets Groups Projects
Commit 488663df authored by OZGCloud's avatar OZGCloud
Browse files

OZG-6640 [test] do clean up

parent 42469fd6
No related branches found
No related tags found
No related merge requests found
...@@ -610,13 +610,9 @@ class PostfachServiceTest { ...@@ -610,13 +610,9 @@ class PostfachServiceTest {
@Test @Test
void shouldCallLogSendMailFailed() { void shouldCallLogSendMailFailed() {
// var logCaptor = LogCaptor.forClass(PostfachService.class);
service.handleSendMail(COMMAND_ID, mail); service.handleSendMail(COMMAND_ID, mail);
verify(service).logSendMailFailed(COMMAND_ID, POSTFACH_EXCEPTION); verify(service).logSendMailFailed(COMMAND_ID, POSTFACH_EXCEPTION);
// assertThat(logCaptor.getLogEvents().get(0).getLevel()).isEqualTo(LogLevel.ERROR.name());
// assertThat(logCaptor.getLogEvents().get(0).getMessage()).startsWith(MESSAGE);
} }
@Test @Test
...@@ -624,7 +620,7 @@ class PostfachServiceTest { ...@@ -624,7 +620,7 @@ class PostfachServiceTest {
var response = service.handleSendMail(COMMAND_ID, mail); var response = service.handleSendMail(COMMAND_ID, mail);
assertThat(response.isSentSuccessful()).isFalse(); assertThat(response.isSentSuccessful()).isFalse();
assertThat(response.getMessageCode()).isEqualTo(PostfachMessageCode.SEND_SUCCESSFUL_MESSAGE_CODE); assertThat(response.getMessageCode()).isEqualTo(PostfachMessageCode.PROCESS_FAILED_MESSAGE_CODE);
} }
} }
...@@ -649,17 +645,6 @@ class PostfachServiceTest { ...@@ -649,17 +645,6 @@ class PostfachServiceTest {
assertThat(eventFailedCaptor.getValue().getErrorMessage()).startsWith(MESSAGE); assertThat(eventFailedCaptor.getValue().getErrorMessage()).startsWith(MESSAGE);
} }
@Test
void shouldLogWarning() {
var logCaptor = LogCaptor.forClass(PostfachService.class);
service.handleSendMail(COMMAND_ID, mail);
// verify(service).proceedwithWarnException(eq(COMMAND_ID), any(OsiPostfachServerProcessException.class));
assertThat(logCaptor.getLogEvents().get(0).getLevel()).isEqualTo(LogLevel.WARN.name());
assertThat(logCaptor.getLogEvents().get(0).getMessage()).startsWith(MESSAGE);
}
@Test @Test
void shouldReturnResponse() { void shouldReturnResponse() {
var response = service.handleSendMail(COMMAND_ID, mail); var response = service.handleSendMail(COMMAND_ID, mail);
...@@ -674,6 +659,7 @@ class PostfachServiceTest { ...@@ -674,6 +659,7 @@ class PostfachServiceTest {
@Nested @Nested
class TestLogSendMailFailed { class TestLogSendMailFailed {
@DisplayName("should log warning on OsiPostfachServerProcessException")
@Test @Test
void shouldLogWarningWhenOsiException() { void shouldLogWarningWhenOsiException() {
try (var logCaptor = LogCaptor.forClass(PostfachService.class)) { try (var logCaptor = LogCaptor.forClass(PostfachService.class)) {
...@@ -685,6 +671,7 @@ class PostfachServiceTest { ...@@ -685,6 +671,7 @@ class PostfachServiceTest {
} }
} }
@DisplayName("should log warning when error code is unknown postfach id")
@Test @Test
void shouldLogWarningWhenWrongPostfachId() { void shouldLogWarningWhenWrongPostfachId() {
try (var logCaptor = LogCaptor.forClass(PostfachService.class)) { try (var logCaptor = LogCaptor.forClass(PostfachService.class)) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment