Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
N
nachrichten-manager
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
OZG-Cloud
app
nachrichten-manager
Commits
488663df
Commit
488663df
authored
7 months ago
by
OZGCloud
Browse files
Options
Downloads
Patches
Plain Diff
OZG-6640 [test] do clean up
parent
42469fd6
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
nachrichten-manager-server/src/test/java/de/ozgcloud/nachrichten/postfach/PostfachServiceTest.java
+3
-16
3 additions, 16 deletions
...de/ozgcloud/nachrichten/postfach/PostfachServiceTest.java
with
3 additions
and
16 deletions
nachrichten-manager-server/src/test/java/de/ozgcloud/nachrichten/postfach/PostfachServiceTest.java
+
3
−
16
View file @
488663df
...
@@ -610,13 +610,9 @@ class PostfachServiceTest {
...
@@ -610,13 +610,9 @@ class PostfachServiceTest {
@Test
@Test
void
shouldCallLogSendMailFailed
()
{
void
shouldCallLogSendMailFailed
()
{
// var logCaptor = LogCaptor.forClass(PostfachService.class);
service
.
handleSendMail
(
COMMAND_ID
,
mail
);
service
.
handleSendMail
(
COMMAND_ID
,
mail
);
verify
(
service
).
logSendMailFailed
(
COMMAND_ID
,
POSTFACH_EXCEPTION
);
verify
(
service
).
logSendMailFailed
(
COMMAND_ID
,
POSTFACH_EXCEPTION
);
// assertThat(logCaptor.getLogEvents().get(0).getLevel()).isEqualTo(LogLevel.ERROR.name());
// assertThat(logCaptor.getLogEvents().get(0).getMessage()).startsWith(MESSAGE);
}
}
@Test
@Test
...
@@ -624,7 +620,7 @@ class PostfachServiceTest {
...
@@ -624,7 +620,7 @@ class PostfachServiceTest {
var
response
=
service
.
handleSendMail
(
COMMAND_ID
,
mail
);
var
response
=
service
.
handleSendMail
(
COMMAND_ID
,
mail
);
assertThat
(
response
.
isSentSuccessful
()).
isFalse
();
assertThat
(
response
.
isSentSuccessful
()).
isFalse
();
assertThat
(
response
.
getMessageCode
()).
isEqualTo
(
PostfachMessageCode
.
SEND_SUCCESSFUL
_MESSAGE_CODE
);
assertThat
(
response
.
getMessageCode
()).
isEqualTo
(
PostfachMessageCode
.
PROCESS_FAILED
_MESSAGE_CODE
);
}
}
}
}
...
@@ -649,17 +645,6 @@ class PostfachServiceTest {
...
@@ -649,17 +645,6 @@ class PostfachServiceTest {
assertThat
(
eventFailedCaptor
.
getValue
().
getErrorMessage
()).
startsWith
(
MESSAGE
);
assertThat
(
eventFailedCaptor
.
getValue
().
getErrorMessage
()).
startsWith
(
MESSAGE
);
}
}
@Test
void
shouldLogWarning
()
{
var
logCaptor
=
LogCaptor
.
forClass
(
PostfachService
.
class
);
service
.
handleSendMail
(
COMMAND_ID
,
mail
);
// verify(service).proceedwithWarnException(eq(COMMAND_ID), any(OsiPostfachServerProcessException.class));
assertThat
(
logCaptor
.
getLogEvents
().
get
(
0
).
getLevel
()).
isEqualTo
(
LogLevel
.
WARN
.
name
());
assertThat
(
logCaptor
.
getLogEvents
().
get
(
0
).
getMessage
()).
startsWith
(
MESSAGE
);
}
@Test
@Test
void
shouldReturnResponse
()
{
void
shouldReturnResponse
()
{
var
response
=
service
.
handleSendMail
(
COMMAND_ID
,
mail
);
var
response
=
service
.
handleSendMail
(
COMMAND_ID
,
mail
);
...
@@ -674,6 +659,7 @@ class PostfachServiceTest {
...
@@ -674,6 +659,7 @@ class PostfachServiceTest {
@Nested
@Nested
class
TestLogSendMailFailed
{
class
TestLogSendMailFailed
{
@DisplayName
(
"should log warning on OsiPostfachServerProcessException"
)
@Test
@Test
void
shouldLogWarningWhenOsiException
()
{
void
shouldLogWarningWhenOsiException
()
{
try
(
var
logCaptor
=
LogCaptor
.
forClass
(
PostfachService
.
class
))
{
try
(
var
logCaptor
=
LogCaptor
.
forClass
(
PostfachService
.
class
))
{
...
@@ -685,6 +671,7 @@ class PostfachServiceTest {
...
@@ -685,6 +671,7 @@ class PostfachServiceTest {
}
}
}
}
@DisplayName
(
"should log warning when error code is unknown postfach id"
)
@Test
@Test
void
shouldLogWarningWhenWrongPostfachId
()
{
void
shouldLogWarningWhenWrongPostfachId
()
{
try
(
var
logCaptor
=
LogCaptor
.
forClass
(
PostfachService
.
class
))
{
try
(
var
logCaptor
=
LogCaptor
.
forClass
(
PostfachService
.
class
))
{
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment