diff --git a/nachrichten-manager-server/src/test/java/de/ozgcloud/nachrichten/postfach/PostfachServiceTest.java b/nachrichten-manager-server/src/test/java/de/ozgcloud/nachrichten/postfach/PostfachServiceTest.java index 814643a4b90850b46274407b26712f77f0615365..7a88f0f81a573698705430c9587144ef4180751d 100644 --- a/nachrichten-manager-server/src/test/java/de/ozgcloud/nachrichten/postfach/PostfachServiceTest.java +++ b/nachrichten-manager-server/src/test/java/de/ozgcloud/nachrichten/postfach/PostfachServiceTest.java @@ -610,13 +610,9 @@ class PostfachServiceTest { @Test void shouldCallLogSendMailFailed() { - // var logCaptor = LogCaptor.forClass(PostfachService.class); - service.handleSendMail(COMMAND_ID, mail); verify(service).logSendMailFailed(COMMAND_ID, POSTFACH_EXCEPTION); - // assertThat(logCaptor.getLogEvents().get(0).getLevel()).isEqualTo(LogLevel.ERROR.name()); - // assertThat(logCaptor.getLogEvents().get(0).getMessage()).startsWith(MESSAGE); } @Test @@ -624,7 +620,7 @@ class PostfachServiceTest { var response = service.handleSendMail(COMMAND_ID, mail); assertThat(response.isSentSuccessful()).isFalse(); - assertThat(response.getMessageCode()).isEqualTo(PostfachMessageCode.SEND_SUCCESSFUL_MESSAGE_CODE); + assertThat(response.getMessageCode()).isEqualTo(PostfachMessageCode.PROCESS_FAILED_MESSAGE_CODE); } } @@ -649,17 +645,6 @@ class PostfachServiceTest { assertThat(eventFailedCaptor.getValue().getErrorMessage()).startsWith(MESSAGE); } - @Test - void shouldLogWarning() { - var logCaptor = LogCaptor.forClass(PostfachService.class); - - service.handleSendMail(COMMAND_ID, mail); - - // verify(service).proceedwithWarnException(eq(COMMAND_ID), any(OsiPostfachServerProcessException.class)); - assertThat(logCaptor.getLogEvents().get(0).getLevel()).isEqualTo(LogLevel.WARN.name()); - assertThat(logCaptor.getLogEvents().get(0).getMessage()).startsWith(MESSAGE); - } - @Test void shouldReturnResponse() { var response = service.handleSendMail(COMMAND_ID, mail); @@ -674,6 +659,7 @@ class PostfachServiceTest { @Nested class TestLogSendMailFailed { + @DisplayName("should log warning on OsiPostfachServerProcessException") @Test void shouldLogWarningWhenOsiException() { try (var logCaptor = LogCaptor.forClass(PostfachService.class)) { @@ -685,6 +671,7 @@ class PostfachServiceTest { } } + @DisplayName("should log warning when error code is unknown postfach id") @Test void shouldLogWarningWhenWrongPostfachId() { try (var logCaptor = LogCaptor.forClass(PostfachService.class)) {