From 488663dfb7f4ae4345b2dcef772b1f53e124ffe0 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Mon, 16 Sep 2024 15:25:45 +0200
Subject: [PATCH] OZG-6640 [test] do clean up
---
.../postfach/PostfachServiceTest.java | 19 +++----------------
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/nachrichten-manager-server/src/test/java/de/ozgcloud/nachrichten/postfach/PostfachServiceTest.java b/nachrichten-manager-server/src/test/java/de/ozgcloud/nachrichten/postfach/PostfachServiceTest.java
index 814643a..7a88f0f 100644
--- a/nachrichten-manager-server/src/test/java/de/ozgcloud/nachrichten/postfach/PostfachServiceTest.java
+++ b/nachrichten-manager-server/src/test/java/de/ozgcloud/nachrichten/postfach/PostfachServiceTest.java
@@ -610,13 +610,9 @@ class PostfachServiceTest {
@Test
void shouldCallLogSendMailFailed() {
- // var logCaptor = LogCaptor.forClass(PostfachService.class);
-
service.handleSendMail(COMMAND_ID, mail);
verify(service).logSendMailFailed(COMMAND_ID, POSTFACH_EXCEPTION);
- // assertThat(logCaptor.getLogEvents().get(0).getLevel()).isEqualTo(LogLevel.ERROR.name());
- // assertThat(logCaptor.getLogEvents().get(0).getMessage()).startsWith(MESSAGE);
}
@Test
@@ -624,7 +620,7 @@ class PostfachServiceTest {
var response = service.handleSendMail(COMMAND_ID, mail);
assertThat(response.isSentSuccessful()).isFalse();
- assertThat(response.getMessageCode()).isEqualTo(PostfachMessageCode.SEND_SUCCESSFUL_MESSAGE_CODE);
+ assertThat(response.getMessageCode()).isEqualTo(PostfachMessageCode.PROCESS_FAILED_MESSAGE_CODE);
}
}
@@ -649,17 +645,6 @@ class PostfachServiceTest {
assertThat(eventFailedCaptor.getValue().getErrorMessage()).startsWith(MESSAGE);
}
- @Test
- void shouldLogWarning() {
- var logCaptor = LogCaptor.forClass(PostfachService.class);
-
- service.handleSendMail(COMMAND_ID, mail);
-
- // verify(service).proceedwithWarnException(eq(COMMAND_ID), any(OsiPostfachServerProcessException.class));
- assertThat(logCaptor.getLogEvents().get(0).getLevel()).isEqualTo(LogLevel.WARN.name());
- assertThat(logCaptor.getLogEvents().get(0).getMessage()).startsWith(MESSAGE);
- }
-
@Test
void shouldReturnResponse() {
var response = service.handleSendMail(COMMAND_ID, mail);
@@ -674,6 +659,7 @@ class PostfachServiceTest {
@Nested
class TestLogSendMailFailed {
+ @DisplayName("should log warning on OsiPostfachServerProcessException")
@Test
void shouldLogWarningWhenOsiException() {
try (var logCaptor = LogCaptor.forClass(PostfachService.class)) {
@@ -685,6 +671,7 @@ class PostfachServiceTest {
}
}
+ @DisplayName("should log warning when error code is unknown postfach id")
@Test
void shouldLogWarningWhenWrongPostfachId() {
try (var logCaptor = LogCaptor.forClass(PostfachService.class)) {
--
GitLab