Skip to content
Snippets Groups Projects
Commit 6f11b70f authored by Felix Reichenbach's avatar Felix Reichenbach
Browse files

OZG-7573 apply code review

parent 913f11af
No related branches found
No related tags found
1 merge request!11OZG-7573 allow multi file upload by not closing requestObserver on EOF
...@@ -152,7 +152,7 @@ public class GrpcFileUploadUtils { ...@@ -152,7 +152,7 @@ public class GrpcFileUploadUtils {
} }
long sendNextChunk() { void sendNextChunk() {
byte[] contentToSend = streamReader.getNextData(); byte[] contentToSend = streamReader.getNextData();
if (streamReader.getLastReadSize() > 0) { if (streamReader.getLastReadSize() > 0) {
...@@ -160,7 +160,6 @@ public class GrpcFileUploadUtils { ...@@ -160,7 +160,6 @@ public class GrpcFileUploadUtils {
} else { } else {
endTransfer(); endTransfer();
} }
return contentToSend.length;
} }
private void endTransfer() { private void endTransfer() {
......
...@@ -149,13 +149,6 @@ class GrpcFileUploadUtilsTest { ...@@ -149,13 +149,6 @@ class GrpcFileUploadUtilsTest {
verify(fileSender).sendChunk(chunkCaptor.capture(), eq(content.length)); verify(fileSender).sendChunk(chunkCaptor.capture(), eq(content.length));
assertThat(chunkCaptor.getValue()).contains(content); assertThat(chunkCaptor.getValue()).contains(content);
} }
@Test
void shouldReturnChunkSize() {
var cotnentLength = fileSender.sendNextChunk();
assertThat(cotnentLength).isEqualTo(GrpcFileUploadUtils.CHUNK_SIZE);
}
} }
@Nested @Nested
...@@ -175,7 +168,6 @@ class GrpcFileUploadUtilsTest { ...@@ -175,7 +168,6 @@ class GrpcFileUploadUtilsTest {
@Test @Test
void shouldCallOnCompleted() { void shouldCallOnCompleted() {
fileSender.sendNextChunk(); fileSender.sendNextChunk();
verify(requestObserver).onCompleted(); verify(requestObserver).onCompleted();
...@@ -211,7 +203,6 @@ class GrpcFileUploadUtilsTest { ...@@ -211,7 +203,6 @@ class GrpcFileUploadUtilsTest {
@Test @Test
void shouldNotCallOnCompleted() { void shouldNotCallOnCompleted() {
fileSender.sendNextChunk(); fileSender.sendNextChunk();
verify(requestObserver, never()).onCompleted(); verify(requestObserver, never()).onCompleted();
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment