From 6f11b70fcc5ae0f423c32de5836a7b77a8408372 Mon Sep 17 00:00:00 2001
From: Felix Reichenbach <felix.reichenbach@mgm-tp.com>
Date: Thu, 20 Mar 2025 13:53:49 +0100
Subject: [PATCH] OZG-7573 apply code review
---
.../ozgcloud/common/binaryfile/GrpcFileUploadUtils.java | 3 +--
.../common/binaryfile/GrpcFileUploadUtilsTest.java | 9 ---------
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/ozgcloud-common-lib/src/main/java/de/ozgcloud/common/binaryfile/GrpcFileUploadUtils.java b/ozgcloud-common-lib/src/main/java/de/ozgcloud/common/binaryfile/GrpcFileUploadUtils.java
index 783d965..1cbd50d 100644
--- a/ozgcloud-common-lib/src/main/java/de/ozgcloud/common/binaryfile/GrpcFileUploadUtils.java
+++ b/ozgcloud-common-lib/src/main/java/de/ozgcloud/common/binaryfile/GrpcFileUploadUtils.java
@@ -152,7 +152,7 @@ public class GrpcFileUploadUtils {
}
- long sendNextChunk() {
+ void sendNextChunk() {
byte[] contentToSend = streamReader.getNextData();
if (streamReader.getLastReadSize() > 0) {
@@ -160,7 +160,6 @@ public class GrpcFileUploadUtils {
} else {
endTransfer();
}
- return contentToSend.length;
}
private void endTransfer() {
diff --git a/ozgcloud-common-lib/src/test/java/de/ozgcloud/common/binaryfile/GrpcFileUploadUtilsTest.java b/ozgcloud-common-lib/src/test/java/de/ozgcloud/common/binaryfile/GrpcFileUploadUtilsTest.java
index 6a01183..fb77f3c 100644
--- a/ozgcloud-common-lib/src/test/java/de/ozgcloud/common/binaryfile/GrpcFileUploadUtilsTest.java
+++ b/ozgcloud-common-lib/src/test/java/de/ozgcloud/common/binaryfile/GrpcFileUploadUtilsTest.java
@@ -149,13 +149,6 @@ class GrpcFileUploadUtilsTest {
verify(fileSender).sendChunk(chunkCaptor.capture(), eq(content.length));
assertThat(chunkCaptor.getValue()).contains(content);
}
-
- @Test
- void shouldReturnChunkSize() {
- var cotnentLength = fileSender.sendNextChunk();
-
- assertThat(cotnentLength).isEqualTo(GrpcFileUploadUtils.CHUNK_SIZE);
- }
}
@Nested
@@ -175,7 +168,6 @@ class GrpcFileUploadUtilsTest {
@Test
void shouldCallOnCompleted() {
-
fileSender.sendNextChunk();
verify(requestObserver).onCompleted();
@@ -211,7 +203,6 @@ class GrpcFileUploadUtilsTest {
@Test
void shouldNotCallOnCompleted() {
-
fileSender.sendNextChunk();
verify(requestObserver, never()).onCompleted();
--
GitLab