OZG-4391 OZG-4417 improve test structure

alfa-service/src/test/java/de/ozgcloud/alfa/vorgang/VorgangWithEingangProzessorTest.java

@@ -307,70 +307,65 @@ class VorgangWithEingangProzessorTest {
 		}
 
 		@Nested
-		class TestOnVorgangDataNotComplete {
-
-			@Test
-			void shouldReturnFalseIfEingangNull() {
-				var hasEnabled = callProcessor(VorgangWithEingangTestFactory.createBuilder().eingang(null).build());
+		class TestOnBescheidPropertiesSet {
 
-				assertThat(hasEnabled).isFalse();
+			@BeforeEach
+			void setUp() {
+				when(vorgangProperties.getBescheid()).thenReturn(List.of(VorgangPropertyTestFactory.create()));
 			}
 
 			@Test
-			void shouldReturnFalseIfEingangHeaderNull() {
+			void shouldReturnFalseIfFormEngineNameNotEquals() {
 				var hasEnabled = callProcessor(
-						VorgangWithEingangTestFactory.createBuilder().eingang(EingangTestFactory.createBuilder().header(null).build()).build());
+						VorgangWithEingangTestFactory.createBuilder().eingang(
+								EingangTestFactory.createBuilder()
+										.header(EingangHeaderTestFactory.createBuilder().formEngineName("different").build())
+										.build()).build());
 
 				assertThat(hasEnabled).isFalse();
 			}
 
 			@Test
-			void shouldReturnFalseIfFormEngineNameNull() {
-				var hasEnabled = callProcessor(
-						VorgangWithEingangTestFactory.createBuilder().eingang(
-								EingangTestFactory.createBuilder().header(EingangHeaderTestFactory.createBuilder().formEngineName(null).build())
-										.build()).build());
+			void shouldReturnTrue() {
+				var hasEnabled = callProcessor(VorgangWithEingangTestFactory.create());
 
-				assertThat(hasEnabled).isFalse();
+				assertThat(hasEnabled).isTrue();
+			}
 		}
 
 		@Test
-			void shouldReturnFalseIfFormIdNull() {
-				var hasEnabled = callProcessor(
-						VorgangWithEingangTestFactory.createBuilder().eingang(
-								EingangTestFactory.createBuilder().header(EingangHeaderTestFactory.createBuilder().formId(null).build())
-										.build()).build());
+		void shouldReturnFalseOnEmptyEingang() {
+			var hasEnabled = callProcessor(VorgangWithEingangTestFactory.createBuilder().eingang(null).build());
 
 			assertThat(hasEnabled).isFalse();
 		}
 
-		}
-
-		@Nested
-		class TestOnBescheidPropertiesSet {
+		@Test
+		void shouldReturnFalseOnEmptyEingangHeader() {
+			var hasEnabled = callProcessor(
+					VorgangWithEingangTestFactory.createBuilder().eingang(EingangTestFactory.createBuilder().header(null).build()).build());
 
-			@BeforeEach
-			void setUp() {
-				when(vorgangProperties.getBescheid()).thenReturn(List.of(VorgangPropertyTestFactory.create()));
+			assertThat(hasEnabled).isFalse();
 		}
 
 		@Test
-			void shouldReturnFalseIfFormEngineNameNotEquals() {
+		void shouldReturnFalseOnEmptyFormEngineName() {
 			var hasEnabled = callProcessor(
 					VorgangWithEingangTestFactory.createBuilder().eingang(
-								EingangTestFactory.createBuilder()
-										.header(EingangHeaderTestFactory.createBuilder().formEngineName("different").build())
+							EingangTestFactory.createBuilder().header(EingangHeaderTestFactory.createBuilder().formEngineName(null).build())
 									.build()).build());
 
 			assertThat(hasEnabled).isFalse();
 		}
 
 		@Test
-			void shouldReturnTrue() {
-				var hasEnabled = callProcessor(VorgangWithEingangTestFactory.create());
+		void shouldReturnFalseOnEmptyFormId() {
+			var hasEnabled = callProcessor(
+					VorgangWithEingangTestFactory.createBuilder().eingang(
+							EingangTestFactory.createBuilder().header(EingangHeaderTestFactory.createBuilder().formId(null).build())
+									.build()).build());
 
-				assertThat(hasEnabled).isTrue();
-			}
+			assertThat(hasEnabled).isFalse();
 		}
 
 		boolean callProcessor(VorgangWithEingang vorgang) {