From 7000963acb800158f78dd42bda02b49732947a42 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Tue, 17 Oct 2023 08:17:02 +0200
Subject: [PATCH] OZG-4391 OZG-4417 improve test structure
---
.../VorgangWithEingangProzessorTest.java | 75 +++++++++----------
1 file changed, 35 insertions(+), 40 deletions(-)
diff --git a/alfa-service/src/test/java/de/ozgcloud/alfa/vorgang/VorgangWithEingangProzessorTest.java b/alfa-service/src/test/java/de/ozgcloud/alfa/vorgang/VorgangWithEingangProzessorTest.java
index 1637922746..6014543c55 100644
--- a/alfa-service/src/test/java/de/ozgcloud/alfa/vorgang/VorgangWithEingangProzessorTest.java
+++ b/alfa-service/src/test/java/de/ozgcloud/alfa/vorgang/VorgangWithEingangProzessorTest.java
@@ -306,46 +306,6 @@ class VorgangWithEingangProzessorTest {
}
- @Nested
- class TestOnVorgangDataNotComplete {
-
- @Test
- void shouldReturnFalseIfEingangNull() {
- var hasEnabled = callProcessor(VorgangWithEingangTestFactory.createBuilder().eingang(null).build());
-
- assertThat(hasEnabled).isFalse();
- }
-
- @Test
- void shouldReturnFalseIfEingangHeaderNull() {
- var hasEnabled = callProcessor(
- VorgangWithEingangTestFactory.createBuilder().eingang(EingangTestFactory.createBuilder().header(null).build()).build());
-
- assertThat(hasEnabled).isFalse();
- }
-
- @Test
- void shouldReturnFalseIfFormEngineNameNull() {
- var hasEnabled = callProcessor(
- VorgangWithEingangTestFactory.createBuilder().eingang(
- EingangTestFactory.createBuilder().header(EingangHeaderTestFactory.createBuilder().formEngineName(null).build())
- .build()).build());
-
- assertThat(hasEnabled).isFalse();
- }
-
- @Test
- void shouldReturnFalseIfFormIdNull() {
- var hasEnabled = callProcessor(
- VorgangWithEingangTestFactory.createBuilder().eingang(
- EingangTestFactory.createBuilder().header(EingangHeaderTestFactory.createBuilder().formId(null).build())
- .build()).build());
-
- assertThat(hasEnabled).isFalse();
- }
-
- }
-
@Nested
class TestOnBescheidPropertiesSet {
@@ -373,6 +333,41 @@ class VorgangWithEingangProzessorTest {
}
}
+ @Test
+ void shouldReturnFalseOnEmptyEingang() {
+ var hasEnabled = callProcessor(VorgangWithEingangTestFactory.createBuilder().eingang(null).build());
+
+ assertThat(hasEnabled).isFalse();
+ }
+
+ @Test
+ void shouldReturnFalseOnEmptyEingangHeader() {
+ var hasEnabled = callProcessor(
+ VorgangWithEingangTestFactory.createBuilder().eingang(EingangTestFactory.createBuilder().header(null).build()).build());
+
+ assertThat(hasEnabled).isFalse();
+ }
+
+ @Test
+ void shouldReturnFalseOnEmptyFormEngineName() {
+ var hasEnabled = callProcessor(
+ VorgangWithEingangTestFactory.createBuilder().eingang(
+ EingangTestFactory.createBuilder().header(EingangHeaderTestFactory.createBuilder().formEngineName(null).build())
+ .build()).build());
+
+ assertThat(hasEnabled).isFalse();
+ }
+
+ @Test
+ void shouldReturnFalseOnEmptyFormId() {
+ var hasEnabled = callProcessor(
+ VorgangWithEingangTestFactory.createBuilder().eingang(
+ EingangTestFactory.createBuilder().header(EingangHeaderTestFactory.createBuilder().formId(null).build())
+ .build()).build());
+
+ assertThat(hasEnabled).isFalse();
+ }
+
boolean callProcessor(VorgangWithEingang vorgang) {
return processor.hasVorgangCreateBescheidEnabled(vorgang);
}
--
GitLab