Skip to content
Snippets Groups Projects
Commit 707bffe6 authored by OZGCloud's avatar OZGCloud
Browse files

OZG-7131 implement comments from code review

parent 97ab486b
Branches
Tags
No related merge requests found
package de.ozgcloud.collaboration; package de.ozgcloud.collaboration;
import jakarta.validation.constraints.NotEmpty;
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty; import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
import org.springframework.boot.context.properties.ConfigurationProperties; import org.springframework.boot.context.properties.ConfigurationProperties;
import org.springframework.context.annotation.Configuration; import org.springframework.context.annotation.Configuration;
import org.springframework.validation.annotation.Validated;
import lombok.Getter; import lombok.Getter;
import lombok.Setter; import lombok.Setter;
...@@ -15,11 +12,9 @@ import lombok.Setter; ...@@ -15,11 +12,9 @@ import lombok.Setter;
@ConditionalOnProperty(prefix = FachstelleProperties.PREFIX, name = { "host" }) @ConditionalOnProperty(prefix = FachstelleProperties.PREFIX, name = { "host" })
@Getter @Getter
@Setter @Setter
@Validated
class FachstelleProperties { class FachstelleProperties {
static final String PREFIX = "ozgcloud.fachstelle"; static final String PREFIX = "ozgcloud.fachstelle";
@NotEmpty
private String host; private String host;
} }
...@@ -46,6 +46,10 @@ class FachstelleVorgangUrlProviderTest { ...@@ -46,6 +46,10 @@ class FachstelleVorgangUrlProviderTest {
assertThat(provider).extracting("vorgangUrlPrefix").isEqualTo(vorgagUrlPrefix); assertThat(provider).extracting("vorgangUrlPrefix").isEqualTo(vorgagUrlPrefix);
} }
private FachstelleVorgangUrlProvider createProvider() {
return spy(new FachstelleVorgangUrlProvider(fachstelleProperties, vorgangManagerProperties));
}
} }
@Nested @Nested
...@@ -110,7 +114,4 @@ class FachstelleVorgangUrlProviderTest { ...@@ -110,7 +114,4 @@ class FachstelleVorgangUrlProviderTest {
} }
} }
private FachstelleVorgangUrlProvider createProvider() {
return spy(new FachstelleVorgangUrlProvider(fachstelleProperties, vorgangManagerProperties));
}
} }
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment