From 707bffe647533da4ee0ea45e1cc0a3aa95bc96e8 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Mon, 9 Dec 2024 09:49:51 +0100
Subject: [PATCH] OZG-7131 implement comments from code review
---
.../de/ozgcloud/collaboration/FachstelleProperties.java | 5 -----
.../collaboration/FachstelleVorgangUrlProviderTest.java | 7 ++++---
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/collaboration-manager-server/src/main/java/de/ozgcloud/collaboration/FachstelleProperties.java b/collaboration-manager-server/src/main/java/de/ozgcloud/collaboration/FachstelleProperties.java
index 7aa6e3a..f2c4127 100644
--- a/collaboration-manager-server/src/main/java/de/ozgcloud/collaboration/FachstelleProperties.java
+++ b/collaboration-manager-server/src/main/java/de/ozgcloud/collaboration/FachstelleProperties.java
@@ -1,11 +1,8 @@
package de.ozgcloud.collaboration;
-import jakarta.validation.constraints.NotEmpty;
-
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
import org.springframework.boot.context.properties.ConfigurationProperties;
import org.springframework.context.annotation.Configuration;
-import org.springframework.validation.annotation.Validated;
import lombok.Getter;
import lombok.Setter;
@@ -15,11 +12,9 @@ import lombok.Setter;
@ConditionalOnProperty(prefix = FachstelleProperties.PREFIX, name = { "host" })
@Getter
@Setter
-@Validated
class FachstelleProperties {
static final String PREFIX = "ozgcloud.fachstelle";
- @NotEmpty
private String host;
}
diff --git a/collaboration-manager-server/src/test/java/de/ozgcloud/collaboration/FachstelleVorgangUrlProviderTest.java b/collaboration-manager-server/src/test/java/de/ozgcloud/collaboration/FachstelleVorgangUrlProviderTest.java
index a23474f..99537c0 100644
--- a/collaboration-manager-server/src/test/java/de/ozgcloud/collaboration/FachstelleVorgangUrlProviderTest.java
+++ b/collaboration-manager-server/src/test/java/de/ozgcloud/collaboration/FachstelleVorgangUrlProviderTest.java
@@ -46,6 +46,10 @@ class FachstelleVorgangUrlProviderTest {
assertThat(provider).extracting("vorgangUrlPrefix").isEqualTo(vorgagUrlPrefix);
}
+
+ private FachstelleVorgangUrlProvider createProvider() {
+ return spy(new FachstelleVorgangUrlProvider(fachstelleProperties, vorgangManagerProperties));
+ }
}
@Nested
@@ -110,7 +114,4 @@ class FachstelleVorgangUrlProviderTest {
}
}
- private FachstelleVorgangUrlProvider createProvider() {
- return spy(new FachstelleVorgangUrlProvider(fachstelleProperties, vorgangManagerProperties));
- }
}
--
GitLab