OZG-5009 encapsulate state and add missing test

alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-bescheiden/bescheiden.formservice.ts

 import { Bescheid, BescheidService } from '@alfa-client/bescheid-shared';
 import {
   AbstractFormService,
-  StateResource,
   asBoolean,
   formatForDatabase,
+  StateResource,
 } from '@alfa-client/tech-shared';
 import { VorgangWithEingangResource } from '@alfa-client/vorgang-shared';
 import { Injectable } from '@angular/core';
 import { UntypedFormBuilder, UntypedFormControl, UntypedFormGroup } from '@angular/forms';
 import { isNil } from 'lodash-es';
-import { BehaviorSubject, Observable, map, startWith } from 'rxjs';
+import { BehaviorSubject, map, Observable, startWith } from 'rxjs';
 
 @Injectable()
 export class BescheidenFormService extends AbstractFormService {
@@ -19,7 +19,7 @@ export class BescheidenFormService extends AbstractFormService {
 
   public readonly bescheidChanges$: BehaviorSubject<Bescheid>;
 
-  public vorgang: VorgangWithEingangResource;
+  private vorgangWithEingangResource: VorgangWithEingangResource;
 
   constructor(
     formBuilder: UntypedFormBuilder,
@@ -65,7 +65,10 @@ export class BescheidenFormService extends AbstractFormService {
   }
 
   protected doSubmit(): Observable<StateResource<any>> {
-    return this.bescheidService.createBescheidDraft(this.vorgang, this.getValue());
+    return this.bescheidService.createBescheidDraft(
+      this.vorgangWithEingangResource,
+      this.getValue(),
+    );
   }
 
   public getValue(): Bescheid {
@@ -79,4 +82,10 @@ export class BescheidenFormService extends AbstractFormService {
   public getBescheidChanges(): Observable<Bescheid> {
     return this.bescheidChanges$.asObservable();
   }
+
+  public setVorgangWithEingangResource(
+    vorgangWithEingangResource: VorgangWithEingangResource,
+  ): void {
+    this.vorgangWithEingangResource = vorgangWithEingangResource;
+  }
 }

alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-bescheiden/vorgang-detail-bescheiden.component.spec.ts

@@ -75,12 +75,20 @@ describe('VorgangDetailBescheidenComponent', () => {
   });
 
   describe('ngOnInit', () => {
+    it('should set vorgang on form service', () => {
+      const setVorgangWithEingangResource = (formService.setVorgangWithEingangResource = jest.fn());
+
+      component.ngOnInit();
+
+      expect(setVorgangWithEingangResource).toBeCalledWith(vorgangWithEingangResource);
+    });
+
     it('should patch values', () => {
-      const mock = (formService.patchValues = jest.fn());
+      const patchValues = (formService.patchValues = jest.fn());
 
       component.ngOnInit();
 
-      expect(mock).toBeCalledWith(bescheidDraftResource);
+      expect(patchValues).toBeCalledWith(bescheidDraftResource);
     });
   });
 

alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-bescheiden/vorgang-detail-bescheiden.component.ts

@@ -24,7 +24,9 @@ export class VorgangDetailBescheidenComponent implements OnInit {
   }
 
   ngOnInit(): void {
-    this.formService.vorgang = this.dialogRef.config.data.vorgangWithEingangResource;
+    this.formService.setVorgangWithEingangResource(
+      this.dialogRef.config.data.vorgangWithEingangResource,
+    );
     this.formService.patchValues(this.bescheidDraftResource);
   }