Skip to content
Snippets Groups Projects
Commit ad6d51cc authored by OZGCloud's avatar OZGCloud
Browse files

OZG-5009 remove unnecessary null check

parent 31720cad
Branches develop
Tags
No related merge requests found
......@@ -8,15 +8,8 @@ import org.mapstruct.ReportingPolicy;
import de.ozgcloud.bescheid.GrpcBescheid;
@Mapper(unmappedTargetPolicy = ReportingPolicy.ERROR, nullValueCheckStrategy = NullValueCheckStrategy.ALWAYS)
abstract class BescheidMapper {
public Bescheid fromGrpc(GrpcBescheid grpcBescheid, String vorgangId) {
if (grpcBescheid == null) {
return null;
}
return map(grpcBescheid, vorgangId);
}
interface BescheidMapper {
@Mapping(target = "vorgangId", source = "vorgangId")
protected abstract Bescheid map(GrpcBescheid grpcBescheid, String vorgangId);
Bescheid fromGrpc(GrpcBescheid grpcBescheid, String vorgangId);
}
......@@ -36,13 +36,6 @@ class BescheidMapperTest {
assertThat(bescheid.getBeschiedenAm()).isEqualTo(GrpcBescheidTestFactory.BESCHIEDEN_AM);
}
@Test
void shouldReturnNullOnNullGrpcBescheid() {
var bescheid = mapper.fromGrpc(null, VorgangHeaderTestFactory.ID);
assertThat(bescheid).isNull();
}
private Bescheid map() {
return mapper.fromGrpc(GrpcBescheidTestFactory.create(), VorgangHeaderTestFactory.ID);
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment