Skip to content
Snippets Groups Projects
Commit e4bc8640 authored by OZGCloud's avatar OZGCloud
Browse files

OZG-6177 add junittests remoteservice reconciler classes

parent 8cfb111f
Branches
Tags
No related merge requests found
package de.ozgcloud.operator.elstertransfer.user; package de.ozgcloud.operator.elstertransfer.user;
import static org.assertj.core.api.Assertions.*; import static org.assertj.core.api.Assertions.*;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.ArgumentMatchers.*; import static org.mockito.ArgumentMatchers.*;
import static org.mockito.Mockito.*; import static org.mockito.Mockito.*;
...@@ -28,8 +29,8 @@ class OzgCloudElsterTransferUserReconcilerTest { ...@@ -28,8 +29,8 @@ class OzgCloudElsterTransferUserReconcilerTest {
@Mock @Mock
private OzgCloudElsterTransferUserService service; private OzgCloudElsterTransferUserService service;
@Mock //@Mock
private MixedOperation<OzgCloudElsterTransferUser, KubernetesResourceList<OzgCloudElsterTransferUser>, Resource<OzgCloudElsterTransferUser>> mixedOperation; //private MixedOperation<OzgCloudElsterTransferUser, KubernetesResourceList<OzgCloudElsterTransferUser>, Resource<OzgCloudElsterTransferUser>> mixedOperation;
@Mock @Mock
private KubernetesClient client; private KubernetesClient client;
...@@ -37,53 +38,29 @@ class OzgCloudElsterTransferUserReconcilerTest { ...@@ -37,53 +38,29 @@ class OzgCloudElsterTransferUserReconcilerTest {
@DisplayName("Reconcile") @DisplayName("Reconcile")
@Nested @Nested
class TestReconcile { class TestReconcile {
OzgCloudElsterTransferUser user = OzgCloudElsterTransferUserTestFactory.create();
@Test @Test
void shouldCallUpdateConfigMap() { void shouldCallUpdateConfigMap() {
OzgCloudElsterTransferUser user = OzgCloudElsterTransferUserTestFactory.create();
reconciler.reconcile(user, null); reconciler.reconcile(user, null);
verify(service).updateConfigMapAndRestartDeploymentAndCreateSecret(OzgCloudElsterTransferUserTestFactory.METADATA_NAMESPACE); verify(service).updateConfigMapAndRestartDeploymentAndCreateSecret(OzgCloudElsterTransferUserTestFactory.METADATA_NAMESPACE);
} }
/* @Test
void shouldCallRestartDeployment() {
OzgCloudElsterTransferUser user = OzgCloudElsterTransferUserTestFactory.create();
reconciler.reconcile(user, null);
verify(service).restartDeployment(OzgCloudElsterTransferUserTestFactory.ETR_NAMESPACE,
OzgCloudElsterTransferUserTestFactory.DEPLOYMENT_NAME);
}
@Test @Test
void shouldCallCreateOrUpdateSecret() { void shouldReturnUpdateStatus() {
OzgCloudElsterTransferUser user = OzgCloudElsterTransferUserTestFactory.create(); var response = reconciler.reconcile(OzgCloudElsterTransferUserTestFactory.create(), null);
reconciler.reconcile(user, null);
verify(service).createOrUpdateSecret(OzgCloudElsterTransferUserTestFactory.METADATA_NAMESPACE);
assertThat(response.getResource()).isNotNull();
} }
@Test @Test
void shouldCallGetElsterTransferUserStatus() { void shouldCallGetElsterTransferUserStatus() {
OzgCloudElsterTransferUser user = OzgCloudElsterTransferUserTestFactory.create();
reconciler.reconcile(user, null); reconciler.reconcile(user, null);
verify(reconciler).getElsterTransferUserStatus(any(), any()); verify(reconciler).getElsterTransferUserStatus(any(), any());
} }
@Test
void shouldReturnUpdateStatus() {
var response = reconciler.reconcile(OzgCloudElsterTransferUserTestFactory.create(), null);
assertThat(response.getResource()).isNotNull();
}
@Test @Test
void shouldSetStatusOk() { void shouldSetStatusOk() {
...@@ -91,119 +68,47 @@ class OzgCloudElsterTransferUserReconcilerTest { ...@@ -91,119 +68,47 @@ class OzgCloudElsterTransferUserReconcilerTest {
assertThat(response.getResource().getStatus().getStatus()).isEqualTo(OzgCloudCustomResourceStatus.OK); assertThat(response.getResource().getStatus().getStatus()).isEqualTo(OzgCloudCustomResourceStatus.OK);
} }
@DisplayName("test getElsterTransferUserStatus")
}
@DisplayName("Reconciler Cleanup")
@Nested @Nested
class TestReconcilerCleanup { class TestGetElsterTransferUserStatus {
@DisplayName("with keep_after_delete")
@Nested
class TestWithKeepAfterDelete {
private final OzgCloudElsterTransferUserSpec userSpec = OzgCloudElsterTransferUserSpecTestFactory.createBuilder().keepAfterDelete(true) void shouldRetrunOzgCloudElsterTransferUserStatus(){
.build();
private final OzgCloudElsterTransferUser user = OzgCloudElsterTransferUserTestFactory.create(userSpec);
@Test OzgCloudElsterTransferUserStatus result = reconciler.getElsterTransferUserStatus(OzgCloudCustomResourceStatus.OK, "Status: OK");
void shouldNotCallService() {
reconciler.cleanup(user, null);
verify(service, never()).deleteUser(anyString(), anyString()); assertEquals(OzgCloudCustomResourceStatus.OK, result.getStatus());
assertEquals("Status: OK", result.getMessage());
} }
@Test
void shouldReturnDeleteControl() {
var control = reconciler.cleanup(user, null);
assertThat(control).usingRecursiveComparison().isEqualTo(DeleteControl.defaultDelete());
}
}
@DisplayName("test cleanup")
@Nested
class TestCleanup {
private final OzgCloudElsterTransferUser user = OzgCloudElsterTransferUserTestFactory.create();
@Test
void shouldDeleteUserIfUserExists() {
when(service.userExists(anyString(), anyString(), anyString())).thenReturn(true);
reconciler.cleanup(user, null);
verify(reconciler).deleteUser(OzgCloudElsterTransferUserTestFactory.METADATA_NAMESPACE);
} }
@Test @Test
void shouldReturnValueFromDeleteUser() { void shouldReturnErrorStatus() {
DeleteControl expected = DeleteControl.defaultDelete();
when(reconciler.deleteUser(anyString())).thenReturn(expected);
when(service.userExists(anyString(), anyString(), anyString())).thenReturn(true);
DeleteControl response = reconciler.cleanup(user, null); OzgCloudElsterTransferUserStatus result = reconciler.getElsterTransferUserStatus(OzgCloudCustomResourceStatus.ERROR, "An error occurred");
assertThat(response).isEqualTo(expected); assertEquals(OzgCloudCustomResourceStatus.ERROR, result.getStatus());
assertEquals("An error occurred", result.getMessage());
} }
@Test
void shouldCallUserExists() {
reconciler.cleanup(user, null);
verify(service).userExists(OzgCloudElsterTransferUserTestFactory.METADATA_NAMESPACE, OzgCloudElsterTransferUserTestFactory.ETR_NAMESPACE,
OzgCloudElsterTransferUserTestFactory.CONFIG_MAP_NAME);
}
@Test
void shouldNotDeleteUserIfUserNotExists() {
when(service.userExists(anyString(), anyString(), anyString())).thenReturn(false);
reconciler.cleanup(user, null);
verify(reconciler, never()).deleteUser(OzgCloudElsterTransferUserTestFactory.METADATA_NAMESPACE);
} }
@Test @DisplayName("Reconciler Cleanup")
void shouldReturnDeleteControlIfUserNotExists() {
when(service.userExists(anyString(), anyString(), anyString())).thenReturn(false);
var control = reconciler.cleanup(user, null);
assertThat(control).usingRecursiveComparison().isEqualTo(DeleteControl.defaultDelete());
}
@Test
void shouldCallCreateOrUpdateSecret() {
when(service.userExists(anyString(), anyString(), anyString())).thenReturn(true);
reconciler.cleanup(user, null);
verify(service).createOrUpdateSecret(OzgCloudElsterTransferUserTestFactory.METADATA_NAMESPACE,anyString(),OzgCloudElsterTransferUserTestFactory.MUK_USER_SECRET_NAME);
}
}
@DisplayName("test delete")
@Nested @Nested
class TestDelete { class TestReconcilerCleanup {
private final OzgCloudElsterTransferUser user = OzgCloudElsterTransferUserTestFactory.create(); private final OzgCloudElsterTransferUser user = OzgCloudElsterTransferUserTestFactory.create();
@Test @Test
void shouldCallServiceDelete() { void shouldCallServiceDelete() {
OzgCloudElsterTransferUserSpec userSpec = OzgCloudElsterTransferUserSpecTestFactory.create();
reconciler.deleteUser(OzgCloudElsterTransferUserTestFactory.METADATA_NAMESPACE); reconciler.cleanup(user, null);
verify(service).deleteUser(OzgCloudElsterTransferUserTestFactory.METADATA_NAMESPACE, verify(service).deleteUserAndRestartDeploymentIfNotKeepUserAndUserExists(user);
OzgCloudElsterTransferUserTestFactory.CONFIG_MAP_NAME);
} }
@Test @Test
void shouldReturnDeleteControl() { void shouldReturnDeleteControlIfErrorNotThrow() {
var control = reconciler.deleteUser(anyString()); var control = reconciler.cleanup(user, null);
assertThat(control).usingRecursiveComparison().isEqualTo(DeleteControl.defaultDelete()); assertThat(control).usingRecursiveComparison().isEqualTo(DeleteControl.defaultDelete());
} }
...@@ -211,15 +116,15 @@ class OzgCloudElsterTransferUserReconcilerTest { ...@@ -211,15 +116,15 @@ class OzgCloudElsterTransferUserReconcilerTest {
@Test @Test
void shouldRescheduleOnError() { void shouldRescheduleOnError() {
doThrow(RuntimeException.class).when(service) doThrow(RuntimeException.class).when(service)
.deleteUser(anyString(), anyString()); .deleteUserAndRestartDeploymentIfNotKeepUserAndUserExists(user);
var control = reconciler.deleteUser(OzgCloudElsterTransferUserTestFactory.METADATA_NAMESPACE); var control = reconciler.cleanup(user, null);
assertThat(control).usingRecursiveComparison() assertThat(control).usingRecursiveComparison()
.isEqualTo(DeleteControl.noFinalizerRemoval().rescheduleAfter(Config.RECONCILER_RETRY_SECONDS_ON_ERROR)); .isEqualTo(DeleteControl.noFinalizerRemoval().rescheduleAfter(Config.RECONCILER_RETRY_SECONDS_ON_ERROR));
} }
}*/
} }
} }
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment