Merge pull request 'OZG-6821 remove unnessasary realmExists check' (#34) from OZG-6821 into master

ozgcloud-keycloak-operator/src/main/java/de/ozgcloud/operator/keycloak/KeycloakGenericRemoteService.java

@@ -40,7 +40,6 @@ public class KeycloakGenericRemoteService {
 		} else {
 			return Optional.empty();
 		}
-
 	}
 
 	public Optional<RoleRepresentation> getClientRole(String roleName, String realClientId, String realm) {

ozgcloud-keycloak-operator/src/main/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmService.java

@@ -69,12 +69,10 @@ class KeycloakRealmService {
 	}
 
 	void createRealm(OzgCloudKeycloakRealmSpec realm, String realmName) {
+		LOG.debug("{}: Creating new realm...", realmName);
 		Optional.of(realm)
 				.map(mapper::map)
 				.map(realmRepresentation -> addRealmName(realmRepresentation, realmName))
-				// TODO dieser Filter kann vermutlich gelöscht werden, die Prüfung auf
-				// realmExists passiert bereits vorher
-				.filter(realmRepresentation -> !keycloakGenericRemoteService.realmExists(realmName))
 				.ifPresent(realmRepresentation -> {
 					remoteService.createRealm(realmRepresentation);
 					addUserProfileAttributes(realmRepresentation);

ozgcloud-keycloak-operator/src/test/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmServiceTest.java

@@ -189,36 +189,15 @@ class KeycloakRealmServiceTest {
 			verify(mapper).map(REALM);
 		}
 
-		@Test
-		void shouldCallRealmExists() {
-			service.createRealm(REALM, REALM_NAME);
-
-			verify(keycloakGenericRemoteService).realmExists(REALM_NAME);
-		}
-
 		@Test
 		void shouldCallCreateRealmIfNotExists() {
-			when(keycloakGenericRemoteService.realmExists(REALM_NAME)).thenReturn(false);
-
 			service.createRealm(REALM, REALM_NAME);
 
 			verify(remoteService).createRealm(realmRepresentation);
 		}
 
-		@Test
-		void shouldNOTCallCreateRealmIfAlreadyExists() {
-			reset(remoteService);
-			when(keycloakGenericRemoteService.realmExists(REALM_NAME)).thenReturn(true);
-
-			service.createRealm(REALM, REALM_NAME);
-
-			verify(remoteService, never()).createRealm(any());
-		}
-
 		@Test
 		void shouldCallAddRealmName() {
-			when(keycloakGenericRemoteService.realmExists(REALM_NAME)).thenReturn(false);
-
 			service.createRealm(REALM, REALM_NAME);
 
 			verify(service).addRealmName(realmRepresentation, REALM_NAME);