Skip to content
Snippets Groups Projects
Commit 59c883d3 authored by OZGCloud's avatar OZGCloud
Browse files

prj-42 fix after run test

parent d2070dfb
No related branches found
No related tags found
No related merge requests found
Showing
with 57 additions and 25 deletions
...@@ -8,7 +8,7 @@ import lombok.Builder; ...@@ -8,7 +8,7 @@ import lombok.Builder;
import lombok.Getter; import lombok.Getter;
import lombok.With; import lombok.With;
@Builder @Builder(toBuilder = true)
@Getter @Getter
public class Bescheid { public class Bescheid {
...@@ -21,7 +21,6 @@ public class Bescheid { ...@@ -21,7 +21,6 @@ public class Bescheid {
private File bescheidFile; private File bescheidFile;
@With @With
private FileId bescheidFileId; private FileId bescheidFileId;
private String contentType; private String contentType;
private long size; private long size;
......
package de.ozgcloud.bescheid;
import de.itvsh.ozg.pluto.command.Command;
import de.itvsh.ozg.pluto.command.CommandExecutedEvent;
class BescheidCreatedEvent extends CommandExecutedEvent {
public BescheidCreatedEvent(Command command) {
super(command.getId());
}
}
...@@ -58,6 +58,7 @@ class BescheidEventListener { ...@@ -58,6 +58,7 @@ class BescheidEventListener {
try { try {
prevContext = userService.startSecurityContext(command); prevContext = userService.startSecurityContext(command);
doCreateBescheidBiz(command); doCreateBescheidBiz(command);
eventPublisher.publishEvent(new BescheidCreatedEvent(command));
} catch (Exception e) { } catch (Exception e) {
LOG.error("Error on executing Create Bescheid Command. Command failed.", e); LOG.error("Error on executing Create Bescheid Command. Command failed.", e);
eventPublisher.publishEvent(new CommandFailedEvent(command.getId(), buildErrorMessage(e))); eventPublisher.publishEvent(new CommandFailedEvent(command.getId(), buildErrorMessage(e)));
...@@ -79,7 +80,7 @@ class BescheidEventListener { ...@@ -79,7 +80,7 @@ class BescheidEventListener {
var eventBody = command.getBodyObject(); var eventBody = command.getBodyObject();
var builder = BescheidRequest.builder(); var builder = BescheidRequest.builder();
Optional.ofNullable(eventBody.get(VORGANG_ID_BODYKEY)).map(String.class::cast).map(VorgangId::from).ifPresent(builder::vorgangId); builder.vorgangId(VorgangId.from(command.getVorgangId()));
Optional.ofNullable(eventBody.get(BESCHEID_VOM_BODYKEY)).map(LocalDate.class::cast).ifPresent(builder::bescheidVom); Optional.ofNullable(eventBody.get(BESCHEID_VOM_BODYKEY)).map(LocalDate.class::cast).ifPresent(builder::bescheidVom);
Optional.ofNullable(eventBody.get(GENEHMIGT_BODYKEY)).map(Boolean.class::cast).ifPresent(builder::genehmigt); Optional.ofNullable(eventBody.get(GENEHMIGT_BODYKEY)).map(Boolean.class::cast).ifPresent(builder::genehmigt);
builder.createFor(UserId.from(command.getCreatedBy())); builder.createFor(UserId.from(command.getCreatedBy()));
......
...@@ -16,7 +16,9 @@ class BescheidService { ...@@ -16,7 +16,9 @@ class BescheidService {
public Bescheid createBescheid(BescheidRequest request) { public Bescheid createBescheid(BescheidRequest request) {
var vorgang = vorgangService.getById(request.getVorgangId()); var vorgang = vorgangService.getById(request.getVorgangId());
return remoteService.create(request, vorgang); var bescheid = remoteService.create(request, vorgang);
return bescheid.toBuilder().vorgangId(request.getVorgangId()).build();
} }
} }
...@@ -25,6 +25,7 @@ import de.itvsh.ozg.pluto.grpc.command.GrpcCallContext; ...@@ -25,6 +25,7 @@ import de.itvsh.ozg.pluto.grpc.command.GrpcCallContext;
import de.ozgcloud.bescheid.Bescheid; import de.ozgcloud.bescheid.Bescheid;
import io.grpc.stub.CallStreamObserver; import io.grpc.stub.CallStreamObserver;
import io.grpc.stub.StreamObserver; import io.grpc.stub.StreamObserver;
import lombok.NonNull;
import net.devh.boot.grpc.client.inject.GrpcClient; import net.devh.boot.grpc.client.inject.GrpcClient;
@Service @Service
...@@ -36,7 +37,7 @@ class BinaryFileRemoteService { ...@@ -36,7 +37,7 @@ class BinaryFileRemoteService {
@GrpcClient("vorgang-manager") @GrpcClient("vorgang-manager")
private BinaryFileServiceStub binaryFileRemoteStub; private BinaryFileServiceStub binaryFileRemoteStub;
FileId uploadBescheidFile(Bescheid bescheid) { FileId uploadBescheidFile(@NonNull Bescheid bescheid) {
try (var in = openFile(bescheid.getBescheidFile())) { try (var in = openFile(bescheid.getBescheidFile())) {
var resultFuture = GrpcFileUploadUtils.createSender(this::buildChunkRequest, in, var resultFuture = GrpcFileUploadUtils.createSender(this::buildChunkRequest, in,
this::buildCallStreamObserver) this::buildCallStreamObserver)
......
...@@ -37,7 +37,7 @@ import org.springframework.stereotype.Service; ...@@ -37,7 +37,7 @@ import org.springframework.stereotype.Service;
import de.itvsh.ozg.pluto.command.Command; import de.itvsh.ozg.pluto.command.Command;
@Service @Service("bescheid_currentUserService")
public class CurrentUserService { public class CurrentUserService {
@Autowired @Autowired
......
...@@ -22,6 +22,7 @@ class DummyBescheidRemoteService implements BescheidRemoteService { ...@@ -22,6 +22,7 @@ class DummyBescheidRemoteService implements BescheidRemoteService {
return Bescheid.builder() return Bescheid.builder()
.bescheidFile(file) .bescheidFile(file)
.bescheidFileName(DUMMY_BESCHEID_FILE_NAME)
.contentType(DUMMY_BESCHEID_CONTENT_TYPE) .contentType(DUMMY_BESCHEID_CONTENT_TYPE)
.size(file.length()) .size(file.length())
.createdBy(request.getCreateFor()) .createdBy(request.getCreateFor())
......
...@@ -15,7 +15,7 @@ import de.itvsh.ozg.pluto.vorgang.GrpcVorgangWithEingang; ...@@ -15,7 +15,7 @@ import de.itvsh.ozg.pluto.vorgang.GrpcVorgangWithEingang;
@Mapper(unmappedTargetPolicy = ReportingPolicy.ERROR, // @Mapper(unmappedTargetPolicy = ReportingPolicy.ERROR, //
uses = FormDataEntryMapper.class) uses = FormDataEntryMapper.class)
interface VorgangMapper { interface BescheidVorgangMapper {
@Mapping(target = "vorgangNummer", source = "nummer") @Mapping(target = "vorgangNummer", source = "nummer")
Vorgang mapVorgang(GrpcVorgangWithEingang vorgang); Vorgang mapVorgang(GrpcVorgangWithEingang vorgang);
......
...@@ -8,13 +8,13 @@ import de.itvsh.ozg.pluto.vorgang.VorgangServiceGrpc.VorgangServiceBlockingStub; ...@@ -8,13 +8,13 @@ import de.itvsh.ozg.pluto.vorgang.VorgangServiceGrpc.VorgangServiceBlockingStub;
import lombok.NonNull; import lombok.NonNull;
import net.devh.boot.grpc.client.inject.GrpcClient; import net.devh.boot.grpc.client.inject.GrpcClient;
@Service @Service("bescheid_VorgangRemoteService")
class VorgangRemoteService { class VorgangRemoteService {
@GrpcClient("pluto") @GrpcClient("vorgang-manager")
private VorgangServiceBlockingStub vorgangServiceStub; private VorgangServiceBlockingStub vorgangServiceStub;
@Autowired @Autowired
private VorgangMapper mapper; private BescheidVorgangMapper mapper;
public Vorgang getById(@NonNull VorgangId vorgangId) { public Vorgang getById(@NonNull VorgangId vorgangId) {
var request = GrpcFindVorgangWithEingangRequest.newBuilder().setId(vorgangId.toString()).build(); var request = GrpcFindVorgangWithEingangRequest.newBuilder().setId(vorgangId.toString()).build();
......
...@@ -3,13 +3,15 @@ package de.ozgcloud.bescheid.vorgang; ...@@ -3,13 +3,15 @@ package de.ozgcloud.bescheid.vorgang;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service; import org.springframework.stereotype.Service;
@Service import lombok.NonNull;
@Service("bescheid_VorgangService")
public class VorgangService { public class VorgangService {
@Autowired @Autowired
public VorgangRemoteService remoteService; public VorgangRemoteService remoteService;
public Vorgang getById(VorgangId id) { public Vorgang getById(@NonNull VorgangId id) {
return remoteService.getById(id); return remoteService.getById(id);
} }
} }
...@@ -6,10 +6,10 @@ import org.junit.jupiter.api.Nested; ...@@ -6,10 +6,10 @@ import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.mockito.InjectMocks; import org.mockito.InjectMocks;
class VorgangMapperTest { class BescheidVorgangMapperTest {
@InjectMocks @InjectMocks
private VorgangMapperImpl mapper; private BescheidVorgangMapperImpl mapper;
@Nested @Nested
class TestMapVorgang { class TestMapVorgang {
......
...@@ -25,7 +25,7 @@ class VorgangRemoteServiceTest { ...@@ -25,7 +25,7 @@ class VorgangRemoteServiceTest {
@Mock @Mock
private VorgangServiceBlockingStub serviceStub; private VorgangServiceBlockingStub serviceStub;
@Mock @Mock
private VorgangMapper mapper; private BescheidVorgangMapper mapper;
@Nested @Nested
class TestGetById { class TestGetById {
......
...@@ -24,7 +24,9 @@ ...@@ -24,7 +24,9 @@
unter der Lizenz sind dem Lizenztext zu entnehmen. unter der Lizenz sind dem Lizenztext zu entnehmen.
--> -->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"> <project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion> <modelVersion>4.0.0</modelVersion>
<parent> <parent>
...@@ -84,6 +86,12 @@ ...@@ -84,6 +86,12 @@
<version>${project.version}</version> <version>${project.version}</version>
<scope>runtime</scope> <scope>runtime</scope>
</dependency> </dependency>
<dependency>
<groupId>de.ozgcloud.bescheid</groupId>
<artifactId>bescheid-manager</artifactId>
<version>1.0.0-SNAPSHOT</version>
<scope>runtime</scope>
</dependency>
<dependency> <dependency>
<groupId>de.itvsh.kop.zufi</groupId> <groupId>de.itvsh.kop.zufi</groupId>
...@@ -95,7 +103,8 @@ ...@@ -95,7 +103,8 @@
<groupId>de.itvsh.kop.user</groupId> <groupId>de.itvsh.kop.user</groupId>
<artifactId>user-manager-interface</artifactId> <artifactId>user-manager-interface</artifactId>
<version>${user-manager-interface.version}</version> <version>${user-manager-interface.version}</version>
<!-- TODO Nur proto sources verwenden um quarkus Abhaenigkeiten zu vermeiden. Ebenso im notification-manager --> <!-- TODO Nur proto sources verwenden um quarkus Abhaenigkeiten zu
vermeiden. Ebenso im notification-manager -->
<exclusions> <exclusions>
<exclusion> <exclusion>
<groupId>io.grpc</groupId> <groupId>io.grpc</groupId>
......
...@@ -42,7 +42,7 @@ import org.springframework.security.task.DelegatingSecurityContextAsyncTaskExecu ...@@ -42,7 +42,7 @@ import org.springframework.security.task.DelegatingSecurityContextAsyncTaskExecu
import io.mongock.runner.springboot.EnableMongock; import io.mongock.runner.springboot.EnableMongock;
@SpringBootApplication(scanBasePackages = "de.itvsh.*") @SpringBootApplication(scanBasePackages = { "de.itvsh.*", "de.ozgcloud" })
@EnableAsync @EnableAsync
@EnableScheduling @EnableScheduling
@EnableAspectJAutoProxy(proxyTargetClass = true) @EnableAspectJAutoProxy(proxyTargetClass = true)
......
...@@ -24,11 +24,17 @@ grpc: ...@@ -24,11 +24,17 @@ grpc:
pluto: pluto:
address: self:self address: self:self
negotiationType: PLAINTEXT negotiationType: PLAINTEXT
vorgang-manager:
address: self:self
negotiationType: PLAINTEXT
user-manager: user-manager:
negotiationType: TLS negotiationType: TLS
email: email:
address: self:self address: self:self
negotiationType: PLAINTEXT negotiationType: PLAINTEXT
nachrichten-manager:
address: self:self
negotiationType: PLAINTEXT
pluto: pluto:
redirect: redirect:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment