Merge pull request 'configure helm resources' (#53) from configure-helm-resources into master

Reviewed-on: https://git.ozg-sh.de/mgm/user-manager/pulls/53

src/main/helm/templates/_helpers.tpl

@@ -60,24 +60,6 @@ app.kubernetes.io/namespace: {{ include "app.namespace" . }}
 {{- required "Database Passwort muss angegeben sein" (.Values.database).password -}}
 {{- end -}}
 
-{{- define "app.resources" }}
-{{- if eq (include "app.kopEnvironment" . ) "prod" }}
-  limits:
-    cpu: "500m"
-    memory: "2000Mi"
-  requests:
-    cpu: "50m"
-    memory: "250Mi"
-{{- else }}
-  limits:
-    cpu: "500m"
-    memory: "100Mi"
-  requests:
-    cpu: "50m"
-    memory: "100Mi"
-{{- end }}
-{{- end -}}
-
 {{- define "app.ssoServerUrl" -}}
 {{- if contains "https://" .Values.sso.serverUrl -}}
 {{- .Values.sso.serverUrl -}}

src/main/helm/templates/deployment.yaml

@@ -133,7 +133,9 @@ spec:
           successThreshold: 1
           timeoutSeconds: 5
         resources:
-          {{- include "app.resources" . | indent 8 }}
+        {{- with .Values.resources }}
+{{ toYaml . | indent 10 }}
+        {{- end }}
         securityContext:
           allowPrivilegeEscalation: false
           privileged: false

src/test/helm/deployment_resources_test.yaml

@@ -27,41 +27,31 @@ release:
   name: user-manager
 templates:
   - templates/deployment.yaml
-  - templates/secret_database_quarkus.yaml
 tests:
-  - it: test resources for prod environment
+  - it: test resources
     template: deployment.yaml
-    release:
-      namespace: sh-helm-prod
     set:
-      kop.environment: prod
+      resources:
+        limits:
+          cpu: "11m"
+          memory: "22Mi"
+        requests:
+          cpu: "33m"
+          memory: "44Mi"
     asserts:
       - equal:
           path: spec.template.spec.containers[0].resources.limits.cpu
-          value: 500m
+          value: 11m
       - equal:
           path: spec.template.spec.containers[0].resources.limits.memory
-          value: 2000Mi
+          value: 22Mi
       - equal:
           path: spec.template.spec.containers[0].resources.requests.cpu
-          value: 50m
+          value: 33m
       - equal:
           path: spec.template.spec.containers[0].resources.requests.memory
-          value: 250Mi
-  - it: test default resources
-    template: deployment.yaml
-    release:
-      namespace: sh-helm-test
+          value: 44Mi
+  - it: test empty resources
     asserts:
-      - equal:
-          path: spec.template.spec.containers[0].resources.limits.cpu
-          value: 500m
+      - isEmpty:
+          path: spec.template.spec.containers[0].resources
\ No newline at end of file
-      - equal:
-          path: spec.template.spec.containers[0].resources.limits.memory
-          value: 100Mi
-      - equal:
-          path: spec.template.spec.containers[0].resources.requests.cpu
-          value: 50m
-      - equal:
-          path: spec.template.spec.containers[0].resources.requests.memory
-          value: 100Mi
\ No newline at end of file