Skip to content
Snippets Groups Projects
Commit 027c7116 authored by OZGCloud's avatar OZGCloud
Browse files

OZG-2626 Tests hinzugefügt

parent 0569511a
No related branches found
No related tags found
No related merge requests found
...@@ -11,6 +11,7 @@ import de.itvsh.kop.user.common.errorhandling.ResourceNotFoundException; ...@@ -11,6 +11,7 @@ import de.itvsh.kop.user.common.errorhandling.ResourceNotFoundException;
@ApplicationScoped @ApplicationScoped
public class UserService { public class UserService {
static final String UUID_PATTERN = "-";
@Inject @Inject
UserRepository repository; UserRepository repository;
...@@ -45,7 +46,7 @@ public class UserService { ...@@ -45,7 +46,7 @@ public class UserService {
} }
public User findById(String id) { public User findById(String id) {
if (id.contains("-")) { if (id.contains(UUID_PATTERN)) {
// TODO wenn user migriert wurden wieder entfernen. // TODO wenn user migriert wurden wieder entfernen.
return repository.findByExternalId(id).orElseThrow(() -> new ResourceNotFoundException(User.class, id)); return repository.findByExternalId(id).orElseThrow(() -> new ResourceNotFoundException(User.class, id));
} }
......
...@@ -5,6 +5,7 @@ import static org.mockito.Mockito.*; ...@@ -5,6 +5,7 @@ import static org.mockito.Mockito.*;
import java.time.Instant; import java.time.Instant;
import java.util.Optional; import java.util.Optional;
import java.util.UUID;
import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Nested; import org.junit.jupiter.api.Nested;
...@@ -23,6 +24,28 @@ class UserServiceTest { ...@@ -23,6 +24,28 @@ class UserServiceTest {
@Mock @Mock
KeycloakUserRemoteService keycloakRemoteService; KeycloakUserRemoteService keycloakRemoteService;
@DisplayName("Find")
@Nested
class TestFind {
@Test
void shouldCallFindById() {
when(repository.findById(anyString())).thenReturn(Optional.of(UserTestFactory.create()));
service.findById("xxx");
verify(repository).findById(anyString());
}
@Test
void shouldCallFindByExternalId() {
when(repository.findByExternalId(any())).thenReturn(Optional.of(UserTestFactory.create()));
service.findById(UUID.randomUUID().toString());
verify(repository).findByExternalId(anyString());
}
}
@DisplayName("Save") @DisplayName("Save")
@Nested @Nested
class TestSave { class TestSave {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment