OZG-4095 Simplify replacement

src/main/java/de/ozgcloud/nachrichten/postfach/osiv2/transfer/Osi2HtmlDocument.java

@@ -24,39 +24,32 @@ public record Osi2HtmlDocument(String html) {
 	}
 
 	static final List<SpanRendering> SPAN_RENDERINGS = List.of(
+			SpanRendering.of("a", anchor -> "[" + anchor.text() + "](" + anchor.attr("href") + ")"),
+			SpanRendering.of("img", image -> "![" + image.attr("alt") + "](" + image.attr("src") + ")"),
+			SpanRendering.of("i", italic -> "_" + italic.text() + "_"),
+			SpanRendering.of("em", italic -> "_" + italic.text() + "_"),
+			SpanRendering.of("b", bold -> "__" + bold.text() + "__"),
+			SpanRendering.of("strong", bold -> "__" + bold.text() + "__"),
 			SpanRendering.of("h1", heading -> "# " + heading.text()),
 			SpanRendering.of("h2", heading -> "## " + heading.text()),
 			SpanRendering.of("h3", heading -> "### " + heading.text()),
-			SpanRendering.of("i", italic -> "*" + italic.text() + "*"),
-			SpanRendering.of("em", italic -> "*" + italic.text() + "*"),
-			SpanRendering.of("b", bold -> "**" + bold.text() + "**"),
-			SpanRendering.of("strong", bold -> "**" + bold.text() + "**"),
-			SpanRendering.of("img", image -> "![" + image.attr("alt") + "](" + image.attr("src") + ")"),
-			SpanRendering.of("a", anchor -> "[" + anchor.text() + "](" + anchor.attr("href") + ")"),
-			SpanRendering.of("blockquote", bold -> "> " + bold.wholeText())
+			SpanRendering.of("blockquote", bold -> "> " + bold.text())
 	);
 
-	public String renderHTMLToPlainText() {
+	public String renderToPlainText() {
 		var document = Jsoup.parse(html);
-		addNewlinesForSubsequentParagraphs(document);
-		replaceElementsWithMarkdownSpansIn(document);
+		applySpanRenderings(document);
 		return document.wholeText();
 	}
 
-	private void addNewlinesForSubsequentParagraphs(Document document) {
-		document.body()
-				.select("p + p")
-				.prepend("\n");
-	}
-
-	private void replaceElementsWithMarkdownSpansIn(Document document) {
+	private void applySpanRenderings(Document document) {
 		for (var entry : SPAN_RENDERINGS) {
 			entry.replaceElementsWithMarkdownSpansIn(document);
 		}
 	}
 
-	public static String renderPlainText(String html) {
-		return new Osi2HtmlDocument(html).renderHTMLToPlainText();
+	public static String renderToPlainText(String html) {
+		return new Osi2HtmlDocument(html).renderToPlainText();
 	}
 
 }

src/main/java/de/ozgcloud/nachrichten/postfach/osiv2/transfer/PostfachApiFacadeService.java

@@ -49,6 +49,5 @@ public class PostfachApiFacadeService {
 
 	public void deleteMessage(final String messageId) {
 		messageExchangeApi.deleteMessage(UUID.fromString(messageId));
-
 	}
 }

src/test/java/de/ozgcloud/nachrichten/postfach/osiv2/transfer/Osi2HtmlDocumentTest.java

@@ -71,9 +71,9 @@ class Osi2HtmlDocumentTest {
 	@DisplayName("should render blockquote")
 	@Test
 	void shouldRenderBlockquote() {
-		var plainText = renderPlainText("<blockquote><p>Example</p><p>Example2</p></blockquote>");
+		var plainText = renderPlainText("<blockquote><p>Example</p>\n<p>Example2</p></blockquote>");
 
-		assertThat(plainText).isEqualTo("> Example\nExample2");
+		assertThat(plainText).isEqualTo("> Example Example2");
 	}
 
 	@DisplayName("should render html")
@@ -85,6 +85,6 @@ class Osi2HtmlDocumentTest {
 	}
 	
 	private String renderPlainText(String html) {
-		return new Osi2HtmlDocument(html).renderHTMLToPlainText();
+		return new Osi2HtmlDocument(html).renderToPlainText();
 	}
 }
\ No newline at end of file