accessibility low hanging fruits

goofy-client/libs/navigation/src/lib/header-container/header/header.component.html

@@ -4,7 +4,7 @@
 		</goofy-client-icon-button-with-spinner>
 		<a routerLink="/" routerLinkActive="active" [routerLinkActiveOptions]="{ exact: true }">
 			<img src="/assets/img/logo.svg" alt="Goofy Logo" />
-			<h1 data-test-id='title'>Goofy</h1>
+			<div data-test-id='title'>Goofy</div>
 		</a>
 	</div>
 

goofy-client/libs/ui/src/lib/ui/expansion-panel/expansion-panel.component.html

@@ -4,7 +4,7 @@
 
 		<mat-expansion-panel-header>
 			<mat-panel-title data-test-class="panel-title">
-				<button mat-icon-button tabindex="-1">
+				<button mat-icon-button tabindex="-1" [attr.aria-label]="'button to show' + (expanded? 'more': 'less') + ' info'">
 					<mat-icon>chevron_right</mat-icon>
 				</button>
 				<h3>{{ headline }}</h3>

goofy-client/libs/ui/src/lib/ui/file-upload/file-upload.component.html

-<label [attr.for]="myId" matRipple>
-	<mat-icon>attach_file</mat-icon>
-</label>
-
-<input #fileInput data-test-id="file-upload-input"
+<input data-test-id="file-upload-input"
 	[id]="myId" type="file" [accept]="accept"
 	(change)="onFileChanged($event)">
+<label [attr.for]="myId" matRipple aria-label="attachment icon">
+	<mat-icon>attach_file</mat-icon>
+</label>

goofy-client/libs/ui/src/lib/ui/icon-button-with-spinner/icon-button-with-spinner.component.html

 <button mat-icon-button
-		[attr.aria-label]="'icon button with a ' + icon + ' icon'"
+		[attr.aria-label]="'icon button with a ' + (icon ? icon : svgIcon) + ' icon'"
 		[disabled]="isDisabled"
 		(click)="clickEmitter.emit($event)"
 		[matTooltip]="toolTip"

goofy-client/libs/user-profile/src/lib/user-profile-in-vorgang-container/user-profile-button-container/user-profile-button-container.component.html

 <button #menuTrigger="matMenuTrigger"
 		[matMenuTriggerFor]="menu"
 		(menuOpened)="showUserProfileSearch()" (menuClosed)="hideUserProfileSearch()"
+		aria-label="icon button with a account icon"
 		class="user-profile-button">
 
 	<goofy-client-user-icon data-test-id="user-profile-icon"

goofy-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-area/vorgang-detail-header/vorgang-detail-header.component.html

@@ -6,7 +6,7 @@
 <div class="line">
 	<div class="identifier">
 		<h1 goofy-client-aktenzeichen [vorgang]="vorgangWithEingang"></h1>
-		<h3 data-test-id="name">{{ vorgangWithEingang.name }}</h3>
+		<h2 data-test-id="name">{{ vorgangWithEingang.name }}</h2>
 	</div>
 	<goofy-client-user-profile-in-vorgang-container *ngIf="vorgangWithEingang | hasLink: linkRel.ASSIGN" data-test-id="vorgang-header-user-icon"
 		[vorgang]="vorgangWithEingang"

goofy-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-area/vorgang-detail-header/vorgang-detail-header.component.scss

@@ -25,7 +25,9 @@ h1 {
 	font-weight: 400;
 }
 
-h3 {
+h2 {
 	line-height: 1.4;
 	margin: 0;
+	font-size: 16px;
+	font-weight: 400;
 }

goofy-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-page.component.html

 <ng-container *ngIf="vorgangStateResource$ | async as vorgangStateResource">
 
 	<goofy-client-subnavigation>
-		<a routerLink="/" mat-icon-button data-test-id="back-button" class="back-button">
+		<a routerLink="/" mat-icon-button data-test-id="back-button" class="back-button" aria-label="back button with arrow icon">
 			<mat-icon>arrow_back</mat-icon>
 		</a>
 		<goofy-client-vorgang-detail-action-buttons [vorgangWithEingang]="vorgangStateResource"></goofy-client-vorgang-detail-action-buttons>

goofy-client/libs/wiedervorlage/src/lib/wiedervorlage-list-in-vorgang-container/wiedervorlage-list-in-vorgang/wiedervorlage-in-vorgang/wiedervorlage-in-vorgang.component.html

@@ -16,7 +16,9 @@
 		</a>
 
 		<button *ngIf="wiedervorlageResource.beschreibung || wiedervorlageResource.attachments.length > 0" data-test-class="expand-button"
-			[ngClass]="{ 'is-open': expanded }" [matTooltip]="tooltip" mat-icon-button
+				[ngClass]="{ 'is-open': expanded }"
+				[attr.aria-label]="'button to show' + (expanded? 'more': 'less') + ' info'"
+				[matTooltip]="tooltip" mat-icon-button
 				(click)="toggle()">
 			<mat-icon>chevron_right</mat-icon>
 		</button>
@@ -24,7 +26,8 @@
 	<div *ngIf="expanded" data-test-class="expandable" class="expandable">
 		<p *ngIf="wiedervorlageResource.beschreibung" [matTooltip]="tooltip">{{ wiedervorlageResource.beschreibung }}</p>
 
-		<goofy-client-wiedervorlage-attachment-list-in-vorgang *ngIf="wiedervorlageResource | hasLink: linkRel.ATTACHMENTS" data-test-id="wiedervorlage-attachment-list-in-vorgang"
+		<goofy-client-wiedervorlage-attachment-list-in-vorgang *ngIf="wiedervorlageResource | hasLink: linkRel.ATTACHMENTS"
+				data-test-id="wiedervorlage-attachment-list-in-vorgang"
 				[wiedervorlage]="wiedervorlageResource" class="attachments">
 		</goofy-client-wiedervorlage-attachment-list-in-vorgang>
 	</div>

goofy-client/libs/wiedervorlage/src/lib/wiedervorlage-page-container/wiedervorlage-page/wiedervorlage-action-buttons/wiedervorlage-action-buttons.component.html

-<a routerLink="../.." mat-icon-button data-test-id="back-button" class="back-button">
+<a routerLink="../.." mat-icon-button data-test-id="back-button" class="back-button" aria-label="back button with arrow icon">
 	<mat-icon>arrow_back</mat-icon>
 </a>
 <goofy-client-erledigen-button-container [wiedervorlage]="wiedervorlage"></goofy-client-erledigen-button-container>