Skip to content
Snippets Groups Projects
Commit 77ca924c authored by OZGCloud's avatar OZGCloud
Browse files

Merge pull request 'OZG-6676-OZG-7028-bugfix' (#799) from OZG-6676-OZG-7028-bugfix into master

parents f64f388d fb799b2d
No related branches found
No related tags found
No related merge requests found
...@@ -15,6 +15,7 @@ export class OzgcloudDialogService { ...@@ -15,6 +15,7 @@ export class OzgcloudDialogService {
readonly GREY_BLUR_CONFIG: DialogConfig = { readonly GREY_BLUR_CONFIG: DialogConfig = {
backdropClass: ['backdrop-blur-1', 'bg-greybackdrop'], backdropClass: ['backdrop-blur-1', 'bg-greybackdrop'],
disableClose: true,
}; };
constructor(private dialog: Dialog) {} constructor(private dialog: Dialog) {}
......
...@@ -72,17 +72,31 @@ describe('SearchZustaendigeStelleDialogComponent', () => { ...@@ -72,17 +72,31 @@ describe('SearchZustaendigeStelleDialogComponent', () => {
}); });
describe('onKeyDownHandler', () => { describe('onKeyDownHandler', () => {
it('should prevent default behavior for enter key', () => { it('should prevent default behavior for enter key on non buttons', () => {
const keyboardEvent: KeyboardEvent = { const keyboardEvent: KeyboardEvent = {
...new KeyboardEvent('enter'), ...new KeyboardEvent('enter'),
key: 'Enter', key: 'Enter',
preventDefault: jest.fn(), preventDefault: jest.fn(),
target: new EventTarget(),
}; };
component.onKeyDownHandler(keyboardEvent); component.onKeyDownHandler(keyboardEvent);
expect(keyboardEvent.preventDefault).toHaveBeenCalled(); expect(keyboardEvent.preventDefault).toHaveBeenCalled();
}); });
it('should not prevent default behavior for enter key on buttons', () => {
const keyboardEvent: KeyboardEvent = {
...new KeyboardEvent('enter'),
key: 'Enter',
preventDefault: jest.fn(),
target: { ...new EventTarget(), tagName: 'BUTTON' } as Element,
};
component.onKeyDownHandler(keyboardEvent);
expect(keyboardEvent.preventDefault).not.toHaveBeenCalled();
});
}); });
describe('search organisationsEinheit component', () => { describe('search organisationsEinheit component', () => {
...@@ -200,4 +214,22 @@ describe('SearchZustaendigeStelleDialogComponent', () => { ...@@ -200,4 +214,22 @@ describe('SearchZustaendigeStelleDialogComponent', () => {
expect(dialogRefMock.close).toHaveBeenCalled(); expect(dialogRefMock.close).toHaveBeenCalled();
}); });
}); });
describe('isNotButtonElement', () => {
it('should return false', () => {
const element: Element = { tagName: 'BUTTON' } as Element;
const result: boolean = component.isNotButtonElement(element);
expect(result).toBe(false);
});
it('should return true', () => {
const element: Element = { tagName: 'INPUT' } as Element;
const result: boolean = component.isNotButtonElement(element);
expect(result).toBe(true);
});
});
}); });
...@@ -26,7 +26,9 @@ export class SearchZustaendigeStelleDialogComponent<T extends Resource> implemen ...@@ -26,7 +26,9 @@ export class SearchZustaendigeStelleDialogComponent<T extends Resource> implemen
@HostListener('document:keydown', ['$event']) @HostListener('document:keydown', ['$event'])
onKeyDownHandler(e: KeyboardEvent) { onKeyDownHandler(e: KeyboardEvent) {
if (e.key === 'Enter') e.preventDefault(); if (e.key === 'Enter' && this.isNotButtonElement(e.target as Element)) {
e.preventDefault();
}
} }
public search(searchBy: string): void { public search(searchBy: string): void {
...@@ -47,4 +49,8 @@ export class SearchZustaendigeStelleDialogComponent<T extends Resource> implemen ...@@ -47,4 +49,8 @@ export class SearchZustaendigeStelleDialogComponent<T extends Resource> implemen
this.clearSearchResult(); this.clearSearchResult();
this.dialogRef.close(); this.dialogRef.close();
} }
public isNotButtonElement(e: Element): boolean {
return e.tagName !== 'BUTTON';
}
} }
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment