Merge pull request 'OZG-6574 ignore case for service konto type comparison'...

Merge pull request 'OZG-6574 ignore case for service konto type comparison' (#746) from OZG-6574-ignore-case-for-service-konto-type into master

Reviewed-on: https://git.ozg-sh.de/ozgcloud-app/alfa/pulls/746


Reviewed-by: OZGCloud <ozgcloud@mgm-tp.com>

alfa-service/src/main/java/de/ozgcloud/alfa/postfach/PostfachMailService.java

@@ -161,7 +161,7 @@ class PostfachMailService {
 		}
 
 		return postfachConfigGroup.getPostfachConfigs().stream()
-				.filter(postfachConfig -> postfachConfig.getType().equals(serviceKontoType))
+				.filter(postfachConfig -> postfachConfig.getType().equalsIgnoreCase(serviceKontoType))
 				.map(PostfachConfig::isReplyAllowed)
 				.findFirst()
 				.orElse(false);

alfa-service/src/test/java/de/ozgcloud/alfa/postfach/PostfachMailServiceTest.java

@@ -556,7 +556,7 @@ class PostfachMailServiceTest {
 		}
 
 		@Test
-		@DisplayName("reply not allowed for given ServiceKonto-type")
+		@DisplayName("reply not allowed if postfach not configured")
 		void shouldReturnFalseIfPostfachNotConfigured() {
 			setPostfachConfigGroup(PostfachConfigGroupTestFactory.createBuilder().postfachConfigs(List.of()).build());
 			doReturn(false).when(service).isPostfachConfigured();
@@ -612,6 +612,17 @@ class PostfachMailServiceTest {
 			assertThat(replyAllowed).isTrue();
 		}
 
+		@Test
+		@DisplayName("reply allowed for given lower case ServiceKonto-type")
+		void shouldReturnTrueIfReplyIsAllowedForLowerCaseServiceKontoType() {
+			setPostfachConfigGroup(PostfachConfigGroupTestFactory.create());
+			doReturn(true).when(service).isPostfachConfigured();
+
+			var replyAllowed = service.isReplyAllowed(PostfachConfigTestFactory.TYPE.toLowerCase());
+
+			assertThat(replyAllowed).isTrue();
+		}
+
 		@Test
 		void shouldReturnTrueIfAlwaysAllowed() {
 			when(featureToggleProperties.isReplyAlwaysAllowed()).thenReturn(true);