Skip to content
Snippets Groups Projects
Commit 089b1006 authored by OZGCloud's avatar OZGCloud
Browse files

OZG-4994 OZG-5061 rename

parent fce317bf
Branches
Tags
No related merge requests found
...@@ -12,5 +12,5 @@ public class Statistic { ...@@ -12,5 +12,5 @@ public class Statistic {
private ByStatus byStatus; private ByStatus byStatus;
private int wiedervorlagen; private int wiedervorlagen;
private boolean existsWiedervorlageOverdue; private boolean existsWiedervorlageOverdue;
private int unreadMessages; private int ungeleseneNachrichten;
} }
...@@ -25,11 +25,11 @@ class StatisticRemoteService { ...@@ -25,11 +25,11 @@ class StatisticRemoteService {
static final String COUNT_VORGANG_STATUS_RESULT_NAME_FORMAT = "countVorgangStatus_%s"; static final String COUNT_VORGANG_STATUS_RESULT_NAME_FORMAT = "countVorgangStatus_%s";
static final String COUNT_WIEDERVORLAGE_NEXT_FRIST_RESULT_NAME = "countWiedervorlage"; static final String COUNT_WIEDERVORLAGE_NEXT_FRIST_RESULT_NAME = "countWiedervorlage";
static final String EXISTS_WIEDERVORLAGE_OVERDUE_RESULT_NAME = "existsWiedervorlageOverdue"; static final String EXISTS_WIEDERVORLAGE_OVERDUE_RESULT_NAME = "existsWiedervorlageOverdue";
static final String COUNT_VORGAENGE_WITH_UNREAD_MESSAGES_RESULT_NAME = "countVorgaengeWithUnreadMessages"; static final String COUNT_VORGAENGE_WITH_UNGELESENE_NACHRICHTEN_RESULT_NAME = "countVorgaengeWithUngeleseneNachrichten";
static final String STATUS_PATH = "Vorgang.status"; static final String STATUS_PATH = "Vorgang.status";
static final String WIEDERVORLAGE_NEXT_FRIST_PATH_TEMPLATE = "ClientAttribute.%s.nextWiedervorlageFrist"; static final String WIEDERVORLAGE_NEXT_FRIST_PATH_TEMPLATE = "ClientAttribute.%s.nextWiedervorlageFrist";
static final String VORGAENGE_WITH_UNREAD_MESSAGES_PATH = "ClientAttribute.OzgCloud_NachrichtenManager.hasNewPostfachNachricht"; static final String VORGAENGE_WITH_UNGELESENE_NACHRICHTEN_PATH = "ClientAttribute.OzgCloud_NachrichtenManager.hasNewPostfachNachricht";
static final String OPERAND_TODAY_DATE = "today()"; static final String OPERAND_TODAY_DATE = "today()";
...@@ -45,7 +45,7 @@ class StatisticRemoteService { ...@@ -45,7 +45,7 @@ class StatisticRemoteService {
.addAllQuery(buildCountByStatusQueries(countByVorgangStatus)) .addAllQuery(buildCountByStatusQueries(countByVorgangStatus))
.addQuery(buildCountWiedervorlageNextFristQuery()) .addQuery(buildCountWiedervorlageNextFristQuery())
.addQuery(buildExistsWiedervorlageOverdueQuery()) .addQuery(buildExistsWiedervorlageOverdueQuery())
.addQuery(buildCountVorgaengeWithUnreadMessagesQuery()) .addQuery(buildCountVorgaengeWithUngeleseneNachrichtenQuery())
.build(); .build();
var grpcResponse = statisticServiceStub.getVorgangStatistic(grpcRequest); var grpcResponse = statisticServiceStub.getVorgangStatistic(grpcRequest);
...@@ -97,10 +97,10 @@ class StatisticRemoteService { ...@@ -97,10 +97,10 @@ class StatisticRemoteService {
.collect(Collectors.toMap(StatisticResult::getName, Function.identity())); .collect(Collectors.toMap(StatisticResult::getName, Function.identity()));
} }
public GrpcVorgangStatisticQuery buildCountVorgaengeWithUnreadMessagesQuery() { public GrpcVorgangStatisticQuery buildCountVorgaengeWithUngeleseneNachrichtenQuery() {
return GrpcVorgangStatisticQuery.newBuilder() return GrpcVorgangStatisticQuery.newBuilder()
.setResultName(COUNT_VORGAENGE_WITH_UNREAD_MESSAGES_RESULT_NAME) .setResultName(COUNT_VORGAENGE_WITH_UNGELESENE_NACHRICHTEN_RESULT_NAME)
.setPath(VORGAENGE_WITH_UNREAD_MESSAGES_PATH) .setPath(VORGAENGE_WITH_UNGELESENE_NACHRICHTEN_PATH)
.setGroupMethod(GroupMethod.COUNT) .setGroupMethod(GroupMethod.COUNT)
.setOperator(Operator.UNEQUAL) .setOperator(Operator.UNEQUAL)
.build(); .build();
......
...@@ -48,7 +48,7 @@ class StatisticService { ...@@ -48,7 +48,7 @@ class StatisticService {
return Statistic.builder() return Statistic.builder()
.existsWiedervorlageOverdue(getBooleanResult(response, StatisticRemoteService.EXISTS_WIEDERVORLAGE_OVERDUE_RESULT_NAME)) .existsWiedervorlageOverdue(getBooleanResult(response, StatisticRemoteService.EXISTS_WIEDERVORLAGE_OVERDUE_RESULT_NAME))
.wiedervorlagen(getIntResult(response, StatisticRemoteService.COUNT_WIEDERVORLAGE_NEXT_FRIST_RESULT_NAME)) .wiedervorlagen(getIntResult(response, StatisticRemoteService.COUNT_WIEDERVORLAGE_NEXT_FRIST_RESULT_NAME))
.unreadMessages(getIntResult(response, StatisticRemoteService.COUNT_VORGAENGE_WITH_UNREAD_MESSAGES_RESULT_NAME)) .ungeleseneNachrichten(getIntResult(response, StatisticRemoteService.COUNT_VORGAENGE_WITH_UNGELESENE_NACHRICHTEN_RESULT_NAME))
.byStatus(ByStatus.builder() .byStatus(ByStatus.builder()
.neu(getIntResult(response, remoteService.buildCountByStatusResultName(VorgangStatus.NEU))) .neu(getIntResult(response, remoteService.buildCountByStatusResultName(VorgangStatus.NEU)))
.abgeschlossen(getIntResult(response, remoteService.buildCountByStatusResultName(VorgangStatus.ABGESCHLOSSEN))) .abgeschlossen(getIntResult(response, remoteService.buildCountByStatusResultName(VorgangStatus.ABGESCHLOSSEN)))
......
...@@ -193,8 +193,8 @@ class StatisticRemoteServiceTest { ...@@ -193,8 +193,8 @@ class StatisticRemoteServiceTest {
class TestGetVorgaengeStatistics { class TestGetVorgaengeStatistics {
private final GrpcVorgangStatisticResponse response = GrpcVorgangStatisticResponseTestFactory.create(); private final GrpcVorgangStatisticResponse response = GrpcVorgangStatisticResponseTestFactory.create();
private final GrpcVorgangStatisticQuery countVorgaengeWithUnreadMessagesQuery = GrpcVorgangStatisticQueryTestFactory.createBuilder() private final GrpcVorgangStatisticQuery countVorgaengeWithUngeleseneNachrichtenQuery = GrpcVorgangStatisticQueryTestFactory.createBuilder()
.setResultName("unread messages").build(); .setResultName("ungelesene nachrichten").build();
private final GrpcVorgangStatisticQuery existsWiedervorlageOverdueQuery = GrpcVorgangStatisticQueryTestFactory.createBuilder() private final GrpcVorgangStatisticQuery existsWiedervorlageOverdueQuery = GrpcVorgangStatisticQueryTestFactory.createBuilder()
.setResultName("exists overdue").build(); .setResultName("exists overdue").build();
...@@ -206,7 +206,7 @@ class StatisticRemoteServiceTest { ...@@ -206,7 +206,7 @@ class StatisticRemoteServiceTest {
when(serviceStub.getVorgangStatistic(any())).thenReturn(response); when(serviceStub.getVorgangStatistic(any())).thenReturn(response);
doReturn(existsWiedervorlageOverdueQuery).when(service).buildExistsWiedervorlageOverdueQuery(); doReturn(existsWiedervorlageOverdueQuery).when(service).buildExistsWiedervorlageOverdueQuery();
doReturn(countVorgaengeWithUnreadMessagesQuery).when(service).buildCountVorgaengeWithUnreadMessagesQuery(); doReturn(countVorgaengeWithUngeleseneNachrichtenQuery).when(service).buildCountVorgaengeWithUngeleseneNachrichtenQuery();
} }
@Test @Test
...@@ -245,18 +245,18 @@ class StatisticRemoteServiceTest { ...@@ -245,18 +245,18 @@ class StatisticRemoteServiceTest {
} }
@Test @Test
void shouldCallBuildCountVorgaengeWithUnreadMessagesQuery() { void shouldCallBuildCountVorgaengeWithUngeleseneNachrichtenQuery() {
service.getVorgaengeStatistics(STATUSES_TO_COUNT); service.getVorgaengeStatistics(STATUSES_TO_COUNT);
verify(service).buildCountVorgaengeWithUnreadMessagesQuery(); verify(service).buildCountVorgaengeWithUngeleseneNachrichtenQuery();
} }
@Test @Test
void shouldAddCountVorgaengeWithUnreadMessagesQuery() { void shouldAddCountVorgaengeWithUngeleseneNachrichtenQuery() {
service.getVorgaengeStatistics(STATUSES_TO_COUNT); service.getVorgaengeStatistics(STATUSES_TO_COUNT);
verify(serviceStub).getVorgangStatistic(grpcRequestCaptor.capture()); verify(serviceStub).getVorgangStatistic(grpcRequestCaptor.capture());
assertThat(grpcRequestCaptor.getValue().getQueryList()).contains(countVorgaengeWithUnreadMessagesQuery); assertThat(grpcRequestCaptor.getValue().getQueryList()).contains(countVorgaengeWithUngeleseneNachrichtenQuery);
} }
} }
...@@ -298,20 +298,20 @@ class StatisticRemoteServiceTest { ...@@ -298,20 +298,20 @@ class StatisticRemoteServiceTest {
} }
@Nested @Nested
class TestBuildCountVorgaengeWithUnreadMessagesQuery { class TestBuildCountVorgaengeWithUngeleseneNachrichtenQuery {
@Test @Test
void shouldHaveResultName() { void shouldHaveResultName() {
var query = callService(); var query = callService();
assertThat(query.getResultName()).isEqualTo(COUNT_VORGAENGE_WITH_UNREAD_MESSAGES_RESULT_NAME); assertThat(query.getResultName()).isEqualTo(COUNT_VORGAENGE_WITH_UNGELESENE_NACHRICHTEN_RESULT_NAME);
} }
@Test @Test
void shouldHavePath() { void shouldHavePath() {
var query = callService(); var query = callService();
assertThat(query.getPath()).isEqualTo(VORGAENGE_WITH_UNREAD_MESSAGES_PATH); assertThat(query.getPath()).isEqualTo(VORGAENGE_WITH_UNGELESENE_NACHRICHTEN_PATH);
} }
@Test @Test
...@@ -329,7 +329,7 @@ class StatisticRemoteServiceTest { ...@@ -329,7 +329,7 @@ class StatisticRemoteServiceTest {
} }
private GrpcVorgangStatisticQuery callService() { private GrpcVorgangStatisticQuery callService() {
return service.buildCountVorgaengeWithUnreadMessagesQuery(); return service.buildCountVorgaengeWithUngeleseneNachrichtenQuery();
} }
} }
} }
\ No newline at end of file
...@@ -140,11 +140,11 @@ class StatisticServiceTest { ...@@ -140,11 +140,11 @@ class StatisticServiceTest {
} }
@Test @Test
void shouldContainUnreadMessages() { void shouldContainUngeleseneNachrichten() {
var statistic = service.buildGetVorgaengeStatisticResult( var statistic = service.buildGetVorgaengeStatisticResult(
Map.of(COUNT_VORGAENGE_WITH_UNREAD_MESSAGES_RESULT_NAME, StatisticResultTestFactory.create())); Map.of(COUNT_VORGAENGE_WITH_UNGELESENE_NACHRICHTEN_RESULT_NAME, StatisticResultTestFactory.create()));
assertThat(statistic.getUnreadMessages()).isEqualTo(StatisticResultTestFactory.INT_VALUE); assertThat(statistic.getUngeleseneNachrichten()).isEqualTo(StatisticResultTestFactory.INT_VALUE);
} }
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment