Skip to content
Snippets Groups Projects
Commit ec01a13c authored by Lukas Malte Monnerjahn's avatar Lukas Malte Monnerjahn
Browse files

sonar

parent 2a509fec
Branches
Tags
1 merge request!5Kop 2694 xta client lib verwenden
Pipeline #2161 skipped
......@@ -30,6 +30,8 @@ import org.springframework.stereotype.Component;
import lombok.extern.log4j.Log4j2;
import de.ozgcloud.xta.client.exception.XtaClientException;
@Log4j2
@Component
class XtaRunner implements ApplicationListener<ContextRefreshedEvent> {
......@@ -46,7 +48,7 @@ class XtaRunner implements ApplicationListener<ContextRefreshedEvent> {
void runGetXtaMessages() {
try {
service.fetchMessages();
} catch (RuntimeException e) {
} catch (XtaClientException | RuntimeException e) {
LOG.error("Error fetch XTA Message List.", e);
}
}
......
......@@ -30,7 +30,6 @@ import java.util.Optional;
import java.util.function.Consumer;
import lombok.NonNull;
import lombok.SneakyThrows;
import lombok.extern.log4j.Log4j2;
import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.lang3.StringUtils;
......@@ -46,6 +45,7 @@ import de.ozgcloud.eingang.common.vorgang.VorgangNummerSupplier;
import de.ozgcloud.eingang.semantik.SemantikAdapter;
import de.ozgcloud.eingang.xdomea.XdomeaMessageDataMapper;
import de.ozgcloud.xta.client.XtaClient;
import de.ozgcloud.xta.client.exception.XtaClientException;
import de.ozgcloud.xta.client.model.XtaFile;
import de.ozgcloud.xta.client.model.XtaMessage;
import de.ozgcloud.xta.client.model.XtaMessageMetaData;
......@@ -60,7 +60,7 @@ class XtaService {
static final String FIM_MESSAGE_TYPE_PREFIX = "fim.";
final Consumer<XtaMessage> MESSAGE_PROCESSOR = this::processMessage;
final Consumer<XtaMessage> messageProcessor = this::processMessage;
@Autowired
private XtaClient xtaClient;
......@@ -77,10 +77,9 @@ class XtaService {
private XtaIncomingFilesMapper xtaIncomingFilesMapper;
@SneakyThrows
public void fetchMessages() {
public void fetchMessages() throws XtaClientException {
var transportReports = xtaClient.fetchMessages(MESSAGE_PROCESSOR);
var transportReports = xtaClient.fetchMessages(messageProcessor);
logTransportReports(transportReports);
}
......
......@@ -25,6 +25,7 @@ package de.ozgcloud.eingang.xta;
import static org.mockito.Mockito.*;
import lombok.SneakyThrows;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import org.mockito.InjectMocks;
......@@ -42,6 +43,7 @@ class XtaRunnerTest {
class TestRunGetXtaMessages {
@Test
@SneakyThrows
void shouldCallXtaServiceFetchMessages() {
scheduler.runGetXtaMessages();
......
......@@ -97,10 +97,11 @@ class XtaServiceTest {
void shouldUseMessageProcessor() {
service.fetchMessages();
verify(xtaClient).fetchMessages(service.MESSAGE_PROCESSOR);
verify(xtaClient).fetchMessages(service.messageProcessor);
}
@Test
@SneakyThrows
void shouldCallLogTransportReports() {
service.fetchMessages();
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment