OZG-5412 intelliform-adapter: Fix duplicate key

intelliform-adapter/src/main/java/de/ozgcloud/eingang/intelliform/DepositDataMapper.java

@@ -25,6 +25,7 @@ package de.ozgcloud.eingang.intelliform;
 
 import java.io.IOException;
 import java.util.Collection;
+import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -90,12 +91,14 @@ class DepositDataMapper {
 				.build();
 	}
 
-	private Map<String, IncomingFile> mapDepositAttachmentsToIncomingFiles(DepositData depositData) {
+	Map<String, IncomingFile> mapDepositAttachmentsToIncomingFiles(DepositData depositData) {
 		return depositData.getAttachments()
 				.stream()
-				.collect(
-						Collectors.toMap(Attachment::getId, this::mapAttachmentToIncomingFile)
-				);
+				.collect(Collectors.toMap(
+						Attachment::getId,
+						this::mapAttachmentToIncomingFile,
+						(u, v) -> v,
+						LinkedHashMap::new));
 	}
 
 	IncomingFile mapAttachmentToIncomingFile(Attachment attachment) {

intelliform-adapter/src/test/java/de/ozgcloud/eingang/intelliform/DepositDataMapperTest.java

@@ -136,6 +136,36 @@ class DepositDataMapperTest {
 
 	}
 
+	@DisplayName("map deposit attachments to incoming files")
+	@Nested
+	class TestMapDepositAttachmentsToIncomingFiles {
+		@DisplayName("should keep entry order")
+		@Test
+		void shouldKeepEntryOrder() {
+			var depositData = DepositDataTestFactory.create(ATTACHMENTS);
+
+			var incomingFileMap = mapper.mapDepositAttachmentsToIncomingFiles(depositData);
+
+			var keys = incomingFileMap.keySet().stream().toList();
+			assertThat(keys).containsExactly(XML_ATTACHMENT_ID, PDF_ATTACHMENT_ID, PNG_ATTACHMENT_ID);
+		}
+
+		@DisplayName("should keep last entry for duplicate key")
+		@Test
+		void shouldKeepLastEntryForDuplicateKey() {
+			var depositData = DepositDataTestFactory.create(List.of(
+					AttachmentTestFactory.createXmlDaten(),
+					AttachmentTestFactory.createPdf(),
+					AttachmentTestFactory.createXmlDaten()
+			));
+
+			var incomingFileMap = mapper.mapDepositAttachmentsToIncomingFiles(depositData);
+
+			var keys = incomingFileMap.keySet().stream().toList();
+			assertThat(keys).containsExactly(XML_ATTACHMENT_ID, PDF_ATTACHMENT_ID);
+		}
+	}
+
 	@DisplayName("map attachment to incoming file")
 	@Nested
 	class TestMapAttachmentToIncomingFile {