OZG-1929: standardize default labels, fix service monitors

templates/service.yaml

@@ -12,7 +12,7 @@ spec:
       port: 8080
       protocol: TCP
       targetPort: 8080
-    {{- if .Values.scrapeMetrics }}
+    {{- if not .Values.scrapeMetricsDisabled }}
     - name: metrics
       port: 8081
       protocol: TCP

unit-tests/deployment_defaults_labels_test.yaml

+suite: test deployment
+release:
+  name: intelliform-adapter
+  namespace: helm-test
+templates:
+  - templates/deployment.yaml
+  - templates/service_monitor.yaml
+  - templates/service.yaml
+tests:
+  - it: check default labels
+    asserts:
+      - equal:
+          path: metadata.labels.[app.kubernetes.io/instance]
+          value: intelliform-adapter
+      - equal:
+          path: metadata.labels.[app.kubernetes.io/name]
+          value: intelliform-adapter
+      - equal:
+          path: metadata.labels.[app.kubernetes.io/part-of]
+          value: kop
+      - equal:
+          path: metadata.labels.[app.kubernetes.io/namespace]
+          value: helm-test