refactoring todos for hotfix

formsolutions-adapter/src/main/java/de/itvsh/kop/eingangsadapter/formsolutions/FormSolutionsRequestMapper.java

@@ -70,9 +70,10 @@ class FormSolutionsRequestMapper {
 		}
 	}
 
+//TEST
 	private FormData removeProcessedData(FormData formData) {
 		Map<String, Object> data = formData.getFormData();
-
+//TODO immutable berucksichtigen
 		data.remove(ZIP);
 		data.remove(PDF);
 		data.remove(JSON);

semantik-adapter/src/main/java/de/itvsh/kop/eingangsadapter/semantik/SemantikAdapter.java

@@ -42,7 +42,7 @@ public class SemantikAdapter {
 	@Autowired
 	private VorgangService vorgangService;
 
-	public void processFormData(FormData formData) {
+	public void processFormDGata(FormData formData) {
 		formData = parseByEngineAdapter(formData);
 		formData = parseByFormAdapter(formData);
 

semantik-adapter/src/main/java/de/itvsh/kop/eingangsadapter/semantik/enginebased/AbstractFileMapper.java

@@ -84,6 +84,7 @@ public abstract class AbstractFileMapper implements EngineBasedMapper {
 	protected FormData removeProcessedData(FormData formData) {
 		Map<String, Object> mutableMap = new HashMap<>(formData.getFormData());
 		mutableMap.remove(MAPPED_FILES);
+		// TODO copyOf erlaubt keine null values -daher ausbauen
 		return formData.toBuilder().formData(Map.copyOf(mutableMap)).build();
 	}
 

semantik-adapter/src/main/java/de/itvsh/kop/eingangsadapter/semantik/enginebased/FormSolutionsAntragstellerMapper.java

@@ -62,6 +62,7 @@ public class FormSolutionsAntragstellerMapper implements FormSolutionsEngineBase
 				.build();
 	}
 
+	// TODO auf immutable ma umstellen
 	private Map<String, String> findAntragstellerData(Map<String, Object> formData) {
 		Map<String, String> names = new HashMap<>();
 		addContent(getPanels(formData), names);

semantik-adapter/src/main/java/de/itvsh/kop/eingangsadapter/semantik/enginebased/FormSolutionsHeaderMapper.java

@@ -51,6 +51,7 @@ public class FormSolutionsHeaderMapper implements FormSolutionsEngineBasedMapper
 	private Map<String, Object> removeTransactionId(FormData processedData) {
 		Map<String, Object> cleanedData = new HashMap<>(processedData.getFormData());
 		cleanedData.remove(TRANSACTION_ID);
+		// TODO immutable machen
 		return cleanedData;
 	}
 

semantik-adapter/src/main/java/de/itvsh/kop/eingangsadapter/semantik/enginebased/FormSolutionsPanelMapper.java

@@ -51,6 +51,8 @@ public class FormSolutionsPanelMapper implements FormSolutionsEngineBasedMapper
 	@Override
 	public FormData parseFormData(FormData formData) {
 		var res = mapPanels(getPanels(formData));
+		// TODO was passiert hier? Sieht nach dem join von zwei maps aus nur irre
+		// komilziert
 		Map<String, Object> combinedMap = Stream.concat(res.entrySet().stream(), formData.getFormData().entrySet().stream())
 				.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
 

semantik-adapter/src/main/java/de/itvsh/kop/eingangsadapter/semantik/enginebased/FormSolutionsZustaendigeStelleMapper.java

@@ -47,6 +47,7 @@ public class FormSolutionsZustaendigeStelleMapper implements FormSolutionsEngine
 	private Map<String, Object> removeZustaendigeStelle(FormData formData) {
 		var cleanedData = new HashMap<>(formData.getFormData());
 		cleanedData.remove(ZUSTAENDIGE_STELLE);
+		// TODO immutable machen
 		return cleanedData;
 	}
 }