Skip to content
Snippets Groups Projects
Commit 19d3a1f8 authored by OZGCloud's avatar OZGCloud
Browse files

OZG-4456 refactor xml mapper

parent f253fe83
No related branches found
No related tags found
No related merge requests found
...@@ -25,9 +25,6 @@ package de.ozgcloud.eingang; ...@@ -25,9 +25,6 @@ package de.ozgcloud.eingang;
import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration; import org.springframework.context.annotation.Configuration;
import org.springframework.http.converter.xml.MappingJackson2XmlHttpMessageConverter;
import com.fasterxml.jackson.dataformat.xml.XmlMapper;
import de.ozgcloud.eingang.semantik.enginebased.EngineBasedSemantikAdapter; import de.ozgcloud.eingang.semantik.enginebased.EngineBasedSemantikAdapter;
import de.ozgcloud.eingang.semantik.enginebased.afm.AfmEngineBasedAdapter; import de.ozgcloud.eingang.semantik.enginebased.afm.AfmEngineBasedAdapter;
...@@ -40,8 +37,4 @@ public class SemantikAdapterConfiguration { ...@@ -40,8 +37,4 @@ public class SemantikAdapterConfiguration {
return new AfmEngineBasedAdapter(); return new AfmEngineBasedAdapter();
} }
@Bean
public XmlMapper xmlMapper(MappingJackson2XmlHttpMessageConverter messageConverter) {
return (XmlMapper) messageConverter.getObjectMapper();
}
} }
\ No newline at end of file
package de.ozgcloud.eingang.semantik.enginebased.afm;
import org.springframework.stereotype.Component;
import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.dataformat.xml.XmlMapper;
@Component
public class XmlMapperSupplier {
private final XmlMapper xmlMapper;
public XmlMapperSupplier() {
xmlMapper = new XmlMapper();
xmlMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
}
public XmlMapper getMapper() {
return xmlMapper;
}
}
...@@ -14,8 +14,6 @@ import org.apache.commons.lang3.StringUtils; ...@@ -14,8 +14,6 @@ import org.apache.commons.lang3.StringUtils;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component; import org.springframework.stereotype.Component;
import com.fasterxml.jackson.dataformat.xml.XmlMapper;
import de.itvsh.kop.common.errorhandling.TechnicalException; import de.itvsh.kop.common.errorhandling.TechnicalException;
import de.ozgcloud.eingang.common.formdata.FormData; import de.ozgcloud.eingang.common.formdata.FormData;
import de.ozgcloud.eingang.common.formdata.IncomingFile; import de.ozgcloud.eingang.common.formdata.IncomingFile;
...@@ -41,7 +39,7 @@ public class ZustaendigeStelleMetadataMapper { ...@@ -41,7 +39,7 @@ public class ZustaendigeStelleMetadataMapper {
static final String KEY_BEHOERDE_TELEFON = "behoerde_telefon"; static final String KEY_BEHOERDE_TELEFON = "behoerde_telefon";
@Autowired @Autowired
private XmlMapper xmlMapper; private XmlMapperSupplier xmlMapperSupplier;
public FormData parseZustaendigeStelleData(FormData formData) { public FormData parseZustaendigeStelleData(FormData formData) {
return formData.getRepresentations().stream().filter(IS_BEHOERDE_METADATA).findAny() return formData.getRepresentations().stream().filter(IS_BEHOERDE_METADATA).findAny()
...@@ -57,7 +55,7 @@ public class ZustaendigeStelleMetadataMapper { ...@@ -57,7 +55,7 @@ public class ZustaendigeStelleMetadataMapper {
Optional<ZustaendigeStelleData> readXmlContent(IncomingFile metadata) { Optional<ZustaendigeStelleData> readXmlContent(IncomingFile metadata) {
try { try {
return Optional.of(xmlMapper.readValue(metadata.getContentStream(), ZustaendigeStelleData.class)); return Optional.of(xmlMapperSupplier.getMapper().readValue(metadata.getContentStream(), ZustaendigeStelleData.class));
} catch (IOException | TechnicalException e) { } catch (IOException | TechnicalException e) {
LOG.error("Error parsing {}", BEHOERDE_METADATA_FILE_NAME, e); LOG.error("Error parsing {}", BEHOERDE_METADATA_FILE_NAME, e);
} }
......
...@@ -8,11 +8,6 @@ import java.io.File; ...@@ -8,11 +8,6 @@ import java.io.File;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.http.converter.xml.MappingJackson2XmlHttpMessageConverter;
import com.fasterxml.jackson.dataformat.xml.XmlMapper;
import de.itvsh.kop.common.test.ITCase; import de.itvsh.kop.common.test.ITCase;
import de.itvsh.kop.common.test.TestUtils; import de.itvsh.kop.common.test.TestUtils;
...@@ -53,12 +48,3 @@ class ZustaendigeStelleMetadataMapperITCase { ...@@ -53,12 +48,3 @@ class ZustaendigeStelleMetadataMapperITCase {
assertThat(zustaendigeStelleData).isEmpty(); assertThat(zustaendigeStelleData).isEmpty();
} }
} }
\ No newline at end of file
@Configuration
class TestConfiguration {
@Bean
public XmlMapper xmlMapper(MappingJackson2XmlHttpMessageConverter messageConverter) {
return (XmlMapper) messageConverter.getObjectMapper();
}
}
\ No newline at end of file
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment