Skip to content
Snippets Groups Projects
Commit 80c38ac5 authored by Krzysztof Witukiewicz's avatar Krzysztof Witukiewicz
Browse files

OZG-7262 OZG-7584 Attachments should not be null

parent b89a8f8f
No related branches found
No related tags found
1 merge request!6Ozg 7262 attarchments not null
...@@ -44,8 +44,6 @@ import net.devh.boot.grpc.server.service.GrpcService; ...@@ -44,8 +44,6 @@ import net.devh.boot.grpc.server.service.GrpcService;
@RequiredArgsConstructor @RequiredArgsConstructor
class ExportGrpcService extends ExportServiceImplBase { class ExportGrpcService extends ExportServiceImplBase {
static final int CHUNK_SIZE = 256 * 1024;
private final ExportService exportService; private final ExportService exportService;
private final TaskExecutor taskExecutor; private final TaskExecutor taskExecutor;
......
...@@ -29,6 +29,7 @@ import java.util.List; ...@@ -29,6 +29,7 @@ import java.util.List;
import de.ozgcloud.common.binaryfile.FileId; import de.ozgcloud.common.binaryfile.FileId;
import lombok.Builder; import lombok.Builder;
import lombok.Getter; import lombok.Getter;
import lombok.Singular;
@Builder @Builder
@Getter @Getter
...@@ -37,5 +38,6 @@ public class Kommentar { ...@@ -37,5 +38,6 @@ public class Kommentar {
private String text; private String text;
private ZonedDateTime createdAt; private ZonedDateTime createdAt;
private String createdBy; private String createdBy;
@Singular
private List<FileId> attachments; private List<FileId> attachments;
} }
...@@ -27,6 +27,7 @@ import java.util.Map; ...@@ -27,6 +27,7 @@ import java.util.Map;
import java.util.Objects; import java.util.Objects;
import org.mapstruct.Mapper; import org.mapstruct.Mapper;
import org.mapstruct.Mapping;
import org.mapstruct.NullValueCheckStrategy; import org.mapstruct.NullValueCheckStrategy;
import org.mapstruct.ReportingPolicy; import org.mapstruct.ReportingPolicy;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
...@@ -55,6 +56,7 @@ abstract class KommentarMapper { ...@@ -55,6 +56,7 @@ abstract class KommentarMapper {
return grpcObjectMapper.mapFromGrpc(item); return grpcObjectMapper.mapFromGrpc(item);
} }
@Mapping(target = "attachment", ignore = true)
abstract Kommentar mapItemMapToKommentar(Map<String, Object> map); abstract Kommentar mapItemMapToKommentar(Map<String, Object> map);
String mapObjectToString(Object object) { String mapObjectToString(Object object) {
......
...@@ -145,6 +145,9 @@ class KommentarMapperTest { ...@@ -145,6 +145,9 @@ class KommentarMapperTest {
@Nested @Nested
class TestMapItemMapToKommentar { class TestMapItemMapToKommentar {
@Nested
class OnAllFieldsSet {
@BeforeEach @BeforeEach
void init() { void init() {
doReturn(KommentarTestFactory.ID).when(mapper).mapObjectToString(KommentarTestFactory.ID); doReturn(KommentarTestFactory.ID).when(mapper).mapObjectToString(KommentarTestFactory.ID);
...@@ -243,6 +246,18 @@ class KommentarMapperTest { ...@@ -243,6 +246,18 @@ class KommentarMapperTest {
} }
} }
@Nested
class OnAttachmentsMissing {
@Test
void shouldSetToEmptyCollection() {
var kommentar = mapper.mapItemMapToKommentar(Map.of());
assertThat(kommentar.getAttachments()).isEmpty();
}
}
}
@Nested @Nested
class TestMapObjectToString { class TestMapObjectToString {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment