OZG-2792 Refactoring nach PR Review, Unit Tests hinzufügen

goofy-client/libs/tech-shared/test/error.ts

@@ -30,8 +30,7 @@ export function createError(): unknown {
 }
 
 export function createHttpErrorResponse(apiError: ApiError = null): HttpErrorResponse {
-	return {
-		...<HttpErrorResponse>{},
+	return <HttpErrorResponse>{
 		error: {
 			error: apiError ?? createApiError()
 		}

goofy-client/libs/vorgang-shared/src/lib/+state/vorgang.effects.spec.ts

-import { HttpErrorResponse } from '@angular/common/http';
+import { HttpErrorResponse, HttpStatusCode } from '@angular/common/http';
 import { TestBed } from '@angular/core/testing';
 import { ApiRootFacade, ApiRootLinkRel, ApiRootResource } from '@goofy-client/api-root-shared';
 import { NavigationFacade } from '@goofy-client/navigation-shared';
@@ -274,4 +274,34 @@ describe('VorgangEffects', () => {
 			expect(effects.searchForPreview$).toBeObservable(expected);
 		})
 	})
+
+	describe('search error', () => {
+		const action = VorgangActions.searchForPreviewFailure({ httpErrorResponse: null });
+		const error: HttpErrorResponse = createHttpErrorResponse();
+
+		it('should trigger showSearchError$', () => {
+			actions = of(action);
+			effects.showSearchError = jest.fn();
+
+			effects.showSearchError$.subscribe();
+
+			expect(effects.showSearchError).toHaveBeenCalled();
+		})
+
+		it('should call snackbarService.showError if HTTP status code is NOT 503 ', () => {
+			error.error.status = HttpStatusCode.ExpectationFailed;
+
+			effects.showSearchError(error);
+
+			expect(snackbarService.showError).not.toHaveBeenCalled();
+		})
+
+		it('should call snackbarService.showError if HTTP status code is 503 ', () => {
+			error.error.status = HttpStatusCode.ServiceUnavailable;
+
+			effects.showSearchError(error);
+
+			expect(snackbarService.showError).toHaveBeenCalled();
+		})
+	})
 });
\ No newline at end of file

goofy-client/libs/vorgang-shared/src/lib/+state/vorgang.effects.ts

@@ -12,7 +12,7 @@ import { getSearchLinkRel } from '../vorgang-navigation.util';
 import { VorgangMessages } from '../vorgang.messages';
 import { VorgangRepository } from '../vorgang.repository';
 import * as VorgangActions from './vorgang.actions';
-import { ApiRootAction, SearchVorgaengeByProps } from './vorgang.actions';
+import { ApiRootAction, HttpErrorAction, SearchVorgaengeByProps } from './vorgang.actions';
 import * as VorgangSelectors from './vorgang.selectors';
 
 @Injectable()
@@ -84,11 +84,11 @@ export class VorgangEffects {
 				VorgangActions.searchForPreviewFailure,
 				VorgangActions.searchVorgaengeByFailure
 			),
-			map(({ httpErrorResponse }) => this.showSearchError(httpErrorResponse)),
+			map((action: HttpErrorAction) => this.showSearchError(action.httpErrorResponse)),
 		), { dispatch: false }
 	);
 
-	private showSearchError(error: HttpErrorResponse): void {
+	showSearchError(error: HttpErrorResponse): void {
 		if (isServiceUnavailable(error.error.status)) {
 			this.snackbarService.showError(VorgangMessages.SEARCH_UNAVAILABLE);
 		}