OZG-2737 Tests hinzugefügt, PR Kommentar bearbeitet

goofy-server/src/test/java/de/itvsh/goofy/RootControllerTest.java

@@ -110,7 +110,7 @@ class RootControllerTest {
 			}
 
 			@Test
-			void shoulHaveMyVorgaengeLink() {
+			void shouldHaveMyVorgaengeLink() {
 				var model = controller.getRootResource();
 
 				assertThat(model.getLink(RootController.REL_MY_VORGAENGE)).isPresent().get().extracting(Link::getHref)
@@ -118,7 +118,7 @@ class RootControllerTest {
 			}
 
 			@Test
-			void shoulHaveSearchMyVorgaengeLink() {
+			void shouldHaveSearchMyVorgaengeLink() {
 				var model = controller.getRootResource();
 
 				assertThat(model.getLink(RootController.REL_SEARCH_MY_VORGAENGE)).isPresent().get().extracting(Link::getHref)
@@ -126,7 +126,7 @@ class RootControllerTest {
 			}
 
 			@Test
-			void shoulHaveDownloadTokenLink() {
+			void shouldHaveDownloadTokenLink() {
 				var model = controller.getRootResource();
 
 				assertThat(model.getLink(RootController.REL_DOWNLOAD_TOKEN)).isPresent().get().extracting(Link::getHref)
@@ -254,6 +254,31 @@ class RootControllerTest {
 				}
 			}
 
+			@DisplayName("when external Id cannot resolved to internal id")
+			@Nested
+			class NoInternalUserId {
+				@BeforeEach
+				void init() {
+					doReturn(true).when(controller).hasVerwaltungRole();
+					when(controller.getUserProfilesUrl()).thenReturn(Optional.of("http://localhost/api/userProfiles/%s"));
+					when(internalUserIdService.getUserId(any())).thenReturn(Optional.empty());
+				}
+
+				@Test
+				void shouldNotHaveMyVorgaengeLink() {
+
+					var model = controller.getRootResource();
+
+					assertThat(model.getLink(RootController.REL_MY_VORGAENGE)).isNotPresent();
+				}
+
+				@Test
+				void shouldNotHaveSearchMyVorgaengeLink() {
+					var model = controller.getRootResource();
+
+					assertThat(model.getLink(RootController.REL_SEARCH_MY_VORGAENGE)).isNotPresent();
+				}
+			}
 		}
 	}
 

goofy-server/src/test/java/de/itvsh/goofy/common/user/InternalUserIdServiceTest.java

@@ -12,7 +12,7 @@ import org.mockito.Spy;
 import org.springframework.web.client.RestClientException;
 import org.springframework.web.client.RestTemplate;
 
-public class InternalUserIdServiceTest {
+class InternalUserIdServiceTest {
 
 	@Spy
 	@InjectMocks