Skip to content
Snippets Groups Projects
Commit 84ae6dda authored by OZGCloud's avatar OZGCloud
Browse files

OZG-1523 Unnötiges mappen der vogangId bei Kommentar entfernt

parent 0741448b
No related branches found
No related tags found
No related merge requests found
......@@ -19,7 +19,6 @@ public interface KommentarMapper {
static final String TEXT = "text";
static final String CREATED_BY = "createdBy";
static final String CREATED_AT = "createdAt";
static final String VORGANG_ID = "vorgangId";
@Mapping(target = "kommentar", ignore = true)
@ValueMapping(source = "UNRECOGNIZED", target = MappingConstants.NULL)
......@@ -32,7 +31,6 @@ public interface KommentarMapper {
.createdAt(ZonedDateTime.parse((String) map.get(CREATED_AT)))
.createdBy((String) map.get(CREATED_BY))
.text((String) map.get(TEXT))
.vorgangId((String) map.get(VORGANG_ID))
.build();
}
}
......@@ -107,7 +107,7 @@ class KommentarCommandControllerTest {
void init() {
mockMvc = MockMvcBuilders.standaloneSetup(controller).build();
when(commandByRelationController.createCommand(any(), anyString())).thenReturn(CommandTestFactory.create());
when(service.getById(any())).thenReturn(KommentarTestFactory.create());
when(service.getById(any())).thenReturn(KommentarTestFactory.createBuilder().vorgangId(VorgangHeaderTestFactory.ID).build());
}
@Test
......
......@@ -39,14 +39,6 @@ class KommentarMapperTest {
assertThat(kommentar.getText()).isEqualTo(KommentarTestFactory.TEXT);
}
@Test
void shouldMapVorgangID() {
var kommentar = map();
assertThat(kommentar.getVorgangId()).isEqualTo(KommentarTestFactory.VORGANG_ID);
}
}
private Kommentar map() {
......
......@@ -8,7 +8,6 @@ import com.thedeanda.lorem.Lorem;
import com.thedeanda.lorem.LoremIpsum;
import de.itvsh.goofy.common.user.UserProfileTestFactory;
import de.itvsh.goofy.vorgang.VorgangHeaderTestFactory;
public class KommentarTestFactory {
......@@ -22,8 +21,6 @@ public class KommentarTestFactory {
public static final String TEXT = lorem.getWords(15);
public static final String VORGANG_ID = VorgangHeaderTestFactory.ID;
public static Kommentar create() {
return createBuilder().build();
}
......@@ -33,8 +30,7 @@ public class KommentarTestFactory {
.id(ID)
.text(TEXT)
.createdBy(CREATED_BY)
.createdAt(CREATED_AT)
.vorgangId(VORGANG_ID);
.createdAt(CREATED_AT);
}
public static Map<String, Object> createAsMap() {
......@@ -42,7 +38,6 @@ public class KommentarTestFactory {
KommentarMapper.ID, ID,
KommentarMapper.TEXT, TEXT,
KommentarMapper.CREATED_BY, CREATED_BY,
KommentarMapper.CREATED_AT, CREATED_AT_STR,
KommentarMapper.VORGANG_ID, VORGANG_ID);
KommentarMapper.CREATED_AT, CREATED_AT_STR);
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment