Client: clean up some sonar issues

goofy-client/apps/goofy/src/app/app.component.ts

@@ -49,7 +49,7 @@ export class AppComponent implements OnInit {
 	}
 
 	private buildConfiguration(): AuthConfig {
-		const authConfig: AuthConfig = {
+		return {
 			// Url of the Identity Provider
 			issuer: this.envConfig.authServer + '/realms/' + this.envConfig.realm,
 
@@ -68,8 +68,6 @@ export class AppComponent implements OnInit {
 			scope: 'openid profile email',
 			requireHttps: false
 		};
-
-		return authConfig;
 	}
 }
 

goofy-client/apps/goofy/src/environments/environment.ts

@@ -2,9 +2,6 @@
 // `ng build --prod` replaces `environment.ts` with `environment.prod.ts`.
 // The list of file replacements can be found in `angular.json`.
 
-import { isFakeMousedownFromScreenReader } from '@angular/cdk/a11y';
-import { Environment } from 'libs/environment-shared/src/lib/environment.model';
-
 export const environment = {
 	production: false,
 	environmentUrl: null

goofy-client/libs/command-shared/src/lib/command.service.ts

@@ -16,7 +16,7 @@ export class CommandService {
 
 	public createCommand(resource: Resource, linkRel: string, command: CreateCommand): Observable<StateResource<CommandResource>> {
 		return this.repository.createCommand(resource, linkRel, command).pipe(
-			mergeMap(command => this.startPolling(command)),
+			mergeMap(createdCommand => this.startPolling(createdCommand)),
 			catchError(apiError => of(createErrorStateResource(apiError))) //TODO only status code 422
 		);
 	}

goofy-client/libs/environment-shared/src/lib/environment.model.ts

@@ -3,6 +3,6 @@ import { ResourceUri } from '@ngxp/rest/lib/resource.model';
 export interface Environment {
 	production: boolean,
 	remoteHost: ResourceUri,
-	authServer: String,
-	realm: String
+	authServer: string,
+	realm: string
 }
\ No newline at end of file

goofy-client/libs/forwarding-shared/src/lib/forwarding.model.ts

@@ -10,6 +10,6 @@ export interface Forwarding {
 	createdByName: string;
 }
 
-export interface ForwardingResource extends Forwarding, Resource { };
+export interface ForwardingResource extends Forwarding, Resource { }
 
 export interface ForwardingListResource extends ListResource { }
\ No newline at end of file

goofy-client/libs/forwarding/src/lib/vorgang-forwarding-container/vorgang-forward-formular/vorgang-forward-form/vorgang-forward.formservice.ts

@@ -25,7 +25,7 @@ export class VorgangForwardFormService extends AbstractFormService {
 	}
 
 	protected initForm(): FormGroup {
-		return this.form = this.formBuilder.group({
+		return this.formBuilder.group({
 			[VorgangForwardFormService.FIELD_EMAIL]: new FormControl(),
 			[VorgangForwardFormService.FIELD_PASSWORD]: new FormControl()
 		})

goofy-client/libs/kommentar-shared/src/lib/kommentar.service.ts

-import { Injectable } from "@angular/core";
-import { Params } from "@angular/router";
-import { CommandResource, CommandService, CreateCommand, isDone } from "@goofy-client/command-shared";
-import { createEmptyStateResource, createStateResource, doIfLoadingRequired, NavigationService, StateResource } from "@goofy-client/tech-shared";
-import { VorgangResource, VorgangService } from "@goofy-client/vorgang-shared";
-import { Resource } from "@ngxp/rest";
-import { isNil } from "lodash";
-import { BehaviorSubject, Observable, Subscription } from "rxjs";
-import { startWith, tap } from "rxjs/operators";
-import { KommentarLinkRel, KommentarListLinkRel } from "./kommentar.linkrel";
-import { CreateKommentarCommand, Kommentar, KommentarListResource, KommentarOrder, KommentarResource } from "./kommentar.model";
-import { KommentarRepository } from "./kommentar.repository";
+import { Injectable } from '@angular/core';
+import { Params } from '@angular/router';
+import { CommandResource, CommandService, CreateCommand, isDone } from '@goofy-client/command-shared';
+import { createEmptyStateResource, createStateResource, doIfLoadingRequired, NavigationService, StateResource } from '@goofy-client/tech-shared';
+import { VorgangResource, VorgangService } from '@goofy-client/vorgang-shared';
+import { Resource } from '@ngxp/rest';
+import { isNil } from 'lodash';
+import { BehaviorSubject, Observable, Subscription } from 'rxjs';
+import { startWith, tap } from 'rxjs/operators';
+import { KommentarLinkRel, KommentarListLinkRel } from './kommentar.linkrel';
+import { CreateKommentarCommand, Kommentar, KommentarListResource, KommentarOrder, KommentarResource } from './kommentar.model';
+import { KommentarRepository } from './kommentar.repository';
 
 @Injectable({ providedIn: 'root' })
 export class KommentarService {
@@ -99,7 +99,7 @@ export class KommentarService {
 
 	createKommentarCommand(resource: Resource, linkRel: string, command: CreateCommand): Observable<StateResource<CommandResource>> {
 		return this.commandService.createCommand(resource, linkRel, command).pipe(
-			tap((command: StateResource<CommandResource>) => this.afterCreateOrEditKommentar(command)),
+			tap((createdCommand: StateResource<CommandResource>) => this.afterCreateOrEditKommentar(createdCommand)),
 			startWith(createEmptyStateResource<CommandResource>(true)));
 	}
 

goofy-client/libs/tech-shared/src/lib/tech.util.ts

 export function getBaseUrl(): string {
 	const { protocol, host, } = window.location;
 	const basePath = `${protocol}//${host}`;
-	const url = basePath.endsWith('/') ? `${basePath}` : `${basePath}/`;
-	return url;
+	return basePath.endsWith('/') ? `${basePath}` : `${basePath}/`;
 }
 
 export function isEmptyObject(obj: any): boolean {

goofy-client/libs/tech-shared/src/lib/validation/tech.validation.util.ts

@@ -8,14 +8,14 @@ export function isValidationError(issue: Issue): boolean {
 	return issue.messageCode.includes('javax.validation.constraints')
 }
 
-export function setValidationError(form: FormGroup, issue: Issue, pathPrefix?: String) {
+export function setValidationError(form: FormGroup, issue: Issue, pathPrefix?: string) {
 	const control = getControlForIssue(form, issue, pathPrefix);
 
 	control.setErrors({ [issue.messageCode]: issue });
 	control.markAsTouched();
 }
 
-export function getControlForIssue(form: FormGroup, issue: Issue, pathPrefix?: String): AbstractControl {
+export function getControlForIssue(form: FormGroup, issue: Issue, pathPrefix?: string): AbstractControl {
 	const fieldPath = pathPrefix ? issue.field.substr(pathPrefix.length + 1) : issue.field;
 
 	let curControl: AbstractControl = form;

goofy-client/libs/ui/src/lib/ui/validation-error/validation-error.component.ts

@@ -11,8 +11,6 @@ export class ValidationErrorComponent {
 	@Input() label: string;
 	@Input() issues: Issue[];
 
-	constructor() { }
-
 	message(issue: Issue): string {
 		return getMessageForIssue(this.label, issue);
 	}

goofy-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-area/vorgang-detail-area.component.ts

@@ -10,8 +10,7 @@ import { VorgangHeaderLinkRel, VorgangWithEingangLinkRel, VorgangWithEingangReso
 export class VorgangDetailAreaComponent {
 
 	@Input() vorgangStateResource: StateResource<VorgangWithEingangResource>;
+
 	readonly linkRel = VorgangHeaderLinkRel;
 	readonly vorgangWithEingangLinkRel = VorgangWithEingangLinkRel;
-
-	constructor() {}
 }
\ No newline at end of file

goofy-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-area/vorgang-detail-body/antragsteller/antragsteller.component.ts

-import { Component, Input, OnInit } from '@angular/core';
+import { Component, Input } from '@angular/core';
 import { Antragsteller } from '@goofy-client/vorgang-shared';
 
 @Component({
@@ -9,5 +9,4 @@ import { Antragsteller } from '@goofy-client/vorgang-shared';
 export class AntragstellerComponent {
 
 	@Input() antragsteller: Antragsteller;
-
 }
\ No newline at end of file

goofy-client/libs/vorgang-shared/src/lib/vorgang-command.service.ts

@@ -129,8 +129,8 @@ export class VorgangCommandService {
 	private handleRevokeCommand(commandResource: CommandResource): void {
 		this.revokeCommand$.next(createEmptyStateResource(true));
 
-		const subscription: Subscription = this.commandService.revokeCommand(commandResource).subscribe(commandResource => {
-			this.proceedWithRevokeCommand(commandResource);
+		const subscription: Subscription = this.commandService.revokeCommand(commandResource).subscribe(command => {
+			this.proceedWithRevokeCommand(command);
 			subscription.unsubscribe();
 		});
 	}