CHANGELOG.md

@@ -5,11 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [2.5.1] - 2025-02-13
 
 ### Fixed
 
 - Corrected `_parse_distributions` of `ODSHDCATdeProfile` to not rely on resource dict, fixing missing `id` errors.
+- Resolved an issue where harvested datasets were incorrectly required to have a category set, even when the configuration variable `ckanext.odsh.require_at_least_one_category` was set to false.
 
 ## [2.5.0] - 2025-01-30
 

ckanext/odsh/i18n/ckanext-odsh.pot

@@ -6,7 +6,7 @@
 #, fuzzy
 msgid ""
 msgstr ""
-"Project-Id-Version: ckanext-odsh 2.5.0\n"
+"Project-Id-Version: ckanext-odsh 2.5.1\n"
 "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
 "POT-Creation-Date: 2024-09-20 11:17+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"

ckanext/odsh/validation.py

@@ -32,7 +32,7 @@ def validate_extra_groups(data, requireAtLeastOne, errors):
     log.debug("Validating extra_groups")
     value = _extract_value(data, 'groups')
     error_message_no_group = 'at least one group needed'
-    if value != None:
+    if value is not None:
         # 'value != None' means the extra key 'groups' was found,
         # so the dataset came from manual editing via the web-frontend.
         if not value:
@@ -55,7 +55,7 @@ def validate_extra_groups(data, requireAtLeastOne, errors):
             data[('groups', num, 'id')] = group
     else:  # no extra-field 'groups'
         # dataset might come from a harvest process
-        if not data.get(('groups', 0, 'id'), False) and \
+        if requireAtLeastOne and not data.get(('groups', 0, 'id'), False) and \
            not data.get(('groups', 0, 'name'), False):
             errors['groups'] = error_message_no_group
 

setup.py

@@ -15,7 +15,7 @@ setup(
     # Versions should comply with PEP440.  For a discussion on single-sourcing
     # the version across setup.py and the project code, see
     # http://packaging.python.org/en/latest/tutorial.html#version
-    version='2.5.0',
+    version='2.5.1',
 
     description='''A general extension for CKAN that is used for the Open Data Schleswig-Holstein project''',
     long_description=long_description,