Skip to content
Snippets Groups Projects

Ozg 7573 files weiterleitung bug

Merged Krzysztof Witukiewicz requested to merge OZG-7573-files-weiterleitung-bug into main
2 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Felix Reichenbach
  • Felix Reichenbach
  • added 2 commits

    • 0317820e - OZG-7573 OZG-7991 Mark FileSender-class deprecated
    • a0d677b3 - OZG-7573 OZG-7991 Move cancelOnTimeout() and cancelOnError() to StreamingFileSender

    Compare with previous version

  • added 4 commits

    • fbceb901 - OZG-7573 OZG-7991 Rename methode closeStreams()
    • 83a363dd - OZG-7573 OZG-7991 Remove comment
    • 36622779 - OZG-7573 OZG-7991 Verify calling endTransfer() in test
    • 7b7c478d - OZG-7573 OZG-7991 Improve formatting

    Compare with previous version

  • Krzysztof Witukiewicz left review comments

    left review comments

  • 52 requestObserver = reqObserverBuilder.apply(responseObserver);
    53
    54 return this;
    55 }
    56
    57 @Override
    58 void communicateEndOfTransfer() {
    59 requestObserver.onCompleted();
    60 }
    61
    62 @Override
    63 protected CallStreamObserver<Q> getRequestObserver() {
    64 return requestObserver;
    65 }
    66
    67 public void cancelOnTimeout() {
  • 57 @Override
    58 void communicateEndOfTransfer() {
    59 requestObserver.onCompleted();
    60 }
    61
    62 @Override
    63 protected CallStreamObserver<Q> getRequestObserver() {
    64 return requestObserver;
    65 }
    66
    67 public void cancelOnTimeout() {
    68 super.cancelOnTimeout();
    69 requestObserver.onError(new TechnicalException("Timeout on waiting for upload."));
    70 }
    71
    72 public void cancelOnError(Throwable t) {
  • added 1 commit

    • 8f8039e7 - OZG-7573 OZG-7991 Fix spelling

    Compare with previous version

  • added 2 commits

    • 8e5eefbd - OZG-7573 OZG-7991 Stop if cancelled
    • bea6456c - OZG-7573 OZG-7991 Fix sonarqube warnings

    Compare with previous version

  • Felix Reichenbach approved this merge request

    approved this merge request

  • mentioned in commit 7c8cf453

  • Please register or sign in to reply
    Loading