Skip to content
Snippets Groups Projects

Ozg 7689 erweitern

Open Tobias Bruns requested to merge OZG-7689_erweitern into main
9 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
31 31 <parent>
32 32 <groupId>de.ozgcloud.common</groupId>
33 33 <artifactId>ozgcloud-common-parent</artifactId>
34 <version>4.9.0</version>
34 <version>4.10.0</version>
  • 1 {
  • 1 {
    2 "vorgangId": "%s",
    3 "action": "CREATE_AKTENNOTIZ",
    4 "body": {
    5 "vorgangId": "%s",
    6 "severity": "INFO",
    7 "headline": "Headline",
    8 "text": "Text",
    9 "new": "unkown"
  • 1 package de.ozgcloud.processor.command;
    2
    3 import org.springframework.stereotype.Service;
    4
    5 import de.ozgcloud.vorgang.grpc.command.CommandServiceGrpc.CommandServiceBlockingStub;
    6 import de.ozgcloud.vorgang.grpc.command.GrpcGetCommandRequest;
    7 import lombok.RequiredArgsConstructor;
    8 import net.devh.boot.grpc.client.inject.GrpcClient;
    9
    10 @Service("processorManagerCommandService")
    • Wir hatten uns mal darauf geeinigt, die spefizischen Namen der Beans die geändert werden müssen, in eine Klasse zu packen (*Application | *Configuration).

      -> siehe CollaborationManagerConfiguration

      Unabhängig davon würde ich dann zumindest unserer aktuellen Konvention folgen wollen, in dem Fall wäre das "processor_commandRemoteService" - Managername ohne das Manager Suffix + _ + Beanname.

    • Please register or sign in to reply
  • 1 package de.ozgcloud.processor.command;
    2
    3 import java.util.Objects;
    4
    5 import org.mapstruct.Mapper;
    6 import org.mapstruct.Mapping;
    7
    8 import de.ozgcloud.processor.vorgang.VorgangId;
    9 import de.ozgcloud.vorgang.grpc.command.GrpcCommand;
    10
    11 @Mapper
    12 interface ProcessorManagerCommandMapper {
  • 1 package de.ozgcloud.processor.command;
    2
    3 import org.springframework.stereotype.Service;
    4
    5 import de.ozgcloud.vorgang.grpc.command.CommandServiceGrpc.CommandServiceBlockingStub;
    6 import de.ozgcloud.vorgang.grpc.command.GrpcGetCommandRequest;
    7 import lombok.RequiredArgsConstructor;
    8 import net.devh.boot.grpc.client.inject.GrpcClient;
    9
    10 @Service("processorManagerCommandService")
    11 @RequiredArgsConstructor
    12 class CommandRemoteService {
    13
    14 @GrpcClient("command-manager")
    15 private final CommandServiceBlockingStub commandServiceStub;
  • 14 @Spy
    15 @InjectMocks
    16 private EventService service;
    17
    18 @Nested
    19 class TestGetEventName {
    20
    21 @Test
    22 void shouldReturnEventName() {
    23 var result = service.getEventNameFromOrder(CommandTestFactory.createBuilder().order("VORGANG_ANNEHMEN").build());
    24
    25 assertThat(result).contains("ANGENOMMEN");
    26 }
    27
    28 @Test
    29 void shouldReturnEmptyForUnkown() {
  • 135 136 void shouldAddExceptionId() {
    136 137 var exceptionId = "exceptionId";
    137 138
    138 var errorText = factory.buildErrorText("", exceptionId);
    139 var errorText = factory.buildErrorText("", exceptionId, "");
  • 1 /*
    2 * Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den
  • Martin Küster left review comments

    left review comments

  • Please register or sign in to reply
    Loading