Skip to content
Snippets Groups Projects

Ozg 7942 fix performance issues

Open Tobias Bruns requested to merge OZG-7942_fix_performance_issues into main
3 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
98 100 return userService.getUser().getOrganisationseinheitIds();
99 101 }
100 102
103 @Timed("vorgang_isVorgangEditable")
101 104 public boolean isVorgangEditable(Vorgang vorgang) {
102 var vorgangWithEingang = vorgang instanceof VorgangWithEingang ?
103 (VorgangWithEingang) vorgang :
104 findVorgangWithEingang(vorgang.getId());
105 return isVorgangWithEingangEditable(vorgangWithEingang);
105 if (vorgang instanceof VorgangWithEingang withEingang) {
106 return isVorgangWithEingangEditable(withEingang);
107 }
108 return false;
  • added 1 commit

    • b008e2ae - OZG-7942 adjust method order

    Compare with previous version

  • 375
    376 371 @Test
    377 void shouldFindVorgangWithEingang() {
    378 service.isVorgangEditable(vorgang);
    372 void shouldReturnFalseForVorgangHeader() {
    373 var result = service.isVorgangEditable(vorgang);
    379 374
    380 verify(service).findVorgangWithEingang(VorgangHeaderTestFactory.ID);
    375 verify(service, never()).findVorgangWithEingang(VorgangHeaderTestFactory.ID);
    376 assertThat(result).isFalse();
    381 377 }
    382 378
    383 379 @Test
    384 380 void shouldCheckIfVorgangIsEditable() {
    385 service.isVorgangEditable(vorgang);
    381 service.isVorgangEditable(vorgangWithEingang);
  • 390 386 @ParameterizedTest
    391 387 @ValueSource(booleans = { true, false })
    392 388 void shouldReturnCheckResult(boolean checkResult) {
    393 when(service.isVorgangWithEingangEditable(vorgangWithEingang)).thenReturn(checkResult);
    389 doReturn(checkResult).when(service).isVorgangEditable(any());
    Please register or sign in to reply
    Loading