From 37b3b00e818bdfcceb64c8de0cf2743b619b66dc Mon Sep 17 00:00:00 2001
From: Benjamin Becker <benjamin.becker@dataport.de>
Date: Fri, 26 Jun 2020 08:48:25 +0000
Subject: [PATCH] fixes unit tests
---
ckanext/odsh/tests_tpsh/test_thumbnail.py | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/ckanext/odsh/tests_tpsh/test_thumbnail.py b/ckanext/odsh/tests_tpsh/test_thumbnail.py
index 4cc6eea9..f12f0cbd 100644
--- a/ckanext/odsh/tests_tpsh/test_thumbnail.py
+++ b/ckanext/odsh/tests_tpsh/test_thumbnail.py
@@ -181,8 +181,8 @@ class TestWriteThumbnailIntoPackage(object):
call('package_update')
])
p.mock_action_handler.assert_has_calls([
- call(self.context, {'id': 'foo'}),
- call(self.context, {'id': 'foo', 'thumbnail': 'filename'})
+ call(None, {'id': 'foo'}),
+ call(None, {'id': 'foo', 'thumbnail': 'filename'})
])
@p.patch_get_action
@@ -193,8 +193,8 @@ class TestWriteThumbnailIntoPackage(object):
call('package_update')
])
p.mock_action_handler.assert_has_calls([
- call(self.context, {'id': 'foo'}),
- call(self.context, {'id': 'foo'})
+ call(None, {'id': 'foo'}),
+ call(None, {'id': 'foo'})
])
@@ -218,6 +218,7 @@ class TestCreateThumbnailIfNoneInPackage(object):
@p.patch_get_package_dict_from_context
def test_creates_thumbnail_for_first_resource(self, patch_gpdfc, patch_ct, patch_ga):
patch_ct.side_effect = [(True, 'filename1'), (True, 'filename2')]
+ patch_gpdfc.return_value = {}
thumbnail.create_thumbnail_if_none_in_package(self.context, ['resource1', 'resource2'])
patch_ct.assert_called_once_with(self.context, 'resource1')
@@ -226,6 +227,7 @@ class TestCreateThumbnailIfNoneInPackage(object):
@p.patch_get_package_dict_from_context
def test_creates_thumbnail_for_first_pdf(self, patch_gpdfc, patch_ct, patch_ga):
patch_ct.side_effect = [(False, 'filename1'), (True, 'filename2'), (True, 'filename3')]
+ patch_gpdfc.return_value = {}
thumbnail.create_thumbnail_if_none_in_package(self.context, ['resource1', 'resource2', 'resource3'])
patch_ct.assert_called_with(self.context, 'resource2')
@@ -243,6 +245,7 @@ class TestCreateThumbnailIfNoneInPackage(object):
@p.patch_create_thumbnail
@p.patch_get_package_dict_from_context
def test_does_not_create_thumbnail_if_no_resources(self, patch_gpdfc, patch_ct, patch_ga):
+ patch_gpdfc.return_value = {}
thumbnail.create_thumbnail_if_none_in_package(self.context, [])
patch_ct.assert_not_called()
@@ -252,6 +255,7 @@ class TestCreateThumbnailIfNoneInPackage(object):
@p.patch_get_package_dict_from_context
def test_writes_filename_into_package(self, patch_gpdfc, patch_ct, patch_ga, patch_wtip):
patch_ct.side_effect = [(True, 'filename1'), (True, 'filename2')]
+ patch_gpdfc.return_value = {}
thumbnail.create_thumbnail_if_none_in_package(self.context, ['resource1'])
patch_wtip.assert_called_once_with(self.context, 'filename1')
--
GitLab