From 0d7f2e8ec62fb2e180ce8511b9afa0ce206c6624 Mon Sep 17 00:00:00 2001
From: Lukas Malte Monnerjahn <lukasmalte.monnerjahn@dataport.de>
Date: Mon, 9 Sep 2024 12:43:01 +0200
Subject: [PATCH] OZG-6239 add XtaMessageRepositoryTest::shouldDeleteMessage
also code style
---
.../xta/test/app/data/XtaMessageRepositoryTest.java | 7 +++++++
.../test/app/factory/XtaGetMessageRequestTestFactory.java | 2 +-
.../xta/test/app/service/XtaMessageServiceTest.java | 4 ++--
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/test/java/de/ozgcloud/xta/test/app/data/XtaMessageRepositoryTest.java b/src/test/java/de/ozgcloud/xta/test/app/data/XtaMessageRepositoryTest.java
index 69a7aef..af7fe1a 100644
--- a/src/test/java/de/ozgcloud/xta/test/app/data/XtaMessageRepositoryTest.java
+++ b/src/test/java/de/ozgcloud/xta/test/app/data/XtaMessageRepositoryTest.java
@@ -87,6 +87,13 @@ public class XtaMessageRepositoryTest {
xtaMessageRepository.save(message);
}
+ @Test
+ void shouldDeleteMessage() {
+ xtaMessageRepository.delete(MESSAGE_ID);
+
+ assertThat(xtaMessageRepository.get(MESSAGE_ID)).isEmpty();
+ }
+
@Test
void shouldDeleteTemporaryFiles() {
assertThat(messageFile.file()).exists();
diff --git a/src/test/java/de/ozgcloud/xta/test/app/factory/XtaGetMessageRequestTestFactory.java b/src/test/java/de/ozgcloud/xta/test/app/factory/XtaGetMessageRequestTestFactory.java
index ae594bb..0e3426c 100644
--- a/src/test/java/de/ozgcloud/xta/test/app/factory/XtaGetMessageRequestTestFactory.java
+++ b/src/test/java/de/ozgcloud/xta/test/app/factory/XtaGetMessageRequestTestFactory.java
@@ -5,7 +5,7 @@ import static de.ozgcloud.xta.test.app.factory.XtaMessageMetaDataTestFactory.*;
import de.ozgcloud.xta.test.app.model.XtaGetMessageRequest;
public class XtaGetMessageRequestTestFactory {
- public static String VALID_MESSAGE_ID = "urn:de:xta:messageid:application:000ca2fe-f4e1-45c2-8233-3a0eb760bd16";
+ public static final String VALID_MESSAGE_ID = "urn:de:xta:messageid:application:000ca2fe-f4e1-45c2-8233-3a0eb760bd16";
public static XtaGetMessageRequest.XtaGetMessageRequestBuilder createBuilder() {
return XtaGetMessageRequest.builder()
diff --git a/src/test/java/de/ozgcloud/xta/test/app/service/XtaMessageServiceTest.java b/src/test/java/de/ozgcloud/xta/test/app/service/XtaMessageServiceTest.java
index 495193a..6723c0e 100644
--- a/src/test/java/de/ozgcloud/xta/test/app/service/XtaMessageServiceTest.java
+++ b/src/test/java/de/ozgcloud/xta/test/app/service/XtaMessageServiceTest.java
@@ -63,8 +63,8 @@ public class XtaMessageServiceTest {
@Nested
class TestGetStatusList {
- private final int MAX_LIST_ITEMS = 50;
- private final int MESSAGE_COUNT = 2;
+ private static final int MAX_LIST_ITEMS = 50;
+ private static final int MESSAGE_COUNT = 2;
private final XtaMessageMetaDataListingRequest messageMetaDataListingRequest = XtaMessageMetaDataListingRequest.builder()
.clientIdentifier(READER_IDENTIFIER)
--
GitLab