From 0a9e9b358e77c3b03481a98dca47109875cd6246 Mon Sep 17 00:00:00 2001
From: Jan Zickermann <jan.zickermann@dataport.de>
Date: Fri, 4 Oct 2024 08:50:57 +0200
Subject: [PATCH] OZG-6754 Use default value for XInclude processing
XInclude processing defaults to false.
https://docs.oracle.com/javase/8/docs/api/javax/xml/parsers/DocumentBuilderFactory.html#setXIncludeAware-boolean-
---
.../client/xdomea/XdomeaXtaMessageCreatorFactory.java | 1 -
.../xdomea/XdomeaXtaMessageCreatorFactoryTest.java | 11 -----------
2 files changed, 12 deletions(-)
diff --git a/src/main/java/de/ozgcloud/xta/client/xdomea/XdomeaXtaMessageCreatorFactory.java b/src/main/java/de/ozgcloud/xta/client/xdomea/XdomeaXtaMessageCreatorFactory.java
index 4c19308..3b6ff6a 100644
--- a/src/main/java/de/ozgcloud/xta/client/xdomea/XdomeaXtaMessageCreatorFactory.java
+++ b/src/main/java/de/ozgcloud/xta/client/xdomea/XdomeaXtaMessageCreatorFactory.java
@@ -134,7 +134,6 @@ public class XdomeaXtaMessageCreatorFactory {
try {
documentBuilderFactory.setFeature(DISALLOW_DOCTYPE_DECL_FEATURE_URL, true);
documentBuilderFactory.setNamespaceAware(true);
- documentBuilderFactory.setXIncludeAware(false);
documentBuilderFactory.setSchema(createSchema());
log.debug("Creating new document builder...");
var documentBuilder = documentBuilderFactory.newDocumentBuilder();
diff --git a/src/test/java/de/ozgcloud/xta/client/xdomea/XdomeaXtaMessageCreatorFactoryTest.java b/src/test/java/de/ozgcloud/xta/client/xdomea/XdomeaXtaMessageCreatorFactoryTest.java
index bab7fca..723de05 100644
--- a/src/test/java/de/ozgcloud/xta/client/xdomea/XdomeaXtaMessageCreatorFactoryTest.java
+++ b/src/test/java/de/ozgcloud/xta/client/xdomea/XdomeaXtaMessageCreatorFactoryTest.java
@@ -124,17 +124,6 @@ class XdomeaXtaMessageCreatorFactoryTest {
verify(documentBuilderFactory).setFeature(DISALLOW_DOCTYPE_DECL_FEATURE_URL, true);
}
- @DisplayName("should not process XInclude markup")
- @Test
- @SneakyThrows
- void shouldNotProcessXIncludeMarkup() {
- setupMocks();
-
- factory.create();
-
- verify(documentBuilderFactory).setXIncludeAware(false);
- }
-
@DisplayName("should set document builder namespace aware")
@Test
@SneakyThrows
--
GitLab