From af3873512a9a30474e79e0762d21f9e9b65c7f20 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Wed, 18 Sep 2024 10:10:37 +0200
Subject: [PATCH] OZG-6500 solve comments
---
.../user/KeycloakUserPreconditionServiceTest.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ozgcloud-keycloak-operator/src/test/java/de/ozgcloud/operator/keycloak/user/KeycloakUserPreconditionServiceTest.java b/ozgcloud-keycloak-operator/src/test/java/de/ozgcloud/operator/keycloak/user/KeycloakUserPreconditionServiceTest.java
index d3caf80..1ca6e80 100644
--- a/ozgcloud-keycloak-operator/src/test/java/de/ozgcloud/operator/keycloak/user/KeycloakUserPreconditionServiceTest.java
+++ b/ozgcloud-keycloak-operator/src/test/java/de/ozgcloud/operator/keycloak/user/KeycloakUserPreconditionServiceTest.java
@@ -198,6 +198,7 @@ class KeycloakUserPreconditionServiceTest {
void shouldRespondWhenUserEmailIsEmpty() {
var user = OzgCloudKeycloakUserTestFactory.create();
user.getSpec().getKeycloakUser().setEmail("");
+
var response = service.userHasEmail(user);
assertThat(response).isFalse();
@@ -207,6 +208,7 @@ class KeycloakUserPreconditionServiceTest {
void shouldRespondWhenUserEmailIsNull() {
var user = OzgCloudKeycloakUserTestFactory.create();
user.getSpec().getKeycloakUser().setEmail(null);
+
var response = service.userHasEmail(user);
assertThat(response).isFalse();
@@ -257,10 +259,8 @@ class KeycloakUserPreconditionServiceTest {
@Test
void shouldReturnGroupExists() {
- when(keycloakGenericRemoteService.groupExists(KeycloakUserSpecUserTestFactory.GROUP_NAME_1,
- OzgCloudKeycloakUserTestFactory.METADATA_NAMESPACE)).thenReturn(true);
- when(keycloakGenericRemoteService.groupExists(KeycloakUserSpecUserTestFactory.GROUP_NAME_2,
- OzgCloudKeycloakUserTestFactory.METADATA_NAMESPACE)).thenReturn(true);
+ when(keycloakGenericRemoteService.groupExists(KeycloakUserSpecUserTestFactory.GROUP_NAME_1, OzgCloudKeycloakUserTestFactory.METADATA_NAMESPACE)).thenReturn(true);
+ when(keycloakGenericRemoteService.groupExists(KeycloakUserSpecUserTestFactory.GROUP_NAME_2, OzgCloudKeycloakUserTestFactory.METADATA_NAMESPACE)).thenReturn(true);
var rsp = service.getPreconditionErrors(user);
--
GitLab