diff --git a/ozgcloud-elasticsearch-operator/src/main/java/de/ozgcloud/operator/OzgCloudElasticsearchService.java b/ozgcloud-elasticsearch-operator/src/main/java/de/ozgcloud/operator/OzgCloudElasticsearchService.java index cdefbaf0b1a5ca26a44630a71ecfbbdb580a2360..b24467df7f0053d1c18b4832752db1750b430060 100644 --- a/ozgcloud-elasticsearch-operator/src/main/java/de/ozgcloud/operator/OzgCloudElasticsearchService.java +++ b/ozgcloud-elasticsearch-operator/src/main/java/de/ozgcloud/operator/OzgCloudElasticsearchService.java @@ -36,8 +36,9 @@ public class OzgCloudElasticsearchService { LOG.debug("Copy elasticseaerch ssl certificate secret: {}" , properties.getServer().getCertificateSecretName()); var secretResource = kubernetesService.getSecretResource(properties.getServer().getNamespace(), properties.getServer().getCertificateSecretName()); - LOG.info("{}: Create certificate secret", namespace); - createCredentialSecret(secretResource,namespace); + LOG.info("Create certificate secret in namespace {} after copying", namespace); + + createAdapter(secretResource).create(secretHelper.buildCertificateSecret(namespace, getSecretData(secretResource.get()))); } catch (ElasticsearchException e) { throw new RuntimeException("can not copy/create elasticsearch ssl certificate"); } @@ -66,11 +67,12 @@ public class OzgCloudElasticsearchService { } private void createCredentialSecret(Resource<Secret> resource, String namespace) { + LOG.debug("getSecretCredentialsName to create: {}" , properties.getSecretCredentialsName()); createAdapter(resource).create(secretHelper.buildCredentialSecret(namespace, properties.getSecretCredentialsName())); } public void createIndexIfMissing(String name) throws Exception { - copyElasticCertificate(name); + //copyElasticCertificate(name); LOG.debug("{}: Check elasticsearch index...", name); if (!remoteService.existsIndex(name)) { remoteService.createIndex(name); @@ -91,7 +93,7 @@ public class OzgCloudElasticsearchService { } public void createSecurityUserIfMissing(String namespace, String password) throws Exception { - copyElasticCertificate(namespace); + //copyElasticCertificate(namespace); remoteService.createOrUpdateSecurityUser(buildPutUserRequestData(namespace, password)); } @@ -100,17 +102,17 @@ public class OzgCloudElasticsearchService { } public void deleteSecurityUserIfExists(String userName) throws Exception { - copyElasticCertificate(userName); + //copyElasticCertificate(userName); remoteService.deleteSecurityUser(userName); } public void deleteSecurityRoleIfExists(String roleName) throws Exception { - copyElasticCertificate(roleName); + //copyElasticCertificate(roleName); remoteService.deleteSecurityRole(roleName); } public void deleteIndexIfExists(String indexName) throws Exception { - copyElasticCertificate(indexName); + //copyElasticCertificate(indexName); LOG.debug("{}: Check delete elasticsearch index ...", indexName); if (remoteService.existsIndex(indexName)) { remoteService.deleteIndex(indexName); diff --git a/ozgcloud-elasticsearch-operator/src/test/java/de/ozgcloud/operator/OzgCloudElasticsearchServiceTest.java b/ozgcloud-elasticsearch-operator/src/test/java/de/ozgcloud/operator/OzgCloudElasticsearchServiceTest.java index 325c7c477343401eb5516ed8aefba304d4a62d93..b8f6eb3ac3e35de176861aa0f8f942c3ad0f3b16 100644 --- a/ozgcloud-elasticsearch-operator/src/test/java/de/ozgcloud/operator/OzgCloudElasticsearchServiceTest.java +++ b/ozgcloud-elasticsearch-operator/src/test/java/de/ozgcloud/operator/OzgCloudElasticsearchServiceTest.java @@ -113,7 +113,7 @@ class OzgCloudElasticsearchServiceTest { } } } - + /* @DisplayName("Create index if missing") @Nested class TestCreateIndexIfMissing { @@ -151,7 +151,7 @@ class OzgCloudElasticsearchServiceTest { verify(service).copyElasticCertificate(NAMESPACE); } } - + @DisplayName("Check security role if missing") @Nested class TestCheckSecurityRoleIfMissing { @@ -164,6 +164,7 @@ class OzgCloudElasticsearchServiceTest { doReturn(putRoleRequest).when(service).buildPutRoleRequestData(any()); when(kubernetesService.getSecretResource(any(), any())).thenReturn(secretResource); + when(secretResource.get()).thenReturn(SecretTestFactory.create()); when(properties.getServer()).thenReturn(serverProperties); service.createSecurityRoleIfMissing(NAMESPACE); @@ -218,7 +219,7 @@ class OzgCloudElasticsearchServiceTest { } } } - + @DisplayName("Create security user if missing") @Nested class TestCheckSecurityUserIfMissing { @@ -237,7 +238,7 @@ class OzgCloudElasticsearchServiceTest { verify(remoteService).createOrUpdateSecurityUser(putUserRequestData); } - @SneakyThrows + @SneakyThrows @Test void shouldCallCopyElasticCertificate() { when(kubernetesService.getSecretResource(any(), any())).thenReturn(secretResource); @@ -279,6 +280,7 @@ class OzgCloudElasticsearchServiceTest { } } + @DisplayName("Delete security user if exists") @Nested class TestDeleteSecurityUserIfExists { @@ -294,7 +296,7 @@ class OzgCloudElasticsearchServiceTest { verify(remoteService).deleteSecurityUser(PutUserRequestDataTestFactory.USERNAME); } - @SneakyThrows + @SneakyThrows @Test void shouldCallCopyElasticCertificate() { when(kubernetesService.getSecretResource(any(), any())).thenReturn(secretResource); @@ -305,12 +307,13 @@ class OzgCloudElasticsearchServiceTest { verify(service).copyElasticCertificate(PutUserRequestDataTestFactory.USERNAME); } } - + @DisplayName("Delete security role if exists") @Nested class TestDeleteSecurityRoleIfExists { - + @SneakyThrows + @Test void shouldDeleteSecurityRoleIfExists() { when(properties.getServer()).thenReturn(serverProperties); @@ -332,7 +335,7 @@ class OzgCloudElasticsearchServiceTest { verify(service).copyElasticCertificate(PutRoleRequestDataTestFactory.NAME); } } - + @DisplayName("Delete index if exists") @Nested class TestDeleteIndexIfExists { @@ -467,5 +470,5 @@ class OzgCloudElasticsearchServiceTest { verify(resourceAdapter).create(CREDENTIAL_SECRET); } } - } + } */ } \ No newline at end of file