From 69b05a62d4bcfaf885df75aa0ffda1fde7f72f44 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Thu, 26 Sep 2024 16:22:09 +0200
Subject: [PATCH] OZG-6821 remove unnessasary realmExists check
---
.../keycloak/realm/KeycloakRealmService.java | 2 +-
.../realm/KeycloakRealmServiceTest.java | 21 -------------------
2 files changed, 1 insertion(+), 22 deletions(-)
diff --git a/ozgcloud-keycloak-operator/src/main/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmService.java b/ozgcloud-keycloak-operator/src/main/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmService.java
index eca8fbe..df5d981 100644
--- a/ozgcloud-keycloak-operator/src/main/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmService.java
+++ b/ozgcloud-keycloak-operator/src/main/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmService.java
@@ -74,7 +74,7 @@ class KeycloakRealmService {
.map(realmRepresentation -> addRealmName(realmRepresentation, realmName))
// TODO dieser Filter kann vermutlich gelöscht werden, die Prüfung auf
// realmExists passiert bereits vorher
- .filter(realmRepresentation -> !keycloakGenericRemoteService.realmExists(realmName))
+ //.filter(realmRepresentation -> !keycloakGenericRemoteService.realmExists(realmName))
.ifPresent(realmRepresentation -> {
remoteService.createRealm(realmRepresentation);
addUserProfileAttributes(realmRepresentation);
diff --git a/ozgcloud-keycloak-operator/src/test/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmServiceTest.java b/ozgcloud-keycloak-operator/src/test/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmServiceTest.java
index 49184fb..f968f4a 100644
--- a/ozgcloud-keycloak-operator/src/test/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmServiceTest.java
+++ b/ozgcloud-keycloak-operator/src/test/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmServiceTest.java
@@ -189,36 +189,15 @@ class KeycloakRealmServiceTest {
verify(mapper).map(REALM);
}
- @Test
- void shouldCallRealmExists() {
- service.createRealm(REALM, REALM_NAME);
-
- verify(keycloakGenericRemoteService).realmExists(REALM_NAME);
- }
-
@Test
void shouldCallCreateRealmIfNotExists() {
- when(keycloakGenericRemoteService.realmExists(REALM_NAME)).thenReturn(false);
-
service.createRealm(REALM, REALM_NAME);
verify(remoteService).createRealm(realmRepresentation);
}
- @Test
- void shouldNOTCallCreateRealmIfAlreadyExists() {
- reset(remoteService);
- when(keycloakGenericRemoteService.realmExists(REALM_NAME)).thenReturn(true);
-
- service.createRealm(REALM, REALM_NAME);
-
- verify(remoteService, never()).createRealm(any());
- }
-
@Test
void shouldCallAddRealmName() {
- when(keycloakGenericRemoteService.realmExists(REALM_NAME)).thenReturn(false);
-
service.createRealm(REALM, REALM_NAME);
verify(service).addRealmName(realmRepresentation, REALM_NAME);
--
GitLab