From 51c0917208d4adc267bf221817ea4e2260219ef1 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Mon, 15 Apr 2024 15:50:08 +0200
Subject: [PATCH] OZG-5422 add unittest for kc realm roles

---
 .../keycloak/realm/OzgCloudKeycloakRealmSpec.java         | 4 ++--
 .../operator/keycloak/realm/KeycloakRealmMapperTest.java  | 8 ++++++++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/ozgcloud-keycloak-operator/src/main/java/de/ozgcloud/operator/keycloak/realm/OzgCloudKeycloakRealmSpec.java b/ozgcloud-keycloak-operator/src/main/java/de/ozgcloud/operator/keycloak/realm/OzgCloudKeycloakRealmSpec.java
index 4154b4d..37126e2 100644
--- a/ozgcloud-keycloak-operator/src/main/java/de/ozgcloud/operator/keycloak/realm/OzgCloudKeycloakRealmSpec.java
+++ b/ozgcloud-keycloak-operator/src/main/java/de/ozgcloud/operator/keycloak/realm/OzgCloudKeycloakRealmSpec.java
@@ -73,8 +73,8 @@ class OzgCloudKeycloakRealmSpec {
 	}
 
 
-	@Builder.Default
-	private List<RealmRole> realmRoles = new ArrayList<>();
+	
+	private List<RealmRole> realmRoles;
 
 	@Getter
 	@Setter
diff --git a/ozgcloud-keycloak-operator/src/test/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmMapperTest.java b/ozgcloud-keycloak-operator/src/test/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmMapperTest.java
index 287ded8..1d78429 100644
--- a/ozgcloud-keycloak-operator/src/test/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmMapperTest.java
+++ b/ozgcloud-keycloak-operator/src/test/java/de/ozgcloud/operator/keycloak/realm/KeycloakRealmMapperTest.java
@@ -130,7 +130,15 @@ class KeycloakRealmMapperTest {
 	void shouldContainRealmRolesValues() {
 		var mapped = mapper.map(OzgCloudKeycloakRealmSpecTestFactory.create());
 		var mappedRealmRoles = mapped.getRoles();
+
 		assertThat(mappedRealmRoles.getRealm().get(0).getName()).isEqualTo(OzgCloudKeycloakRealmSpecTestFactory.ROLE_NAME_1);
 		assertThat(mappedRealmRoles.getRealm().get(1).getName()).isEqualTo(OzgCloudKeycloakRealmSpecTestFactory.ROLE_NAME_2);
 	}
+
+	@Test
+	void shouldMapWhenRealmRolesIsNull() {
+		var mapped = mapper.map(OzgCloudKeycloakRealmSpecTestFactory.createBuilder().realmRoles(null).build());
+
+		assertThat(mapped.getRoles()).isNotNull();
+	}
 }
-- 
GitLab