From f7d5ea5619a6ad13d6b8081b9e6ef7269abca695 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Mon, 7 Oct 2024 14:42:18 +0200
Subject: [PATCH] OZG-3034 OZG-6684 Set required values in helm test suites

---
 src/main/helm/templates/_helpers.tpl          |  2 +-
 src/main/helm/values.yaml                     |  2 -
 src/test/helm/deployment_63_chars_test.yaml   |  2 +
 src/test/helm/deployment_actuator_test.yaml   |  2 +
 ...yment_administration_address_env_test.yaml |  4 +-
 src/test/helm/deployment_alfa_host_test.yaml  | 24 ++----------
 src/test/helm/deployment_antragraum_test.yaml |  4 +-
 src/test/helm/deployment_bayernid_test.yaml   |  2 +
 src/test/helm/deployment_bindings_test.yaml   |  2 +
 .../helm/deployment_container_basic_test.yaml |  2 +
 ...yment_container_security_context_test.yaml |  2 +
 .../helm/deployment_defaults_labels_test.yaml |  2 +
 ...faults_topologySpreadConstraints_test.yaml |  6 ++-
 ...ployment_dummy_bescheid_document_test.yaml |  4 +-
 .../helm/deployment_elasticsearch_test.yaml   |  5 +++
 src/test/helm/deployment_env_test.yaml        |  2 +
 ...oyment_grpc_info_manager_address_test.yaml | 10 +++--
 src/test/helm/deployment_grpc_tls_test.yaml   |  4 +-
 ...oyment_grpc_user_manager_address_test.yaml |  2 +
 .../helm/deployment_host_aliases_test.yaml    |  2 +
 .../deployment_imagepull_secret_test.yaml     |  2 +
 .../deployment_kiel_hackathon_route_test.yaml |  4 +-
 .../helm/deployment_liveness_probe_test.yaml  |  2 +
 src/test/helm/deployment_mongodb_test.yaml    |  2 +
 src/test/helm/deployment_muk_test.yaml        |  2 +
 ...ment_nachrichten_manager_address_test.yaml |  2 +
 ...ployment_pod_default_spec_values_test.yaml |  2 +
 .../helm/deployment_rabbitmq_env_test.yaml    |  2 +
 src/test/helm/deployment_resources_test.yaml  |  2 +
 .../helm/deployment_service_account_test.yaml |  2 +
 .../deployment_springProfile_env_test.yaml    |  2 +
 ...oyment_test_ozgcloud_base_values_test.yaml | 38 ++++++++++++++-----
 .../deployment_usermanager_url_env_test.yaml  |  2 +
 .../deployment_vorgang_manager_env_test.yaml  |  2 +
 ...gang_manager_service_address_env_test.yaml |  2 +
 ...ployment_zufimanager_address_env_test.yaml |  2 +
 ...ent_basic_value_and_default_spec_test.yaml |  2 +
 37 files changed, 114 insertions(+), 43 deletions(-)

diff --git a/src/main/helm/templates/_helpers.tpl b/src/main/helm/templates/_helpers.tpl
index 71ec25b49..8df40f5ed 100644
--- a/src/main/helm/templates/_helpers.tpl
+++ b/src/main/helm/templates/_helpers.tpl
@@ -50,7 +50,7 @@ app.kubernetes.io/namespace: {{ include "app.namespace" . }}
 {{- end -}}
 
 {{- define "app.ozgcloudEnvironment" -}}
-{{- required "ozgcloud.environment muss angegeben sein" (.Values.ozgcloud).environment -}}
+{{- required "ozgcloud.environment must be set" (.Values.ozgcloud).environment -}}
 {{- end -}}
 
 {{- define "app.vorgangManagerDatabase" -}}
diff --git a/src/main/helm/values.yaml b/src/main/helm/values.yaml
index 6a380e033..e5d0d6e27 100644
--- a/src/main/helm/values.yaml
+++ b/src/main/helm/values.yaml
@@ -24,8 +24,6 @@
 
 cluster_env: ""
 
-baseUrl: test.sh.ozg-cloud.de
-
 replicaCount: 2
 
 # ozgcloud:
diff --git a/src/test/helm/deployment_63_chars_test.yaml b/src/test/helm/deployment_63_chars_test.yaml
index a84ec6d66..4ce95b672 100644
--- a/src/test/helm/deployment_63_chars_test.yaml
+++ b/src/test/helm/deployment_63_chars_test.yaml
@@ -33,8 +33,10 @@ chart:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 
 tests:
diff --git a/src/test/helm/deployment_actuator_test.yaml b/src/test/helm/deployment_actuator_test.yaml
index b01fbbe15..25cad19b0 100644
--- a/src/test/helm/deployment_actuator_test.yaml
+++ b/src/test/helm/deployment_actuator_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: check readiness and startup probe
diff --git a/src/test/helm/deployment_administration_address_env_test.yaml b/src/test/helm/deployment_administration_address_env_test.yaml
index b2bf2db3e..e146aebc7 100644
--- a/src/test/helm/deployment_administration_address_env_test.yaml
+++ b/src/test/helm/deployment_administration_address_env_test.yaml
@@ -29,9 +29,11 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
-  imagePullSecret: image-pull-secret
+    bezeichner: helm
+  imagePullSecret: test-image-pull-secret
 tests:
   - it: should have set administration server address
     set:
diff --git a/src/test/helm/deployment_alfa_host_test.yaml b/src/test/helm/deployment_alfa_host_test.yaml
index 7cd54cace..d4332a4fd 100644
--- a/src/test/helm/deployment_alfa_host_test.yaml
+++ b/src/test/helm/deployment_alfa_host_test.yaml
@@ -29,21 +29,19 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: should set the alfa host
-    set:
-      baseUrl: test.company.local
-      ozgcloud:
-        bezeichner: helm
     asserts:
       - contains:
           path: spec.template.spec.containers[0].env
           content:
             name: ozgcloud_alfa_host
-            value: https://helm.test.company.local
+            value: https://helm.test.sh.ozg-cloud.de
   - it: should use alfa host from values
     set:
       alfaHost: https://hamburg.mein-kreis.de
@@ -53,19 +51,3 @@ tests:
           content:
             name: ozgcloud_alfa_host
             value: https://hamburg.mein-kreis.de
-  - it: should fail if bezeichner is not set
-    set:
-      baseUrl: test.company.local
-      ozgcloud:
-        bezeichner:
-    asserts:
-      - failedTemplate:
-          errorMessage: "ozgcloud.bezeichner must be set"
-  - it: should fail if base url is not set
-    set:
-      baseUrl:
-      ozgcloud:
-        bezeichner: helm
-    asserts:
-      - failedTemplate:
-          errorMessage: "baseUrl must be set"
diff --git a/src/test/helm/deployment_antragraum_test.yaml b/src/test/helm/deployment_antragraum_test.yaml
index 0def5958d..29ed00d4c 100644
--- a/src/test/helm/deployment_antragraum_test.yaml
+++ b/src/test/helm/deployment_antragraum_test.yaml
@@ -29,9 +29,11 @@ release:
 templates:
   - templates/deployment.yaml
 set:
-  imagePullSecret: image-pull-secret
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
+  imagePullSecret: test-image-pull-secret
 tests:
   - it: should set antragsraum values
     set:
diff --git a/src/test/helm/deployment_bayernid_test.yaml b/src/test/helm/deployment_bayernid_test.yaml
index 5b4837870..c11412aa8 100644
--- a/src/test/helm/deployment_bayernid_test.yaml
+++ b/src/test/helm/deployment_bayernid_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: should set bayernid values
diff --git a/src/test/helm/deployment_bindings_test.yaml b/src/test/helm/deployment_bindings_test.yaml
index d4fa53ca7..51add5e56 100644
--- a/src/test/helm/deployment_bindings_test.yaml
+++ b/src/test/helm/deployment_bindings_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: should have volumes
diff --git a/src/test/helm/deployment_container_basic_test.yaml b/src/test/helm/deployment_container_basic_test.yaml
index 876b4714a..2a36ac446 100644
--- a/src/test/helm/deployment_container_basic_test.yaml
+++ b/src/test/helm/deployment_container_basic_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: should have correct values for container image, name, imagePullPolicy
diff --git a/src/test/helm/deployment_container_security_context_test.yaml b/src/test/helm/deployment_container_security_context_test.yaml
index 11aef905b..314103487 100644
--- a/src/test/helm/deployment_container_security_context_test.yaml
+++ b/src/test/helm/deployment_container_security_context_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: check default values
diff --git a/src/test/helm/deployment_defaults_labels_test.yaml b/src/test/helm/deployment_defaults_labels_test.yaml
index 2cf86a63e..7f7b80734 100644
--- a/src/test/helm/deployment_defaults_labels_test.yaml
+++ b/src/test/helm/deployment_defaults_labels_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: check default labels
diff --git a/src/test/helm/deployment_defaults_topologySpreadConstraints_test.yaml b/src/test/helm/deployment_defaults_topologySpreadConstraints_test.yaml
index b5e90a806..1a0ee0a34 100644
--- a/src/test/helm/deployment_defaults_topologySpreadConstraints_test.yaml
+++ b/src/test/helm/deployment_defaults_topologySpreadConstraints_test.yaml
@@ -28,9 +28,11 @@ release:
   namespace: sh-helm-test
 templates:
   - templates/deployment.yaml
-set:  
+set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
-    environment: test
+    environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
  
 tests:
diff --git a/src/test/helm/deployment_dummy_bescheid_document_test.yaml b/src/test/helm/deployment_dummy_bescheid_document_test.yaml
index 8863f522e..74adfb830 100644
--- a/src/test/helm/deployment_dummy_bescheid_document_test.yaml
+++ b/src/test/helm/deployment_dummy_bescheid_document_test.yaml
@@ -29,12 +29,14 @@ release:
 templates:
   - templates/deployment.yaml
 set:
-  imagePullSecret: image-pull-secret
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
     feature:
       bescheid:
         enableDummyDocumentProcessor: true
+  imagePullSecret: image-pull-secret
 tests:
   - it: should enable dummy bescheid document processor
     asserts:
diff --git a/src/test/helm/deployment_elasticsearch_test.yaml b/src/test/helm/deployment_elasticsearch_test.yaml
index 2da7a513b..cb56b7a5a 100644
--- a/src/test/helm/deployment_elasticsearch_test.yaml
+++ b/src/test/helm/deployment_elasticsearch_test.yaml
@@ -26,8 +26,13 @@ suite: elasticsearch tests
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
+    feature:
+      bescheid:
+        enableDummyDocumentProcessor: true
   imagePullSecret: test-image-pull-secret
 tests:
   - it: check if elastic credentials are disabled by default
diff --git a/src/test/helm/deployment_env_test.yaml b/src/test/helm/deployment_env_test.yaml
index 4d71e36a7..2a98ced7a 100644
--- a/src/test/helm/deployment_env_test.yaml
+++ b/src/test/helm/deployment_env_test.yaml
@@ -26,8 +26,10 @@ suite: test environments
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: check customList as list
diff --git a/src/test/helm/deployment_grpc_info_manager_address_test.yaml b/src/test/helm/deployment_grpc_info_manager_address_test.yaml
index 763578ba5..81185b971 100644
--- a/src/test/helm/deployment_grpc_info_manager_address_test.yaml
+++ b/src/test/helm/deployment_grpc_info_manager_address_test.yaml
@@ -28,14 +28,18 @@ release:
   namespace: sh-helm-test
 templates:
   - templates/deployment.yaml
+set:
+  baseUrl: test.sh.ozg-cloud.de
+  ozgcloud:
+    environment: dev
+    bezeichner: helm
+  imagePullSecret: test-image-pull-secret
 tests:
   - it: should set the grpc info-manager client address
     set:
       ozgcloud:
-        environment: dev
-        infoManager: 
+        infoManager:
           address: https://info-manager.my-wonderful-domain.local:9000
-      imagePullSecret: test-image-pull-secret
     asserts:
       - contains:
           path: spec.template.spec.containers[0].env
diff --git a/src/test/helm/deployment_grpc_tls_test.yaml b/src/test/helm/deployment_grpc_tls_test.yaml
index 120c32436..fdcbab138 100644
--- a/src/test/helm/deployment_grpc_tls_test.yaml
+++ b/src/test/helm/deployment_grpc_tls_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
-    environment: test
+    environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: should have volume for grpc-tls-cert
diff --git a/src/test/helm/deployment_grpc_user_manager_address_test.yaml b/src/test/helm/deployment_grpc_user_manager_address_test.yaml
index a26e7cb0c..12938cc05 100644
--- a/src/test/helm/deployment_grpc_user_manager_address_test.yaml
+++ b/src/test/helm/deployment_grpc_user_manager_address_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: should set the grpc user-manager client address
diff --git a/src/test/helm/deployment_host_aliases_test.yaml b/src/test/helm/deployment_host_aliases_test.yaml
index 549c387c7..89fa7000a 100644
--- a/src/test/helm/deployment_host_aliases_test.yaml
+++ b/src/test/helm/deployment_host_aliases_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: should not set hostAliases
diff --git a/src/test/helm/deployment_imagepull_secret_test.yaml b/src/test/helm/deployment_imagepull_secret_test.yaml
index a509da8e6..bb794eb01 100644
--- a/src/test/helm/deployment_imagepull_secret_test.yaml
+++ b/src/test/helm/deployment_imagepull_secret_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
 tests:
   - it: should set the imagePull secret
     set:
diff --git a/src/test/helm/deployment_kiel_hackathon_route_test.yaml b/src/test/helm/deployment_kiel_hackathon_route_test.yaml
index f7879e473..1c896feef 100644
--- a/src/test/helm/deployment_kiel_hackathon_route_test.yaml
+++ b/src/test/helm/deployment_kiel_hackathon_route_test.yaml
@@ -29,12 +29,14 @@ release:
 templates:
   - templates/deployment.yaml
 set:
-  imagePullSecret: image-pull-secret
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
     feature:
       bescheid:
         kielHackathonRoute: true
+  imagePullSecret: test-image-pull-secret
 tests:
   - it: should enable kiel hackathon toggle
     asserts:
diff --git a/src/test/helm/deployment_liveness_probe_test.yaml b/src/test/helm/deployment_liveness_probe_test.yaml
index 6eb925f2d..9a5dddc45 100644
--- a/src/test/helm/deployment_liveness_probe_test.yaml
+++ b/src/test/helm/deployment_liveness_probe_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: livenessProbe should be disabled by default
diff --git a/src/test/helm/deployment_mongodb_test.yaml b/src/test/helm/deployment_mongodb_test.yaml
index ad8a4cb17..5fa9fa8f9 100644
--- a/src/test/helm/deployment_mongodb_test.yaml
+++ b/src/test/helm/deployment_mongodb_test.yaml
@@ -26,8 +26,10 @@ suite: deployment test mongodb environments
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: check mongodb default env
diff --git a/src/test/helm/deployment_muk_test.yaml b/src/test/helm/deployment_muk_test.yaml
index aeb0cd59e..bcc31dc74 100644
--- a/src/test/helm/deployment_muk_test.yaml
+++ b/src/test/helm/deployment_muk_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: should set muk values
diff --git a/src/test/helm/deployment_nachrichten_manager_address_test.yaml b/src/test/helm/deployment_nachrichten_manager_address_test.yaml
index 67887800a..f8d47d58c 100644
--- a/src/test/helm/deployment_nachrichten_manager_address_test.yaml
+++ b/src/test/helm/deployment_nachrichten_manager_address_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: check if nachrichten-manager address is correct
diff --git a/src/test/helm/deployment_pod_default_spec_values_test.yaml b/src/test/helm/deployment_pod_default_spec_values_test.yaml
index 42f5e0771..8e541d2fa 100644
--- a/src/test/helm/deployment_pod_default_spec_values_test.yaml
+++ b/src/test/helm/deployment_pod_default_spec_values_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
  - it: should have correct pod template values
diff --git a/src/test/helm/deployment_rabbitmq_env_test.yaml b/src/test/helm/deployment_rabbitmq_env_test.yaml
index 3adaadfd0..c1e4acfee 100644
--- a/src/test/helm/deployment_rabbitmq_env_test.yaml
+++ b/src/test/helm/deployment_rabbitmq_env_test.yaml
@@ -26,8 +26,10 @@ suite: deployment test rabbitmq environments
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: check rabbitmq spring env
diff --git a/src/test/helm/deployment_resources_test.yaml b/src/test/helm/deployment_resources_test.yaml
index 7a545c8e7..9f42d2ff6 100644
--- a/src/test/helm/deployment_resources_test.yaml
+++ b/src/test/helm/deployment_resources_test.yaml
@@ -28,8 +28,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: test resources
diff --git a/src/test/helm/deployment_service_account_test.yaml b/src/test/helm/deployment_service_account_test.yaml
index ad44c8d08..8a9de29bc 100644
--- a/src/test/helm/deployment_service_account_test.yaml
+++ b/src/test/helm/deployment_service_account_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: should use service account with default name
diff --git a/src/test/helm/deployment_springProfile_env_test.yaml b/src/test/helm/deployment_springProfile_env_test.yaml
index 7b24e13fa..f4cc5923d 100644
--- a/src/test/helm/deployment_springProfile_env_test.yaml
+++ b/src/test/helm/deployment_springProfile_env_test.yaml
@@ -28,8 +28,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: should override spring profiles
diff --git a/src/test/helm/deployment_test_ozgcloud_base_values_test.yaml b/src/test/helm/deployment_test_ozgcloud_base_values_test.yaml
index e39659efb..00929fdae 100644
--- a/src/test/helm/deployment_test_ozgcloud_base_values_test.yaml
+++ b/src/test/helm/deployment_test_ozgcloud_base_values_test.yaml
@@ -28,19 +28,39 @@ release:
   namespace: sh-helm-test
 templates:
   - templates/deployment.yaml
-
+set:
+  baseUrl: test.sh.ozg-cloud.de
+  ozgcloud:
+    environment: dev
+    bezeichner: helm
+  imagePullSecret: test-image-pull-secret
 tests:
   - it: should fail on missing environment
-    set: 
-      imagePullSecret: test-image-pull-secret
+    set:
+      ozgcloud:
+        environment:
+    asserts:
+      - failedTemplate:
+          errorMessage: ozgcloud.environment must be set
+  - it: should fail on missing imagePullSecret
+    set:
+      imagePullSecret:
     asserts:
       - failedTemplate:
-          errorMessage: ozgcloud.environment muss angegeben sein
-  - it: should not fail on not missing environment and not missing imagepullsecret
+          errorMessage: imagePullSecret must be set
+  - it: should fail if bezeichner is not set
     set:
       ozgcloud:
-        environment: dev
-      imagePullSecret: test-image-pull-secret
+        bezeichner:
     asserts:
-      - notFailedTemplate: {}
-
+      - failedTemplate:
+          errorMessage: "ozgcloud.bezeichner must be set"
+  - it: should fail if base url is not set
+    set:
+      baseUrl:
+    asserts:
+      - failedTemplate:
+          errorMessage: "baseUrl must be set"
+  - it: should not fail on not missing required values
+    asserts:
+      - notFailedTemplate: { }
diff --git a/src/test/helm/deployment_usermanager_url_env_test.yaml b/src/test/helm/deployment_usermanager_url_env_test.yaml
index 5a2ac4d9a..c0bcda108 100644
--- a/src/test/helm/deployment_usermanager_url_env_test.yaml
+++ b/src/test/helm/deployment_usermanager_url_env_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: check if user-manager url is correct
diff --git a/src/test/helm/deployment_vorgang_manager_env_test.yaml b/src/test/helm/deployment_vorgang_manager_env_test.yaml
index 4626fa929..140a1715e 100644
--- a/src/test/helm/deployment_vorgang_manager_env_test.yaml
+++ b/src/test/helm/deployment_vorgang_manager_env_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: check if application address is set
diff --git a/src/test/helm/deployment_vorgang_manager_service_address_env_test.yaml b/src/test/helm/deployment_vorgang_manager_service_address_env_test.yaml
index 8bc573b0a..394dd179f 100644
--- a/src/test/helm/deployment_vorgang_manager_service_address_env_test.yaml
+++ b/src/test/helm/deployment_vorgang_manager_service_address_env_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: check if service address of vorgang manager is set
diff --git a/src/test/helm/deployment_zufimanager_address_env_test.yaml b/src/test/helm/deployment_zufimanager_address_env_test.yaml
index d73c2e5b3..103ab80b2 100644
--- a/src/test/helm/deployment_zufimanager_address_env_test.yaml
+++ b/src/test/helm/deployment_zufimanager_address_env_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 tests:
   - it: check default zufi-manager address
diff --git a/src/test/helm/deyploment_basic_value_and_default_spec_test.yaml b/src/test/helm/deyploment_basic_value_and_default_spec_test.yaml
index 76331e120..0a3a2db66 100644
--- a/src/test/helm/deyploment_basic_value_and_default_spec_test.yaml
+++ b/src/test/helm/deyploment_basic_value_and_default_spec_test.yaml
@@ -29,8 +29,10 @@ release:
 templates:
   - templates/deployment.yaml
 set:
+  baseUrl: test.sh.ozg-cloud.de
   ozgcloud:
     environment: dev
+    bezeichner: helm
   imagePullSecret: test-image-pull-secret
 
 tests:
-- 
GitLab