From 59b1496a998a1bb12303a01a1d1943a25ce4f1c0 Mon Sep 17 00:00:00 2001 From: OZGCloud <ozgcloud@mgm-tp.com> Date: Thu, 2 Mar 2023 11:25:58 +0100 Subject: [PATCH] OZG-3371 improve test --- .../osi/OsiPostfachRemoteServiceTest.java | 25 +++++++++++-------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/mail-service/src/test/java/de/itvsh/ozg/mail/postfach/osi/OsiPostfachRemoteServiceTest.java b/mail-service/src/test/java/de/itvsh/ozg/mail/postfach/osi/OsiPostfachRemoteServiceTest.java index 34f46009c..7f2ab53c5 100644 --- a/mail-service/src/test/java/de/itvsh/ozg/mail/postfach/osi/OsiPostfachRemoteServiceTest.java +++ b/mail-service/src/test/java/de/itvsh/ozg/mail/postfach/osi/OsiPostfachRemoteServiceTest.java @@ -256,47 +256,52 @@ public class OsiPostfachRemoteServiceTest { @Test void shouldHaveVorgangIdAsSequenceNumber() { - when(mapper.toOsiMessage(any())).thenReturn(MessageTestFactory.create()); + val postfachNachricht = PostfachNachrichtTestFactory.create(); + when(mapper.toOsiMessage(postfachNachricht)).thenReturn(MessageTestFactory.create()); prepareMockServer().andExpect(jsonPath("$.sequenceNumber").value(VORGANG_ID)); - service.sendMessage(PostfachNachrichtTestFactory.create()); + service.sendMessage(postfachNachricht); } @Test void shouldHavePostfachIdAsNameIdentifier() { - when(mapper.toOsiMessage(any())).thenReturn(MessageTestFactory.create()); + val postfachNachricht = PostfachNachrichtTestFactory.create(); + when(mapper.toOsiMessage(postfachNachricht)).thenReturn(MessageTestFactory.create()); prepareMockServer().andExpect(jsonPath("$.nameIdentifier").value(POSTFACH_ID)); - service.sendMessage(PostfachNachrichtTestFactory.create()); + service.sendMessage(postfachNachricht); } @Test void shouldHaveSubject() { - when(mapper.toOsiMessage(any())).thenReturn(MessageTestFactory.create()); + val postfachNachricht = PostfachNachrichtTestFactory.create(); + when(mapper.toOsiMessage(postfachNachricht)).thenReturn(MessageTestFactory.create()); prepareMockServer().andExpect(jsonPath("$.subject").value(SUBJECT)); - service.sendMessage(PostfachNachrichtTestFactory.create()); + service.sendMessage(postfachNachricht); } @Test void shouldHaveMailBodyAsBody() { - when(mapper.toOsiMessage(any())).thenReturn(MessageTestFactory.create()); + val postfachNachricht = PostfachNachrichtTestFactory.create(); + when(mapper.toOsiMessage(postfachNachricht)).thenReturn(MessageTestFactory.create()); prepareMockServer().andExpect(jsonPath("$.body").value(MAIL_BODY)); - service.sendMessage(PostfachNachrichtTestFactory.create()); + service.sendMessage(postfachNachricht); } @Test void shouldHaveNumericReplyOptionAsReplyAction() { - when(mapper.toOsiMessage(any())).thenReturn(MessageTestFactory.create()); + val postfachNachricht = PostfachNachrichtTestFactory.create(); + when(mapper.toOsiMessage(postfachNachricht)).thenReturn(MessageTestFactory.create()); prepareMockServer().andExpect(jsonPath("$.replyAction").value(REPLY_OPTION.toValue())); - service.sendMessage(PostfachNachrichtTestFactory.create()); + service.sendMessage(postfachNachricht); } } -- GitLab