From 3aef2380d6bab734859429ff84a63d733c2e2eb9 Mon Sep 17 00:00:00 2001 From: OZGCloud <ozgcloud@mgm-tp.com> Date: Thu, 29 Aug 2024 23:43:24 +0200 Subject: [PATCH] OZG-6508 extend itcases --- .../de/ozgcloud/vorgang/files/FileITCase.java | 92 ++++++++++++++----- 1 file changed, 67 insertions(+), 25 deletions(-) diff --git a/vorgang-manager-server/src/test/java/de/ozgcloud/vorgang/files/FileITCase.java b/vorgang-manager-server/src/test/java/de/ozgcloud/vorgang/files/FileITCase.java index a4174aa69..4301bc4b5 100644 --- a/vorgang-manager-server/src/test/java/de/ozgcloud/vorgang/files/FileITCase.java +++ b/vorgang-manager-server/src/test/java/de/ozgcloud/vorgang/files/FileITCase.java @@ -83,44 +83,86 @@ class FileITCase { private StreamObserver<GrpcGetAttachmentsResponse> responseObserver; @Captor private ArgumentCaptor<GrpcGetAttachmentsResponse> responseCaptor; - private GrpcGetAttachmentsRequest request = GrpcGetAttachmentsRequestTestFactory.create(); - @Test - void getAttachmentsShouldReturnNonEmptyGrpcResponse() { - callServiceGetAttachments(); + private GrpcGetAttachmentsRequest request; - var grpcResponse = responseCaptor.getValue(); + @Nested + class TestByEingangId { - assertThat(grpcResponse).isNotNull(); - } + @BeforeEach + void init() { + request = GrpcGetAttachmentsRequestTestFactory.createBuilder().clearVorgangId().build(); + } - @Test - void eingangShouldHaveTwoAttachments() { - callServiceGetAttachments(); + @Test + void getAttachmentsShouldReturnNonEmptyGrpcResponse() { + callServiceGetAttachments(); - var grpcResponse = responseCaptor.getValue(); + var grpcResponse = responseCaptor.getValue(); - assertThat(grpcResponse.getFileCount()).isEqualTo(2); + assertThat(grpcResponse).isNotNull(); + } + + @Test + void eingangShouldHaveTwoAttachments() { + callServiceGetAttachments(); + + var grpcResponse = responseCaptor.getValue(); + + assertThat(grpcResponse.getFileCount()).isEqualTo(2); + } + + @Test + void validateFirstAttachmentFileContent() { + callServiceGetAttachments(); + + var attachment1 = responseCaptor.getValue().getFile(0); + + assertThat(attachment1.getId()).isEqualTo(IncomingFileTestFactory.ID.toString()); + assertThat(attachment1.getName()).isEqualTo(IncomingFileTestFactory.NAME); + assertThat(attachment1.getSize()).isEqualTo(IncomingFileTestFactory.SIZE); + } + + @Test + void validateSecondAttachmentFileContent() { + callServiceGetAttachments(); + + var attachment1 = responseCaptor.getValue().getFile(1); + + assertThat(attachment1.getId()).isEqualTo(ID2.toString()); + } } - @Test - void validateFirstAttachmentFileContent() { - callServiceGetAttachments(); + @Nested + class TestByVorgangId { - var attachment1 = responseCaptor.getValue().getFile(0); + @BeforeEach + void init() { + request = GrpcGetAttachmentsRequestTestFactory.createBuilder().clearEingangId().build(); + } - assertThat(attachment1.getId()).isEqualTo(IncomingFileTestFactory.ID.toString()); - assertThat(attachment1.getName()).isEqualTo(IncomingFileTestFactory.NAME); - assertThat(attachment1.getSize()).isEqualTo(IncomingFileTestFactory.SIZE); + @Test + void shouldGetAttachments() { + callServiceGetAttachments(); + + verify(responseObserver).onNext(responseCaptor.capture()); + } } - @Test - void validateSecondAttachmentFileContent() { - callServiceGetAttachments(); + @Nested + class TestByVorgangAndEingangId { - var attachment1 = responseCaptor.getValue().getFile(1); + @BeforeEach + void init() { + request = GrpcGetAttachmentsRequestTestFactory.create(); + } - assertThat(attachment1.getId()).isEqualTo(ID2.toString()); + @Test + void shouldGetAttachments() { + callServiceGetAttachments(); + + verify(responseObserver).onNext(responseCaptor.capture()); + } } private void callServiceGetAttachments() { @@ -137,7 +179,7 @@ class FileITCase { private StreamObserver<GrpcGetRepresentationsResponse> responseObserver; @Captor private ArgumentCaptor<GrpcGetRepresentationsResponse> responseCaptor; - private GrpcGetRepresentationsRequest request = GrpcGetRepresentationsRequestTestFactory.create(); + private final GrpcGetRepresentationsRequest request = GrpcGetRepresentationsRequestTestFactory.create(); @Test void getRepresentationsShouldReturnNonEmptyGrpcResponse() { -- GitLab