diff --git a/src/main/helm/templates/_helpers.tpl b/src/main/helm/templates/_helpers.tpl index 8df40f5edce01ba5adc176eb8f1d901dba08e350..fe0cc4a15bb047e47330a3fc52f17f187e45d67c 100644 --- a/src/main/helm/templates/_helpers.tpl +++ b/src/main/helm/templates/_helpers.tpl @@ -77,6 +77,22 @@ app.kubernetes.io/namespace: {{ include "app.namespace" . }} {{ printf "http://%s.%s:8080" .Values.administrationName .Release.Namespace }} {{- end -}} +{{- define "app.getApplicationAddress" -}} +{{- if .Values.applicationAddress -}} +{{ .Values.applicationAddress }} +{{- else -}} +{{ printf "dns:///%s.%s:9090" .Values.vorgangmanagerName .Release.Namespace }} +{{- end -}} +{{- end -}} + +{{- define "app.getNachrichtenManagerAddress" -}} +{{- if .Values.nachrichtenManagerAddress -}} +{{ .Values.nachrichtenManagerAddress }} +{{- else -}} +{{ printf "%s.%s:9090" .Values.vorgangmanagerName .Release.Namespace }} +{{- end -}} +{{- end -}} + {{- define "app.databaseSecretName" -}} {{- if (.Values.database).secretName -}} {{ .Values.database.secretName }} diff --git a/src/main/helm/templates/deployment.yaml b/src/main/helm/templates/deployment.yaml index 65b3f7d2055109abff0eea24180293bbc85c5c0e..52451fef26129625132235fbbe47dae80958b930 100644 --- a/src/main/helm/templates/deployment.yaml +++ b/src/main/helm/templates/deployment.yaml @@ -64,9 +64,9 @@ spec: - name: spring_profiles_active value: {{ include "app.envSpringProfiles" . }} - name: ozgcloud_application_address - value: {{ include "app.ozgcloud_vorgangmanager_address" . }} + value: {{ include "app.getApplicationAddress" . }} - name: ozgcloud_nachrichten-manager_address - value: {{ include "app.ozgcloud_vorgangmanager_address" . }} + value: {{ include "app.getNachrichtenManagerAddress" . }} {{- if .Values.env.ozgcloudAktenzeichen.enabled }} - name: ozgcloud_aktenzeichen value: {{ .Values.env.ozgcloudAktenzeichen.value | default "de.ozgcloud.vorgang.vorgang.AktenzeichenProviderEA" }} diff --git a/src/test/helm/deployment_nachrichten_manager_address_test.yaml b/src/test/helm/deployment_nachrichten_manager_address_test.yaml index f8d47d58caf12baf9146a23120f2a36b3cd89fa7..38907692a6e2e70500eb9ca3f9d2d2717bc2cef8 100644 --- a/src/test/helm/deployment_nachrichten_manager_address_test.yaml +++ b/src/test/helm/deployment_nachrichten_manager_address_test.yaml @@ -22,23 +22,34 @@ # unter der Lizenz sind dem Lizenztext zu entnehmen. # -suite: test environments nachrichten-manager_url +suite: deployment nachrichten-manager_url release: name: vorgang-manager - namespace: sh-helm-test + namespace: by-helm-test templates: - templates/deployment.yaml set: - baseUrl: test.sh.ozg-cloud.de + baseUrl: test.by.ozg-cloud.de ozgcloud: environment: dev bezeichner: helm imagePullSecret: test-image-pull-secret tests: - - it: check if nachrichten-manager address is correct + - it: should generate nachrichten-manager address if not exists asserts: - contains: path: spec.template.spec.containers[0].env content: name: ozgcloud_nachrichten-manager_address - value: dns:///vorgang-manager.sh-helm-test:9090 + value: vorgang-manager.by-helm-test:9090 + + - it: should have set nachrichten-manager address + set: + nachrichtenManagerAddress: localSettedAddress + asserts: + - contains: + path: spec.template.spec.containers[0].env + content: + name: ozgcloud_nachrichten-manager_address + value: localSettedAddress + \ No newline at end of file diff --git a/src/test/helm/deployment_vorgang_manager_env_test.yaml b/src/test/helm/deployment_vorgang_manager_env_test.yaml index 140a1715ea26bb5a8f1d96510c2fea0590ec6350..88948502dad997927c922bc115460bfff741dfc4 100644 --- a/src/test/helm/deployment_vorgang_manager_env_test.yaml +++ b/src/test/helm/deployment_vorgang_manager_env_test.yaml @@ -35,10 +35,20 @@ set: bezeichner: helm imagePullSecret: test-image-pull-secret tests: - - it: check if application address is set + - it: should generate application address if its not set asserts: - contains: path: spec.template.spec.containers[0].env content: name: ozgcloud_application_address - value: dns:///vorgang-manager.by-helm-test:9090 \ No newline at end of file + value: dns:///vorgang-manager.by-helm-test:9090 + + - it: should keep application address if its set + set: + applicationAddress: localSettedAddress + asserts: + - contains: + path: spec.template.spec.containers[0].env + content: + name: ozgcloud_application_address + value: localSettedAddress \ No newline at end of file diff --git a/vorgang-manager-server/pom.xml b/vorgang-manager-server/pom.xml index cfc57256c9d909e93fb658cafe5370691ec50fc3..1d234cc9761105454a700bd63af4cd9e155f718e 100644 --- a/vorgang-manager-server/pom.xml +++ b/vorgang-manager-server/pom.xml @@ -55,9 +55,9 @@ <user-manager-interface.version>2.9.0</user-manager-interface.version> <bescheid-manager.version>1.20.0-SNAPSHOT</bescheid-manager.version> <processor-manager.version>0.4.1</processor-manager.version> - <nachrichten-manager.version>2.12.0</nachrichten-manager.version> + <nachrichten-manager.version>2.12.1</nachrichten-manager.version> <ozgcloud-starter.version>0.12.0</ozgcloud-starter.version> - <notification-manager.version>2.11.0</notification-manager.version> + <notification-manager.version>2.11.1</notification-manager.version> <collaboration-manager.version>0.3.0</collaboration-manager.version> <zip.version>2.11.1</zip.version>