diff --git a/src/main/helm/templates/_helpers.tpl b/src/main/helm/templates/_helpers.tpl index fe0cc4a15bb047e47330a3fc52f17f187e45d67c..435ffac96d724c9343abceb3c43d4b5c01ee5c5b 100644 --- a/src/main/helm/templates/_helpers.tpl +++ b/src/main/helm/templates/_helpers.tpl @@ -163,3 +163,7 @@ app.kubernetes.io/namespace: {{ include "app.namespace" . }} {{ printf "https://%s.%s" (include "app.ozgcloudBezeichner" .) (include "app.baseUrl" .) }} {{- end -}} {{- end -}} + +{{- define "app.getZufiManagerAddress" -}} +{{- required "zufiManager.address must be set" (.Values.zufiManager).address -}} +{{- end -}} \ No newline at end of file diff --git a/src/main/helm/templates/deployment.yaml b/src/main/helm/templates/deployment.yaml index 52451fef26129625132235fbbe47dae80958b930..ff958feeac3f41ec32aed322ad8fa46f4788a9c8 100644 --- a/src/main/helm/templates/deployment.yaml +++ b/src/main/helm/templates/deployment.yaml @@ -155,12 +155,14 @@ spec: - name: ozgcloud_user-manager_url value: {{ include "app.ozgcloud_migration_user-manager_address" . }} + {{- if (.Values.zufiManager).enabled }} - name: ozgcloud_zufi-manager_address - value: {{ (.Values.zufiManager).address }} + value: {{ include "app.getZufiManagerAddress" . }} - name: grpc_client_zufi-manager_address - value: {{ (.Values.zufiManager).address }} + value: {{ include "app.getZufiManagerAddress" . }} - name: grpc_client_zufi-manager_negotiationType - value: {{ (.Values.zufiManager).grpcClientNegotiationType }} + value: {{ (.Values.zufiManager).grpcClientNegotiationType | default "PLAINTEXT" }} + {{- end}} {{- if not (.Values.database).useExternal }} - name: spring_data_mongodb_uri valueFrom: diff --git a/src/main/helm/values.yaml b/src/main/helm/values.yaml index e5d0d6e271c3ad94a4be75ee045b192fe42e2a3a..832dfa01e3780329f886285f08da840d8f482dba 100644 --- a/src/main/helm/values.yaml +++ b/src/main/helm/values.yaml @@ -57,9 +57,6 @@ usermanagerName: user-manager administrationName: administration -zufiManager: - address: dns:///zufi-server.zufi:9090 - elasticsearch: certificateSecretName: elasticsearch-certificate diff --git a/src/test/helm/deployment_zufimanager_address_env_test.yaml b/src/test/helm/deployment_zufimanager_address_env_test.yaml index 103ab80b241453c69e9cda99337afe387c36b898..dfb89d3f4c3cda0c84af353f7e23bde278d79908 100644 --- a/src/test/helm/deployment_zufimanager_address_env_test.yaml +++ b/src/test/helm/deployment_zufimanager_address_env_test.yaml @@ -35,51 +35,70 @@ set: bezeichner: helm imagePullSecret: test-image-pull-secret tests: - - it: check default zufi-manager address + - it: zufi-manager should be disabled by default asserts: - - contains: + - notContains: path: spec.template.spec.containers[0].env content: name: ozgcloud_zufi-manager_address - value: dns:///zufi-server.zufi:9090 + any: true + - notContains: + path: spec.template.spec.containers[0].env + content: + name: grpc_client_zufi-manager_address + any: true + - notContains: + path: spec.template.spec.containers[0].env + content: + name: grpc_client_zufi-manager_negotiationType + any: true - - it: should set custom zufi-manager address + - it: should require zufi-manager address set: zufiManager: - address: dns://other.zufi:9090 + enabled: true asserts: - - contains: - path: spec.template.spec.containers[0].env - content: - name: ozgcloud_zufi-manager_address - value: dns://other.zufi:9090 + - failedTemplate: + errorMessage: "zufiManager.address must be set" - - it: check default zufi-manager grpc client address + - it: should set zufi-manager address + set: + zufiManager: + enabled: true + address: dns:///zufi-server.zufi-test:9090 asserts: - contains: path: spec.template.spec.containers[0].env content: name: grpc_client_zufi-manager_address - value: dns:///zufi-server.zufi:9090 + value: dns:///zufi-server.zufi-test:9090 + - contains: + path: spec.template.spec.containers[0].env + content: + name: ozgcloud_zufi-manager_address + value: dns:///zufi-server.zufi-test:9090 - - it: should set custom zufi-manager grpc client address + - it: check default zufi-manager grpc negotiationType set: zufiManager: - address: dns://other.zufi:9090 + enabled: true + address: dns:///zufi-server.zufi-test:9090 asserts: - contains: path: spec.template.spec.containers[0].env content: - name: grpc_client_zufi-manager_address - value: dns://other.zufi:9090 + name: grpc_client_zufi-manager_negotiationType + value: PLAINTEXT - - it: check if zufi-manager negotiationType is set + - it: should set zufi-manager negotiationType set: zufiManager: - grpcClientNegotiationType: NOT_DEFAULT + enabled: true + address: dns:///zufi-server.zufi-test:9090 + grpcClientNegotiationType: TLS asserts: - contains: path: spec.template.spec.containers[0].env content: name: grpc_client_zufi-manager_negotiationType - value: NOT_DEFAULT + value: TLS