From 0657c181a7ae0a9fff4e7a60335ac2b01e4d1f4a Mon Sep 17 00:00:00 2001
From: Felix Reichenbach <felix.reichenbach@mgm-tp.com>
Date: Wed, 22 Jan 2025 09:40:03 +0100
Subject: [PATCH] OZG-7515 extract Strings to constants
---
...scheidToPatchAttachedItemCommandITCase.java | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/vorgang-manager-server/src/test/java/de/ozgcloud/vorgang/common/migration/M014_AddItemNameBescheidToPatchAttachedItemCommandITCase.java b/vorgang-manager-server/src/test/java/de/ozgcloud/vorgang/common/migration/M014_AddItemNameBescheidToPatchAttachedItemCommandITCase.java
index adc23fb8b..a9e4c2460 100644
--- a/vorgang-manager-server/src/test/java/de/ozgcloud/vorgang/common/migration/M014_AddItemNameBescheidToPatchAttachedItemCommandITCase.java
+++ b/vorgang-manager-server/src/test/java/de/ozgcloud/vorgang/common/migration/M014_AddItemNameBescheidToPatchAttachedItemCommandITCase.java
@@ -43,6 +43,12 @@ import de.ozgcloud.vorgang.command.PersistedCommand;
@DataITCase
class M014_AddItemNameBescheidToPatchAttachedItemCommandITCase {
+ private static final String BESCHEID_ITEM_NAME = "Bescheid";
+ private static final String ITEM_NAME_FIELD = "itemName";
+ private static final String PATCH_ATTACHED_ITEM_ORDER = "PATCH_ATTACHED_ITEM";
+ private static final String PARENT_ID_FIELD = "parentId";
+ private static final String SEND_BESCHEID_ORDER = "SEND_BESCHEID";
+
@InjectMocks
private M014_AddItemNameBescheidToPatchAttachedItemCommand migration;
@Autowired
@@ -70,22 +76,22 @@ class M014_AddItemNameBescheidToPatchAttachedItemCommandITCase {
}
private PersistedCommand saveSendBescheidCommand() {
- var command = CommandTestFactory.createBuilder().id(null).order("SEND_BESCHEID").build();
+ var command = CommandTestFactory.createBuilder().id(null).order(SEND_BESCHEID_ORDER).build();
return mongoOperations.save(command);
}
private PersistedCommand savePatchAttachedItemSubCommand(String id) {
- Map<String, Object> itemBody = Map.of("parentId", id);
+ Map<String, Object> itemBody = Map.of(PARENT_ID_FIELD, id);
var command = CommandTestFactory.createBuilder()
.id(null)
- .order("PATCH_ATTACHED_ITEM")
+ .order(PATCH_ATTACHED_ITEM_ORDER)
.bodyObject(itemBody)
.build();
return mongoOperations.save(command);
}
private PersistedCommand saveOtherSubCommand(String id) {
- Map<String, Object> itemBody = Map.of("parentId", id);
+ Map<String, Object> itemBody = Map.of(PARENT_ID_FIELD, id);
var command = CommandTestFactory.createBuilder()
.id(null)
.bodyObject(itemBody)
@@ -96,14 +102,14 @@ class M014_AddItemNameBescheidToPatchAttachedItemCommandITCase {
private PersistedCommand saveOtherPatchAttachedItemSubCommand() {
var command = CommandTestFactory.createBuilder()
.id(null)
- .order("PATCH_ATTACHED_ITEM")
+ .order(PATCH_ATTACHED_ITEM_ORDER)
.build();
return mongoOperations.save(command);
}
private PersistedCommand buildExpectedPatchAttachedItemCommand(Command patchAttachedItemCommand) {
var body = new HashMap<>(patchAttachedItemCommand.getBodyObject());
- body.put("itemName", "Bescheid");
+ body.put(ITEM_NAME_FIELD, BESCHEID_ITEM_NAME);
return CommandTestFactory.createBuilder()
.id(patchAttachedItemCommand.getId())
.order(patchAttachedItemCommand.getOrder())
--
GitLab