From fbfb3702a518ad2e724a3ba1534cbea2b6534c28 Mon Sep 17 00:00:00 2001
From: Alexander Reifschneider <alexander.reifschneider@mgm-tp.com>
Date: Fri, 11 Apr 2025 15:23:33 +0200
Subject: [PATCH] OZG-7707 Add missing labels for a11y

---
 .../aggregation-mapping-field-form.component.html               | 2 +-
 .../bescheid-wizard-container.component.html                    | 2 +-
 .../src/lib/download-button/download-button.component.ts        | 2 +-
 alfa-client/libs/design-system/src/assets/person.svg            | 2 +-
 .../src/lib/form/button-toggle/button-toggle.component.ts       | 2 +-
 .../vorgang-detail-more-menu.component.html                     | 2 +-
 .../edit-zustaendige-stelle-button.component.html               | 2 +-
 .../search-zustaendige-stelle-dialog.component.html             | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-form-container/aggregation-mapping-form/aggregation-mapping-field-list-form/aggregation-mapping-field-form/aggregation-mapping-field-form.component.html b/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-form-container/aggregation-mapping-form/aggregation-mapping-field-list-form/aggregation-mapping-field-form/aggregation-mapping-field-form.component.html
index acf4e94784..a0cc29c61d 100644
--- a/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-form-container/aggregation-mapping-form/aggregation-mapping-field-list-form/aggregation-mapping-field-form/aggregation-mapping-field-form.component.html
+++ b/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-form-container/aggregation-mapping-form/aggregation-mapping-field-list-form/aggregation-mapping-field-form/aggregation-mapping-field-form.component.html
@@ -13,7 +13,7 @@
             [dataTestId]="'remove-mapping-button-' + index"
             [attr.data-test-id]="'remove-mapping-' + index"
           >
-            <ods-icon icon name="delete" fill="error" />
+            <ods-icon icon name="delete" fill="error" label="Datenfeld entefernen" />
           </ods-button>
         </div>
         <div class="flex flex-col gap-4">
diff --git a/alfa-client/libs/bescheid/src/lib/bescheid-wizard-container/bescheid-wizard-container.component.html b/alfa-client/libs/bescheid/src/lib/bescheid-wizard-container/bescheid-wizard-container.component.html
index 33e0e261cd..02047d13cc 100644
--- a/alfa-client/libs/bescheid/src/lib/bescheid-wizard-container/bescheid-wizard-container.component.html
+++ b/alfa-client/libs/bescheid/src/lib/bescheid-wizard-container/bescheid-wizard-container.component.html
@@ -37,7 +37,7 @@
           (clickEmitter)="cancelWizard(bescheidStateResource.resource)"
           dataTestId="close-bescheid"
         >
-          <ods-icon icon name="close" fill="text" />
+          <ods-icon icon name="close" fill="text" label="Bescheid-Popup schließen" />
         </ods-button>
         <alfa-bescheid-wizard
           [vorgangWithEingangResource]="vorgangWithEingangResource"
diff --git a/alfa-client/libs/design-component/src/lib/download-button/download-button.component.ts b/alfa-client/libs/design-component/src/lib/download-button/download-button.component.ts
index c06c96a111..6def584caa 100644
--- a/alfa-client/libs/design-component/src/lib/download-button/download-button.component.ts
+++ b/alfa-client/libs/design-component/src/lib/download-button/download-button.component.ts
@@ -42,7 +42,7 @@ type IconVariants = VariantProps<typeof iconVariants>;
     [isLoading]="isLoading"
     (click)="clickEmitter.emit()"
   >
-    <ods-icon icon name="save" [size]="size" fill="text" />
+    <ods-icon icon name="save" [size]="size" fill="text" label="herunterladen" />
   </ods-button>`,
 })
 export class DownloadButtonComponent {
diff --git a/alfa-client/libs/design-system/src/assets/person.svg b/alfa-client/libs/design-system/src/assets/person.svg
index 3609afd166..6f1df5c9d9 100644
--- a/alfa-client/libs/design-system/src/assets/person.svg
+++ b/alfa-client/libs/design-system/src/assets/person.svg
@@ -1,4 +1,4 @@
-<svg xmlns="http://www.w3.org/2000/svg" aria-hidden="true" viewBox="0 0 24 24">
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24">
   <path
     d="M11.38.244C8.46.544 6.201 3.055 6.201 6c0 2.167 1.254 4.2 3.191 5.176 3.313 1.669 7.33-.175 8.226-3.775a5.52 5.52 0 0 0 0-2.802 5.554 5.554 0 0 0-1.489-2.653C14.878.671 13.17.06 11.38.244m1.54 2.076c.743.18 1.564.705 2.037 1.306.312.396.615 1.008.729 1.474.125.507.125 1.293 0 1.8a4.033 4.033 0 0 1-1.31 2.058 4.528 4.528 0 0 1-1.456.729c-.488.131-1.352.131-1.84 0a4.496 4.496 0 0 1-1.463-.735C9.01 8.465 8.501 7.663 8.314 6.9c-.125-.507-.125-1.293 0-1.8.366-1.487 1.609-2.613 3.159-2.86.336-.053 1.058-.013 1.447.08M7.78 14.644c-2.403.246-4.401 1.987-5 4.355-.16.637-.186 1.031-.173 2.624l.013 1.483.121.197a.998.998 0 0 0 1.718 0l.121-.196.024-1.644c.028-1.891.046-2.011.394-2.723A3.851 3.851 0 0 1 7.5 16.711l.36-.091h8.28l.36.091a3.851 3.851 0 0 1 2.502 2.029c.348.712.366.832.394 2.723l.024 1.644.121.196a.998.998 0 0 0 1.718 0l.121-.197.013-1.483c.013-1.593-.013-1.987-.173-2.624a5.574 5.574 0 0 0-1.491-2.653 5.667 5.667 0 0 0-3.563-1.704c-.493-.05-7.899-.048-8.386.002"
     fill-rule="evenodd" />
diff --git a/alfa-client/libs/design-system/src/lib/form/button-toggle/button-toggle.component.ts b/alfa-client/libs/design-system/src/lib/form/button-toggle/button-toggle.component.ts
index 5acc3f1220..6567ac0a3e 100644
--- a/alfa-client/libs/design-system/src/lib/form/button-toggle/button-toggle.component.ts
+++ b/alfa-client/libs/design-system/src/lib/form/button-toggle/button-toggle.component.ts
@@ -42,7 +42,7 @@ import { IconComponent } from '../../icon/icon.component';
     data-test-id="button-toggle"
   >
     @if (isChecked) {
-      <ods-icon name="check" size="small" data-test-id="toggle-check-icon" />
+      <ods-icon name="check" size="small" data-test-id="toggle-check-icon" label="ausgewählt" />
     }
     <p class="text-sm">{{ label }}</p>
   </button>`,
diff --git a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-detail-more-menu.component.html b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-detail-more-menu.component.html
index fd46a637a0..9ada560c6e 100644
--- a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-detail-more-menu.component.html
+++ b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-detail-more-menu.component.html
@@ -24,7 +24,7 @@
 
 -->
 <ods-dropdown-menu buttonTestId="more-menu-button">
-  <ods-icon button-content *ngIf="buttonEnabled" name="more" data-test-id="more-menu-icon" fill="text" />
+  <ods-icon button-content *ngIf="buttonEnabled" name="more" data-test-id="more-menu-icon" fill="text" label="Menü ausklappen" />
   <ods-dropdown-menu-text-item
     *ngIf="vorgangWithEingang | hasLink: vorgangWithEingangLinkRel.ARCHIVE"
     data-test-id="vorgang-archive-button"
diff --git a/alfa-client/libs/zustaendige-stelle/src/lib/edit-zustaendige-stelle-button/edit-zustaendige-stelle-button.component.html b/alfa-client/libs/zustaendige-stelle/src/lib/edit-zustaendige-stelle-button/edit-zustaendige-stelle-button.component.html
index 85dd821da8..b5e93647ab 100644
--- a/alfa-client/libs/zustaendige-stelle/src/lib/edit-zustaendige-stelle-button/edit-zustaendige-stelle-button.component.html
+++ b/alfa-client/libs/zustaendige-stelle/src/lib/edit-zustaendige-stelle-button/edit-zustaendige-stelle-button.component.html
@@ -30,5 +30,5 @@
   [dataTestId]="dataTestId"
   (clickEmitter)="openSearchDialog()"
 >
-  <ods-icon icon name="edit" />
+  <ods-icon icon name="edit" label="Zustänndige Stelle bearbeiten" />
 </ods-button>
diff --git a/alfa-client/libs/zustaendige-stelle/src/lib/search-zustaendige-stelle-dialog/search-zustaendige-stelle-dialog.component.html b/alfa-client/libs/zustaendige-stelle/src/lib/search-zustaendige-stelle-dialog/search-zustaendige-stelle-dialog.component.html
index d72dfccc45..d8f40eb7da 100644
--- a/alfa-client/libs/zustaendige-stelle/src/lib/search-zustaendige-stelle-dialog/search-zustaendige-stelle-dialog.component.html
+++ b/alfa-client/libs/zustaendige-stelle/src/lib/search-zustaendige-stelle-dialog/search-zustaendige-stelle-dialog.component.html
@@ -27,7 +27,7 @@
   <div class="flex gap-48 py-6 lg:gap-96">
     <h1 class="text-xl font-bold text-primary">{{ title }}</h1>
     <ods-button variant="ghost" size="fit" (clickEmitter)="closeDialog()" dataTestId="close-search-dialog">
-      <ods-icon icon name="close" />
+      <ods-icon icon name="close" label="Dialogfenster schließen" />
     </ods-button>
   </div>
   <alfa-search-zustaendige-stelle-form-container (searchResultSelected)="searchResultSelected($event)" />
-- 
GitLab