From fa8af846e292545ce0972368739f04d2fdeb4ace Mon Sep 17 00:00:00 2001
From: sebo <sebastian.bergandy@external.mgm-cp.com>
Date: Sun, 23 Mar 2025 19:22:11 +0100
Subject: [PATCH] OZG-7473 rename method
Based on CR comment.
---
.../aggregation-mapping.formservice.spec.ts | 4 ++--
.../aggregation-mapping.formservice.ts | 2 +-
.../src/lib/aggregation-mapping.service.spec.ts | 6 +++---
.../reporting-shared/src/lib/aggregation-mapping.service.ts | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-form-container/aggregation-mapping-form/aggregation-mapping.formservice.spec.ts b/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-form-container/aggregation-mapping-form/aggregation-mapping.formservice.spec.ts
index 72ad99b1cc..8aae7f66f7 100644
--- a/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-form-container/aggregation-mapping-form/aggregation-mapping.formservice.spec.ts
+++ b/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-form-container/aggregation-mapping-form/aggregation-mapping.formservice.spec.ts
@@ -128,14 +128,14 @@ describe('AggregationMappingFormService', () => {
const stateResource: StateResource<AggregationMappingResource> = createStateResource(createAggregationMappingResource());
beforeEach(() => {
- service.getByCurrentUrl.mockReturnValue(of(stateResource));
+ service.get.mockReturnValue(of(stateResource));
formService._patchForm = jest.fn();
});
it('should get by current url', () => {
formService.get();
- expect(service.getByCurrentUrl).toHaveBeenCalled();
+ expect(service.get).toHaveBeenCalled();
});
it('should patch form', () => {
diff --git a/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-form-container/aggregation-mapping-form/aggregation-mapping.formservice.ts b/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-form-container/aggregation-mapping-form/aggregation-mapping.formservice.ts
index 3096bf7854..09c620e51c 100644
--- a/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-form-container/aggregation-mapping-form/aggregation-mapping.formservice.ts
+++ b/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-form-container/aggregation-mapping-form/aggregation-mapping.formservice.ts
@@ -58,7 +58,7 @@ export class AggregationMappingFormservice extends AbstractFormService<Aggregati
}
public get(): Observable<StateResource<AggregationMappingResource>> {
- return this.aggregationMappingService.getByCurrentUrl().pipe(
+ return this.aggregationMappingService.get().pipe(
filter(isLoaded),
tap((stateResource: StateResource<AggregationMappingResource>) => this._patchForm(stateResource.resource)),
);
diff --git a/alfa-client/libs/admin/reporting-shared/src/lib/aggregation-mapping.service.spec.ts b/alfa-client/libs/admin/reporting-shared/src/lib/aggregation-mapping.service.spec.ts
index 0846feed2d..a3fa52a58e 100644
--- a/alfa-client/libs/admin/reporting-shared/src/lib/aggregation-mapping.service.spec.ts
+++ b/alfa-client/libs/admin/reporting-shared/src/lib/aggregation-mapping.service.spec.ts
@@ -95,20 +95,20 @@ describe('AggregationMappingService', () => {
});
});
- describe('get by current url', () => {
+ describe('get', () => {
const stateResource = createStateResource(createAggregationMappingResource());
beforeEach(() => {
resourceService.get = jest.fn().mockReturnValue(of(stateResource));
});
it('should call resource service', () => {
- service.getByCurrentUrl();
+ service.get();
expect(resourceService.get).toHaveBeenCalled();
});
it('should emit resource', () => {
- expect(service.getByCurrentUrl()).toBeObservable(singleColdCompleted(stateResource));
+ expect(service.get()).toBeObservable(singleColdCompleted(stateResource));
});
});
diff --git a/alfa-client/libs/admin/reporting-shared/src/lib/aggregation-mapping.service.ts b/alfa-client/libs/admin/reporting-shared/src/lib/aggregation-mapping.service.ts
index 333d530998..96c72825e5 100644
--- a/alfa-client/libs/admin/reporting-shared/src/lib/aggregation-mapping.service.ts
+++ b/alfa-client/libs/admin/reporting-shared/src/lib/aggregation-mapping.service.ts
@@ -22,7 +22,7 @@ export class AggregationMappingService {
this.listService.refresh();
}
- public getByCurrentUrl(): Observable<StateResource<AggregationMappingResource>> {
+ public get(): Observable<StateResource<AggregationMappingResource>> {
return this.resourceService.get();
}
--
GitLab